Configuring Checkstyle/Detekt with gradle-api artifact [263876380]

Fixed

Bug

Status Update

No update yet.

Description

dr...@gmail.com

created issue #1

Dec 28, 2022 11:52PM

I'm attempting to move my Gradle plugins to the AGP gradle-api artifact and one blocker is configuring static analysis tools such as Checkstyle and Detekt. I have an example repo published here which shows a Gradle plugin that configures Checkstyle on Android modules (the Detekt use case is almost identical).

The core issue is that both the Checkstyle and Detekt tasks extend Gradle's SourceTask which takes a FileTree as input for the source files it will process. I don't see a good way to get this from the new AGP APIs that are exposed in the gradle-api artifact.

Last tested with AGP 8.0.0-alpha10

Comments

ze...@google.com <ze...@google.com> Jan 2, 2023 12:12PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> #2Jan 4, 2023 06:02AM

Reassigned to je...@google.com.

We have passed this to the development team and will update this issue with more information as it becomes available.

dr...@gmail.com <dr...@gmail.com> #3Jan 4, 2023 06:31AM

This also affects payment apps that start activity from HCE service when user taps the phone on NFC terminal, like our company's Wave2Pay or even your own Google Pay.

je...@google.com <je...@google.com> #4Jan 4, 2023 04:15PM

Please don't harm automation apps, at least allow foreground services : this is affect a lot of app (include mine, Tasker, MacroDroid, ...)
You take down SMS & Call Log permissions, now you take down all entire automation apps.

This will ruin a lot of apps, and developers life...
Please reconsider your decision or propose an alternative !

dr...@gmail.com <dr...@gmail.com> #5Jan 4, 2023 05:46PM

This affects my accessibility app (Digilux) that lets users launch activities from the accessibility button provided in Android O.

je...@google.com <je...@google.com> #6Jan 5, 2023 04:10AM

I agree with the author. See also:

https://issuetracker.google.com/issues/128511873

dr...@gmail.com <dr...@gmail.com> #7Jan 5, 2023 06:29PM

Google should be supporting and encouraging automation app developers and users, not limiting us!

je...@google.com <je...@google.com> #8Jan 5, 2023 09:35PM

Marked as fixed.

Agree. We have a remote control automation app but the user is always in control of the launch of activities from the remote. Can Google not consider allowing the user to enable/disable this from the security tab and or insist that a foreground service with a persistent notification is exempt?