Lint false positive about remember after Kotlin upgrade to 1.8.0 [263887242]

Fixed

Bug

Status Update

No update yet.

Description

eu...@gmail.com

created issue #1

Dec 29, 2022 02:40PM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Migrate project dependencies file to use 1.8.0
Run lint
Observe remember calls must not return Unit error that is false positive

Snippet of code that produces error:

val availableDoses = remember(state.selectableDoses) {                              
      state.selectableDoses.mapNotNull { it.toHumanReadable(context) }
}

The simple modification to next code just fix it:

val availableDoses = remember(state.selectableDoses) {
      val strings = state.selectableDoses.mapNotNull { it.toHumanReadable(context) }
      strings
}

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Version of Gradle Plugin: 7.3.1
Version of Gradle: 7.6
Version of Java: 19.0.1 (Azul Systems, Inc. 19.0.1+10)
OS: Mac OS X 13.1 aarch64

Comments

eu...@gmail.com <eu...@gmail.com> #2Dec 29, 2022 02:47PM

for example, many different devices return the same longitude and latitude.such as : longitude is 121.474000 and latitude is 31.230001.
i donnot understand why is the data the same?

eu...@gmail.com <eu...@gmail.com> #3Dec 30, 2022 07:59AM

the fractional part of the location data is exactly the same.

vi...@google.com <vi...@google.com> Jan 2, 2023 09:23AM

Assigned to an...@google.com.

js...@google.com <js...@google.com> Jan 10, 2023 01:20AM

Status: New

js...@google.com <js...@google.com> #4Jan 10, 2023 05:49AM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

What steps are needed to reproduce this issue? Frequency of occurrence?

Which Android build are you using? (e.g. AP4A.241205.013.A1)

Which device did you use to reproduce this issue?

Can you confirm if this issue is reproducible on a Pixel/Nexus device?

Please provide a sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Note: Please upload the bug report and screenshot to google drive and share the folder to android-bugreport@google.com, then share the link here.

js...@google.com <js...@google.com> Jan 11, 2023 07:17PM

Assigned to lp...@google.com.

js...@google.com <js...@google.com> Jan 13, 2023 05:42AM

Reassigned to js...@google.com.

js...@google.com <js...@google.com> #5Jan 14, 2023 01:01AM

Marked as fixed.

Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.

sj...@gmail.com <sj...@gmail.com> #6Jul 19, 2023 10:16AM

I only aply permission android.permission.ACCESS_COARSE_LOCATION.I use android.location.Location in the program.
for example,we hava 100 users.
20 users returned the same location information, longitude is 121.474000 and latitude is 31.230001。
30 users returned the same location information, longitude is 122.474000 and latitude is 32.230001。
15 users returned the same location information, longitude is 120.474000 and latitude is 30.230001。

as for Android build,all versions have it.
I dont reprodouce this issue.

what may be the cause of this issue?please

eu...@gmail.com <eu...@gmail.com> #7Jul 19, 2023 11:07AM

We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

js...@google.com <js...@google.com> #8Jul 19, 2023 06:35PM

Thanks for reporting this issue.

COARSE_LOCATION typically takes location information from the nearby cell tower. If many users are near the same cell tower, each of those users will be given the same position. Using a FINE position will give much more detailed information.

Also, in certain areas, for privacy reasons, a less-exact location will be given, and that less-exact location might be identical for many users. Again, a fine-location configuration will return more precise location data.

sj...@gmail.com <sj...@gmail.com> #9Jul 19, 2023 06:42PM

We believe with reference to the above comment, your query has been answered, hence closing the bug. Please feel free to re-open the issue in the future if desired.

js...@google.com <js...@google.com> #10Jul 19, 2023 06:46PM

Thank you very much! it is very useful to me . It solved my confusion.

sj...@gmail.com <sj...@gmail.com> #11Jul 20, 2023 05:37AM

I cannot reproduce this with AGP 8.2.0-alpha12. I also noticed a few other false positives, like claiming that Iterable.forEach() (Kotlin) is only available since SDK 24.

js...@google.com <js...@google.com> #12Jul 20, 2023 05:30PM

I cannot reproduce this with AGP 8.2.0-alpha12.

Thanks for trying that and confirmation.

I also noticed a few other false positives, like claiming that Iterable.forEach() (Kotlin) is only available since SDK 24.

That's exactly same as https://issuetracker.google.com/issues/185418482

Th...@aexp.com <Th...@aexp.com> #13Dec 1, 2023 02:36PM

I just upgrade to 8.2.0 and still get the error with:

    val frontImageByteArray = remember(key1 = state) {
        Base64.decode(state.data.frontImage, Base64.DEFAULT)
    }

Error: remember calls must not return Unit [RememberReturnType from androidx.compose.runtime]