Lint false positive about remember after Kotlin upgrade to 1.8.0 [263887242]

Fixed

Bug

Status Update

No update yet.

Description

eu...@gmail.com

created issue #1

Dec 29, 2022 02:40PM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Migrate project dependencies file to use 1.8.0
Run lint
Observe remember calls must not return Unit error that is false positive

Snippet of code that produces error:

val availableDoses = remember(state.selectableDoses) {                              
      state.selectableDoses.mapNotNull { it.toHumanReadable(context) }
}

The simple modification to next code just fix it:

val availableDoses = remember(state.selectableDoses) {
      val strings = state.selectableDoses.mapNotNull { it.toHumanReadable(context) }
      strings
}

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Version of Gradle Plugin: 7.3.1
Version of Gradle: 7.6
Version of Java: 19.0.1 (Azul Systems, Inc. 19.0.1+10)
OS: Mac OS X 13.1 aarch64

Comments

eu...@gmail.com <eu...@gmail.com> #2Dec 29, 2022 02:47PM

This is also observed on CI that is run on the Ubuntu.

eu...@gmail.com <eu...@gmail.com> #3Dec 30, 2022 07:59AM

I just updated the project to use AGP 7.4.0-rc03, and I don't see it.

vi...@google.com <vi...@google.com> Jan 2, 2023 09:23AM

Assigned to an...@google.com.

js...@google.com <js...@google.com> Jan 10, 2023 01:20AM

Status: New

js...@google.com <js...@google.com> #4Jan 10, 2023 05:49AM

Filed an upstream issue: https://youtrack.jetbrains.com/issue/KTIJ-24209

js...@google.com <js...@google.com> Jan 11, 2023 07:17PM

Assigned to lp...@google.com.

js...@google.com <js...@google.com> Jan 13, 2023 05:42AM

Reassigned to js...@google.com.

js...@google.com <js...@google.com> #5Jan 14, 2023 01:01AM

Marked as fixed.

Fixed here: https://cs.android.com/androidx/platform/frameworks/support/+/b2fb4fd888561fa538f4a9b9fcec3683ac82f01a

sj...@gmail.com <sj...@gmail.com> #6Jul 19, 2023 10:16AM

I believe we have a regression here. Getting a lot of these false positive warnings now after updating to Kotlin 1.9.0 and Compose Compiler 1.5.0.

eu...@gmail.com <eu...@gmail.com> #7Jul 19, 2023 11:07AM

Same! The issue is back with Kotlin 1.9 and Compose Compiler 1.5.0.

js...@google.com <js...@google.com> #8Jul 19, 2023 06:35PM

Similar regressions were reported recently, like https://issuetracker.google.com/issues/185418482#comment30 and so on, and I wonder your AGP version is a bit out-dated?

https://issuetracker.google.com/issues/185418482#comment20 might explain why we're seeing this kind of regressions repeatedly when there are version differences between kotlinc bundled in Lint v.s. actual compiler in use.

sj...@gmail.com <sj...@gmail.com> #9Jul 19, 2023 06:42PM

I'm using current stable version 8.0.2 of AGP

js...@google.com <js...@google.com> #10Jul 19, 2023 06:46PM

Yeah, that's exactly same as what others reported at https://issuetracker.google.com/issues/185418482#comment30 and https://issuetracker.google.com/issues/185418482#comment31

The problem reoccurred with Kotlin stdlib 1.9.0 and AGP 8.0.2.

problem started reappearing with Kotlin 1.9.0 and AGP 8.0.2.

Could you try one of latest canaries, say, AGP 8.2.0-alpha12?

sj...@gmail.com <sj...@gmail.com> #11Jul 20, 2023 05:37AM

I cannot reproduce this with AGP 8.2.0-alpha12. I also noticed a few other false positives, like claiming that Iterable.forEach() (Kotlin) is only available since SDK 24.

js...@google.com <js...@google.com> #12Jul 20, 2023 05:30PM

I cannot reproduce this with AGP 8.2.0-alpha12.

Thanks for trying that and confirmation.

I also noticed a few other false positives, like claiming that Iterable.forEach() (Kotlin) is only available since SDK 24.

That's exactly same as https://issuetracker.google.com/issues/185418482

Th...@aexp.com <Th...@aexp.com> #13Dec 1, 2023 02:36PM

I just upgrade to 8.2.0 and still get the error with:

    val frontImageByteArray = remember(key1 = state) {
        Base64.decode(state.data.frontImage, Base64.DEFAULT)
    }

Error: remember calls must not return Unit [RememberReturnType from androidx.compose.runtime]