Explore more supported qualities for VideoCapture [263961771]

Fixed

Feature Request

Status Update

No update yet.

Description

le...@google.com

created issue #1

Dec 29, 2022 05:55PM

By design, CameraX VideoCapture refers to the CamcorderProfile's supported quality.

However, there could be some supported qualities which are not listed by CamcorderProfile. The common one is UHD(2160P). CameraX will need a common approach to explore more supported qualities on each device and adds them to the supported quality list.

Comments

wu...@insta360.com <wu...@insta360.com> #2Apr 12, 2023 02:02AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

le...@google.com <le...@google.com> Sep 6, 2023 05:37AM

Reassigned to le...@google.com.

le...@google.com <le...@google.com> Oct 3, 2023 04:55AM

Accepted by le...@google.com.

ap...@google.com <ap...@google.com> #3Oct 5, 2023 01:59AM

Project: platform/frameworks/support
Branch: androidx-main

commit 500c79fb03a7dc7d8f5d343e2dcd1b6d7e641785
Author: leo huang <leohuang@google.com>
Date: Mon Oct 02 09:53:01 2023

Move CapabilitiesByQuality to a single class

The class will be reused later.

Bug: 263961771
Test: ./gradlew camera:camera-video:testDebug
Change-Id: I87b8d97f26f969a62fa984ef15c31568a6a58e2e

A camera/camera-video/src/main/java/androidx/camera/video/CapabilitiesByQuality.java
M camera/camera-video/src/main/java/androidx/camera/video/Recorder.java
M camera/camera-video/src/main/java/androidx/camera/video/RecorderVideoCapabilities.java
M camera/camera-video/src/main/java/androidx/camera/video/VideoCapabilities.java
M camera/camera-video/src/main/java/androidx/camera/video/VideoCapture.java
A camera/camera-video/src/test/java/androidx/camera/video/CapabilitiesByQualityTest.kt
M camera/camera-video/src/test/java/androidx/camera/video/RecorderVideoCapabilitiesTest.kt
M camera/camera-video/src/test/java/androidx/camera/video/VideoCaptureTest.kt

https://android-review.googlesource.com/2770785

ap...@google.com <ap...@google.com> #4Oct 13, 2023 02:56AM

Project: platform/frameworks/support
Branch: androidx-main

commit a9faca4c7962f86544f6fd6cd3e16a8253644764
Author: leo huang <leohuang@google.com>
Date: Thu Oct 05 13:57:09 2023

[Refactor] Pass and use VideoEncoderInfo finder instead of VideoProfile validator in BackupHdrProfileEncoderProfilesProvider

Some benefits to do so
* Since the QualityExploredEncoderProfilesProvider needs to do something similar to the BackupHdrProfileEncoderProfilesProvider.validateOrAdapt() but slightly different in creating the VideoProfile, it would be more flexible if we just provided the VideoEncoderInfo finder.
* The way to find VideoEncoderInfo can be consistent between EncoderProfilesProviders.
* The default finder instance can be reused.

Bug: 263961771
Test: ./gradlew camera:camera-video:testDebug
Change-Id: Ia6f1bfde1c6e19d8f4db570b7fff02dc64778160

M camera/camera-video/src/androidTest/java/androidx/camera/video/RecorderVideoCapabilitiesTest.kt
M camera/camera-video/src/androidTest/java/androidx/camera/video/internal/BackupHdrProfileEncoderProfilesProviderTest.kt
M camera/camera-video/src/main/java/androidx/camera/video/Recorder.java
M camera/camera-video/src/main/java/androidx/camera/video/RecorderVideoCapabilities.java
M camera/camera-video/src/main/java/androidx/camera/video/VideoCapture.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/BackupHdrProfileEncoderProfilesProvider.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/encoder/VideoEncoderInfoImpl.java
M camera/camera-video/src/test/java/androidx/camera/video/RecorderVideoCapabilitiesTest.kt
M camera/camera-video/src/test/java/androidx/camera/video/internal/BackupHdrProfileEncoderProfilesProviderTest.kt

https://android-review.googlesource.com/2776668

ap...@google.com <ap...@google.com> #5Oct 13, 2023 02:56AM

Project: platform/frameworks/support
Branch: androidx-main

commit dd2631baf7de4bf276cc3dc114af24820b72110c
Author: leo huang <leohuang@google.com>
Date: Tue Oct 03 11:15:10 2023

Add QualityExploredEncoderProfilesProvider

This class will base on camera and codec capabilities to explore more quailities beyond CamcorderProfile.

Bug: 263961771
Test: ./gradlew camera:camera-video:testDebug
Change-Id: I7aa5c52389b29c509433418991a4390895bc6501

M camera/camera-core/src/main/java/androidx/camera/core/internal/utils/SizeUtil.java
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/EncoderProfilesUtil.kt
M camera/camera-video/src/main/java/androidx/camera/video/CapabilitiesByQuality.java
M camera/camera-video/src/main/java/androidx/camera/video/Quality.java
M camera/camera-video/src/main/java/androidx/camera/video/RecorderVideoCapabilities.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/BackupHdrProfileEncoderProfilesProvider.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/DynamicRangeMatchedEncoderProfilesProvider.java
A camera/camera-video/src/main/java/androidx/camera/video/internal/QualityExploredEncoderProfilesProvider.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/config/VideoConfigUtil.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/utils/DynamicRangeUtil.java
A camera/camera-video/src/test/java/androidx/camera/video/internal/QualityExploredEncoderProfilesProviderTest.kt

https://android-review.googlesource.com/2770786

ap...@google.com <ap...@google.com> #6Oct 23, 2023 04:57AM

Project: platform/frameworks/support
Branch: androidx-main

commit 0f3a39df3c04c0c5b01f918fee7d76f35a15b9d5
Author: leo huang <leohuang@google.com>
Date: Wed Oct 04 14:51:01 2023

Support more qualities for VideoCapture

See go/camerax-video-support-more-qualities

Bug: 263961771
Test: ./gradlew camera:camera-video:testDebug
Change-Id: I692e12d62ad149f0d6a76ca11d886a98e70cc405

M camera/camera-video/src/androidTest/java/androidx/camera/video/RecorderTest.kt
M camera/camera-video/src/androidTest/java/androidx/camera/video/RecorderVideoCapabilitiesTest.kt
M camera/camera-video/src/main/java/androidx/camera/video/Recorder.java
M camera/camera-video/src/main/java/androidx/camera/video/RecorderVideoCapabilities.java
M camera/camera-video/src/test/java/androidx/camera/video/RecorderVideoCapabilitiesTest.kt

https://android-review.googlesource.com/2776669

ap...@google.com <ap...@google.com> #7Nov 3, 2023 02:46AM

Project: platform/frameworks/support
Branch: androidx-main

commit 23a7c4883a80a2f572c0172bc3e2e34b8e8452db
Author: leo huang <leohuang@google.com>
Date: Mon Oct 23 11:44:23 2023

Add public APIs to support more qualities for VideoCapture

See go/camerax-video-support-more-qualities

Relnote: "Added APIs to support more qualities for VideoCapture. Recorder.Builder#setVideoCapabilitiesSource(int) can be used with VIDEO_CAPABILITIES_SOURCE_CODEC_CAPABILITIES to create a Recorder instance which supports more qualities than VIDEO_CAPABILITIES_SOURCE_CAMCORDER_PROFILE. A common use case is when the application strives to record UHD video whenever feasible, but the device's CamcorderProfile does not include a UHD settings, even though the codec is capable of recording UHD video."

Bug: 263961771
Test: ./gradlew camera:camera-video:connectedAndroidTest
Change-Id: Iedbe2ae048c09a978b345b23d37ab989c000fd7a

M camera/camera-video/api/current.txt
M camera/camera-video/api/restricted_current.txt
M camera/camera-video/src/main/java/androidx/camera/video/Recorder.java

https://android-review.googlesource.com/2799073

le...@google.com <le...@google.com> Nov 28, 2023 05:52AM

Marked as fixed.

le...@google.com <le...@google.com> #8Nov 28, 2023 07:09AM

New API will be released on 1.4.0-alpha03

na...@google.com <na...@google.com> #9Dec 13, 2023 06:33PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-core:1.4.0-alpha03
androidx.camera:camera-video:1.4.0-alpha03