Fixed
Status Update
Comments
al...@google.com <al...@google.com>
wi...@google.com <wi...@google.com>
da...@gmail.com <da...@gmail.com> #2
Hi, is there any fix available for this bug?
ch...@google.com <ch...@google.com>
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit f46016287e7d95cc1a57b28fbdc5d0046bfe77fa
Author: chunmu <chunmu@google.com>
Date: Tue Jul 16 11:02:25 2024
Get splashscreen icon by AppCompatResources
Make splashscreen to get the drawables of icon and icon background by
AppCompatResources so as to provide better backport on API < 24
Bug: 289242141
Bug: 263972037
Test: Manually tested by modifying icons in the sample
Change-Id: Ib05e2e7da40ee7c7db39ff8512cfa97861b7ee3e
Signed-off-by: Chun-Mu Weng <chunmu@google.com>
M core/core-splashscreen/build.gradle
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreen.kt
https://android-review.googlesource.com/3175379
Branch: androidx-main
commit f46016287e7d95cc1a57b28fbdc5d0046bfe77fa
Author: chunmu <chunmu@google.com>
Date: Tue Jul 16 11:02:25 2024
Get splashscreen icon by AppCompatResources
Make splashscreen to get the drawables of icon and icon background by
AppCompatResources so as to provide better backport on API < 24
Bug: 289242141
Bug: 263972037
Test: Manually tested by modifying icons in the sample
Change-Id: Ib05e2e7da40ee7c7db39ff8512cfa97861b7ee3e
Signed-off-by: Chun-Mu Weng <chunmu@google.com>
M core/core-splashscreen/build.gradle
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreen.kt
ch...@google.com <ch...@google.com>
pr...@google.com <pr...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.core:core-splashscreen:1.2.0-alpha02
ch...@beyls.net <ch...@beyls.net> #5
Tell me if I'm wrong but the OS uses the SplashScreen theme to initially load the vector drawable in the zygote process on API 23+, before the Activity is even launched. At that moment, AppCompat can't be used anyway, so the display would still be incorrect on API 23 if the VD is using features like gradients.
Description
Component used:
androidx.core.splashscreen.SplashScreen
Version used: 1.0.0 Devices/Android versions reproduced on: Android 5, Android 6SplashScreen.install
method callsandroid.content.Context.getDrawable
on API 21. It, in turn, callsandroid.graphics.drawable.VectorDrawable.inflate
instead ofVectorDrawableCompat.inflate
.VectorDrawable
does not support some features like gradients, what may lead to a crash (see:VectorDrawable
.Suggestion: At least enable the users of the library to use
VectorDrawableCompat
instead ofVectorDrawable
.