Status Update
No update yet.
Comments
cc...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Scott Nien <
Link:
Fix the issue that PreviewViewMeteringPointFactory produces wrong coordinates when effect or stream sharing is enabled.
Expand for full commit details
Fix the issue that PreviewViewMeteringPointFactory produces wrong coordinates when effect or stream sharing is enabled.
The PreviewviewMeteringPointFactory uses the PreviewRotationDegrees to transform the
coordinates. This PreviewRotationDegrees in TransformationInfo does't
reflect the sensor_orientation and the display orientation when effect
or stream sharing is enabled.
Solution :
Use getSensorToBufferTransform from TransmationInfo instead to convert the view(x,y)
to sensor (x,y) and also set the surfaceAspectRatio as the sensor size.
Bug: 345993685
RelNote: "Fixed the issue where invoking startFocusMetering with
PreviewView.getMeteringPointFactory does't get the correct sensor
coordinates when an effect is enabled or when 4 use cases are bound
(stream-sharing)."
Test: All tests in camera-view
Change-Id: I916c55d371a2c2e7de798b21080318591f099561
Files:
- M
camera/camera-core/src/main/java/androidx/camera/core/MeteringPointFactory.java - M
camera/camera-core/src/main/java/androidx/camera/core/internal/CameraUseCaseAdapter.java - M
camera/camera-view/src/androidTest/java/androidx/camera/view/PreviewViewMeteringPointFactoryDeviceTest.kt - M
camera/camera-view/src/main/java/androidx/camera/view/PreviewTransformation.java - M
camera/camera-view/src/main/java/androidx/camera/view/PreviewView.java - M
camera/camera-view/src/main/java/androidx/camera/view/PreviewViewMeteringPointFactory.java - M
camera/camera-view/src/test/java/androidx/camera/view/PreviewViewMeteringPointFactoryTest.java
Hash: 4099c75fbc3979a18c18f435fbf508ffdd4c7ab1
Date: Fri Sep 27 14:17:44 2024
ys...@google.com
The issue is fixed and the fix will be included in 1.4.0-rc04 and 1.4.0 stable release as well as the new alpha in 1.5.0. Thanks for reporting this issue and I am sorry for not fixing it promptly.
ml...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.4.0-rc04androidx.camera:camera-view:1.4.0-rc04
be...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.5.0-alpha03androidx.camera:camera-view:1.5.0-alpha03
ra...@google.com
I don't think composition count counts as implementation detail though; and more importantly this is a very stable metric when compared to frame timing.
Definitely worth pursuing.
ml...@google.com
recomposition count without verifying it's actually a performance (frame
timing) problem.
On Tue, May 30, 2023, 19:55 rahulrav <buganizer-system+rahulrav@google.com>
wrote:
cc...@google.com
+1 to the Mode.Count idea, which makes this much easier to setup without clearly pushing people in that direction.
ap...@google.com
Branch: androidx-main
commit c03d654ce041fc2940842924f87cd2ccc3b9fb1b
Author: Tomáš Mlynarič <mlykotom@google.com>
Date: Wed Jun 07 15:18:46 2023
Add count measurement to TraceSectionMetric with Mode.Sum
Example:
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
dateFormattedCount min 13.0, median 15.5, max 20.0
dateFormattedDurMs min 1.4, median 1.9, max 2.4
RelNote: Add count measurement to TraceSectionMetric with Mode.Sum
Test: Updated
Fixes: 264398606
Change-Id: Ic121ac1432a973413b5318ccf5df6a2e1556419a
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceSectionMetricTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-macro:1.2.0-alpha16
Description
Component used:
Version used:
Devices/Android versions reproduced on:
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).