Suggestion make Composition counts available in the API [264398606]

Fixed

Bug

Status Update

No update yet.

Description

mm...@gmail.com

created issue #1

Jan 4, 2023 11:02PM

Could we please make the composition counts as described

https://developer.android.com/studio/releases#li-compose-counter here accessible in the public API alongside the FrameTimingMetric, AppStartupMetric, etc?

Component used:
Version used:
Devices/Android versions reproduced on:

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

Comments

cc...@google.com <cc...@google.com> #2Apr 20, 2023 12:34AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ys...@google.com <ys...@google.com> #3May 22, 2023 11:47AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ml...@google.com <ml...@google.com> #4May 25, 2023 11:35AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

be...@google.com <be...@google.com> #5May 29, 2023 04:01AM

This is pretty cool and no doubt useful. Part of me wonders if this is something we actually want to add though, aren't you testing internal Compose details at this point?

If you already have a benchmark set up, isn't frame timing and startup time a better actual metric to track than recomposition count? Hypothetically, Compose could make a behaviour change to the rules for recomposition and then your test could be marked as regressed on composition count but not on actual frame timing.

ra...@google.com <ra...@google.com> #6May 30, 2023 05:55PM

I don't think composition count counts as implementation detail though; and more importantly this is a very stable metric when compared to frame timing.

Definitely worth pursuing.

ml...@google.com <ml...@google.com> #7May 30, 2023 06:07PM

What I think Ben is also afraid is that people will be chasing
recomposition count without verifying it's actually a performance (frame
timing) problem.

On Tue, May 30, 2023, 19:55 rahulrav <buganizer-system+rahulrav@google.com>
wrote:

- Show quoted text -

cc...@google.com <cc...@google.com> #8May 30, 2023 08:17PM

+1 to the Mode.Count idea, which makes this much easier to setup without clearly pushing people in that direction.

ap...@google.com <ap...@google.com> #9Jun 7, 2023 03:48PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit c03d654ce041fc2940842924f87cd2ccc3b9fb1b
Author: Tomáš Mlynarič <mlykotom@google.com>
Date: Wed Jun 07 15:18:46 2023

Add count measurement to TraceSectionMetric with Mode.Sum

Example:
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
dateFormattedCount min 13.0, median 15.5, max 20.0
dateFormattedDurMs min 1.4, median 1.9, max 2.4

RelNote: Add count measurement to TraceSectionMetric with Mode.Sum
Test: Updated
Fixes: 264398606
Change-Id: Ic121ac1432a973413b5318ccf5df6a2e1556419a

M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceSectionMetricTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt

https://android-review.googlesource.com/2619430

pr...@google.com <pr...@google.com> #10Jun 21, 2023 08:57PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.2.0-alpha16