Provide a testable replacement for viewModelScope [264598574]

Fixed

Feature Request

Status Update

No update yet.

Description

ni...@ansman.se

created issue #1

Jan 7, 2023 01:48AM

Component used: androidx.lifecycle:lifecycle-viewmodel-ktx

Version used: 2.5.1

Devices/Android versions reproduced on: n/a

Given the new APIs for adding closables to view models, viewModelScope should probably be marked as discouraged or deprecated in order to promote testability.

Comments

ia...@gmail.com <ia...@gmail.com> #2Aug 13, 2023 12:16AM

Since this is happening in Tink, rather than in the AndroidX library, it would be best to open an issue with that project, as there isn't an easy way for us to fix this.

il...@google.com <il...@google.com> Aug 31, 2023 07:48PM

Assigned to sa...@google.com.

il...@google.com <il...@google.com> Sep 28, 2023 10:15PM

Reassigned to il...@google.com.

il...@google.com <il...@google.com> Feb 17, 2024 12:45AM

Reassigned to mg...@google.com.

mg...@google.com <mg...@google.com> Feb 23, 2024 05:58PM

Accepted by mg...@google.com.

ap...@google.com <ap...@google.com> #3Mar 5, 2024 01:02AM

Marked as fixed.

@2 I don't know what "Tink" is, but here, created:

https://github.com/google/tink/issues/534

Would this mean that this bug report should be written there as well:

https://issuetracker.google.com/issues/176215143
?

ap...@google.com <ap...@google.com> #4Mar 5, 2024 05:18PM

Tink is the library that does the heavy lifting in Jetpack Security.

And yes, potentially raising that issue with the Tink team directly could help.

pr...@google.com <pr...@google.com> #5Mar 20, 2024 08:26PM

@4 Well why didn't Google offer it there? Crashes are far more important than warning logs...
Here, created it there too:

https://github.com/google/tink/issues/535