Provide a testable replacement for viewModelScope [264598574]

Fixed

Feature Request

Status Update

No update yet.

Description

ni...@ansman.se

created issue #1

Jan 7, 2023 01:48AM

Component used: androidx.lifecycle:lifecycle-viewmodel-ktx

Version used: 2.5.1

Devices/Android versions reproduced on: n/a

Given the new APIs for adding closables to view models, viewModelScope should probably be marked as discouraged or deprecated in order to promote testability.

Comments

ia...@gmail.com <ia...@gmail.com> #2Aug 13, 2023 12:16AM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

il...@google.com <il...@google.com> Aug 31, 2023 07:48PM

Assigned to sa...@google.com.

il...@google.com <il...@google.com> Sep 28, 2023 10:15PM

Reassigned to il...@google.com.

il...@google.com <il...@google.com> Feb 17, 2024 12:45AM

Reassigned to mg...@google.com.

mg...@google.com <mg...@google.com> Feb 23, 2024 05:58PM

Accepted by mg...@google.com.

ap...@google.com <ap...@google.com> #3Mar 5, 2024 01:02AM

Marked as fixed.

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

ap...@google.com <ap...@google.com> #4Mar 5, 2024 05:18PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

pr...@google.com <pr...@google.com> #5Mar 20, 2024 08:26PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.