[Material3] Scaffold contentWindowInsets uses already consumed WindowInsets [264601542]

Fixed

Bug

Status Update

No update yet.

Description

an...@steadfastinnovation.com

created issue #1

Jan 7, 2023 01:07AM

Jetpack Compose version: 1.1.0-alpha03 Jetpack Compose component used: material3 Android Studio Build: Android Studio Dolphin | 2021.3.1 Patch 1 Kotlin version: 1.7.10

The Scaffold contentWindowInsets does not take into account whether or not the provided WindowInsets are consumed or not. All the other components (app bar, drawer, etc.) use the windowInsetsPadding modifier which only applies the unconsumed WindowInsets to the respective component.

In Scaffold, the raw values of the contentWindowInsets are used, regardless of whether any part of the insets is already consumed by a parent of Scaffold, causing the insets to be applied twice. This can be worked around by applying the appropriate insets outside of Scaffold and setting contentWindowInsets = WindowInsets(0, 0, 0, 0), but it would be helpful if instead Scaffold only used the unconsumed parts of contentWindowInsets.

I'm not entirely sure if this can be solved the same way, but I noticed that the unreleased SearchBar component appears to be doing something similar.

Comments

se...@gmail.com <se...@gmail.com> #2Apr 13, 2023 12:41AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6492a281bd17da7537f453a3fc01d182c79a169e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Jul 27 17:24:43 2020

Rename BottomNavigationItem parameters

text -> label to match the Material.io documentation and the `alwaysShowLabels` parameter
onSelected -> onSelect to match the tense we use in other components
activeColor -> selectedContentColor to be more clear about what this 'color' is, and match the selected state
inactiveColor -> unselectedContentColor to be more clear about waht this 'color' is, and match the not-selected state

Additionally fixes the ordering of parameters so that all required parameters are first, followed by the Modifier param.

Bug:

b/161809324

Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's `text` parameter to `label`, `onSelected` to `onSelect`, `activeColor` to `selectedContentColor`, `inactiveColor` to `unselectedContentColor` and updates parameter ordering to match guidelines."
Change-Id: Icb605dac9b76a0204a2a9d675530da8897f817d5

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt

https://android-review.googlesource.com/1373097

se...@google.com <se...@google.com> Jun 1, 2023 08:22PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> Jun 6, 2023 08:29PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #3Jun 14, 2023 02:18PM

Discussed further offline, onSelect should be renamed to onClick for consistency (with Tab and other components).

se...@google.com <se...@google.com> #4Jun 14, 2023 02:19PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dfd1e72afa17243e42449e955f08213f0a4afcd4
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 09 17:04:47 2020

Renames BottomNavigationItem's onSelect parameter to onClick for consistency with other components such as Tab

Bug:

b/161809324

Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's onSelect parameter to onClick"
Change-Id: I919251069ab307d1ed5c1c3fbf5a01bf77a85047

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt

https://android-review.googlesource.com/1423472

pr...@google.com <pr...@google.com> #5Jun 21, 2023 08:58PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.2.0-alpha03
androidx.compose.material3:material3-android:1.2.0-alpha03

Issue 264601542