[Material3] Scaffold contentWindowInsets uses already consumed WindowInsets [264601542]

Fixed

Bug

Status Update

No update yet.

Description

an...@steadfastinnovation.com

created issue #1

Jan 7, 2023 01:07AM

Jetpack Compose version: 1.1.0-alpha03 Jetpack Compose component used: material3 Android Studio Build: Android Studio Dolphin | 2021.3.1 Patch 1 Kotlin version: 1.7.10

The Scaffold contentWindowInsets does not take into account whether or not the provided WindowInsets are consumed or not. All the other components (app bar, drawer, etc.) use the windowInsetsPadding modifier which only applies the unconsumed WindowInsets to the respective component.

In Scaffold, the raw values of the contentWindowInsets are used, regardless of whether any part of the insets is already consumed by a parent of Scaffold, causing the insets to be applied twice. This can be worked around by applying the appropriate insets outside of Scaffold and setting contentWindowInsets = WindowInsets(0, 0, 0, 0), but it would be helpful if instead Scaffold only used the unconsumed parts of contentWindowInsets.

I'm not entirely sure if this can be solved the same way, but I noticed that the unreleased SearchBar component appears to be doing something similar.

Comments

se...@gmail.com <se...@gmail.com> #2Apr 13, 2023 12:41AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

se...@google.com <se...@google.com> Jun 1, 2023 08:22PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> Jun 6, 2023 08:29PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #3Jun 14, 2023 02:18PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

se...@google.com <se...@google.com> #4Jun 14, 2023 02:19PM

Marked as fixed.

An update to this behavior can be expected to land alongside 1.2.0-alpha04!

pr...@google.com <pr...@google.com> #5Jun 21, 2023 08:58PM