Custom Tab crashes with AppCompat Theme error [264952946]

Assigned

Bug

Status Update

No update yet.

Description

ba...@gmail.com

created issue #1

Jan 10, 2023 11:18AM

Component used: androidx.browser:browser
Version used: 1.4.0
Devices/Android versions reproduced on: Samsung S21 5g, Pixel 7

When the CCT is launched, we get a crash on some devcie like below:

Fatal Exception: java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity.
at androidx.appcompat.app.AppCompatDelegateImpl.createSubDecor(AppCompatDelegateImpl.java:852)
at androidx.appcompat.app.AppCompatDelegateImpl.ensureSubDecor(AppCompatDelegateImpl.java:815)
at androidx.appcompat.app.AppCompatDelegateImpl.onPostCreate(AppCompatDelegateImpl.java:536)
at androidx.appcompat.app.AppCompatActivity.onPostCreate(AppCompatActivity.java:151)
at android.app.Instrumentation.callActivityOnPostCreate(Instrumentation.java:1386)
at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3652)
at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:221)
at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:201)
at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:173)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2172)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:237)
at android.app.ActivityThread.main(ActivityThread.java:8163)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:656)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:972)

The Activity which launches the CCT extends AppCompatActivity and the theme is correctly set with Appcompat theme

Comments

pe...@google.com <pe...@google.com> #2Jan 11, 2023 08:42AM

having the same issue
Room version > 2.7.0-alpha08
agp = "8.2.2"
kotlin = "2.0.20"
ksp-plugin = "2.0.20-1.0.24"

also Reverting to Room version 2.7.0-alpha07 solves the issue.

ba...@gmail.com <ba...@gmail.com> #3Jan 11, 2023 08:45AM

Thanks for the report, this issue is likely due to the Room Gradle Plugin changes that try to also configure the android test app asset directory to include the schemas so the MigrationTestHelper can pick them up. I'll try to work on a fix soon.

pe...@google.com <pe...@google.com> #4Jan 11, 2023 08:58AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <danysantiago@google.com>
Link: https://android-review.googlesource.com/3391005

Configure the schema asset android copy task within its register block and not within AGP's wiredWith lambda.

Expand for full commit details

Configure the schema asset android copy task within its register block and not within AGP's wiredWith lambda. 
 
Otherwise the tasks inputs are locked by the time the wiredWith lambda passed to addGeneratedSourceDirector() is invoked and will lead to "property 'inputDirectory' is final and cannot be changed any further". 
 
Bug: 376071291 
Test: Manual with sample repro app 
Change-Id: I2c9da4855cd31d7df3276424546aba4c53edf7ea

Files:

M room/room-gradle-plugin/src/main/java/androidx/room/gradle/integration/AndroidPluginIntegration.kt

Hash: 1dbb4c1876e1e8a8e930bec4625741ac6dc05a0b
Date: Thu Dec 05 14:21:51 2024

ba...@gmail.com <ba...@gmail.com> #5Jan 11, 2023 09:00AM

I'm having the same problem in my Compose Multiplatform project and I'm using the latest version available 2.7.0-alpha12. The way I found to get around this was by adding the following task to my build.gradle

tasks.matching { it.name.startsWith("copyRoomSchemasToAndroidTestAssetsDebugAndroidTest") }.configureEach {
enabled = false
}

But I believe this is not the right thing to do, since I'm hiding the error. Is there another way to solve it or will the library be updated to fix it?

yf...@google.com <yf...@google.com> #6Jan 11, 2023 10:21PM

Unfortunately the fix did not make it to the alpha12 release, but it will indeed be in the next release.

ba...@gmail.com <ba...@gmail.com> #7Jan 12, 2023 09:00AM

When will this be released? It's more than a month now?

Screenshot 2023-01-12 at 09.42.55.png

46 KB

View

Download

pe...@google.com <pe...@google.com> #8Jan 13, 2023 09:51AM

Sorry for the delay - Next androidx release is January 29

ba...@gmail.com <ba...@gmail.com> #9Jan 16, 2023 10:53AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.room:room-gradle-plugin:2.7.0-alpha13

pe...@google.com <pe...@google.com> #10Jan 16, 2023 03:18PM

Ah, no worries.

Which of the Custom Tabs APIs specifically are you using? Which classes/methods from here are you calling?

Is it only the very basic usage like so:

String url = "https://google.com/";
CustomTabsIntent.Builder builder = new CustomTabsIntent.Builder();
CustomTabsIntent customTabsIntent = builder.build();
customTabsIntent.launchUrl(this, Uri.parse(url));

Or are you using more advanced features (eg, stuff from here)?

ba...@gmail.com <ba...@gmail.com> #11Jan 16, 2023 03:21PM

Hi, yes am using the very basic usage exactly like you posted with launchUrl method.

ba...@gmail.com <ba...@gmail.com> #12Jan 23, 2023 09:40PM

Hello guys, did you get any idea of how can this be fixed or is it a known issue?

ba...@gmail.com <ba...@gmail.com> #13Jan 23, 2023 10:14PM

By pkaying with some user flows I finally was able to reproduce the issue. Here is the flow i tested:

I installed a work profile in my device using Test DPC app.
I tried to launch the Chrome Custom Tab. The app is crashed with the exact log that i posted initially.

What i observed i that the work profile doesn't have any browser installed but rather than saying so package found to handle the intent, it throughs the error "java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity."

I can solve this with a try catch but is this exczption relevent to this case?

pe...@google.com <pe...@google.com> #14Jan 24, 2023 09:46AM

Hello (sorry for the delay, I was ill most of last week).

That is very interesting - though I find it odd that the work profile doesn't have a browser installed.

As an aside, do you have a <queries> entry in your manifest - for example the ones listed under "Check whether a browser is available" or "Open URL in Custom Tabs" here?

I think for your case, using a try-catch may be appropriate (or potentially querying what browsers are available and picking one).

+chrome-connective-tissue, in case they've come across something similar before.

tw...@google.com <tw...@google.com> #15Jan 24, 2023 11:11PM

Android's documentation on work profiles recommends #resolveActivity to determine if there's a way to handle the intent before firing:

https://developer.android.com/work/managed-profiles#prevent_failed_intents. Some intents can cross the profile boundary and some cannot.

Re #13 -- does your app have a fallback if sending the intent fails? A try-catch or calling #resolveActivity() before firing the intent would eliminate the crash but the UX flow may still be broken.