Update Kotlin metadata library to version 0.6.0 [265108171]

Fixed

Feature Request

Status Update

No update yet.

Description

sg...@google.com

created issue #1

Jan 11, 2023 08:41AM

https://github.com/JetBrains/kotlin/blob/d646906437aa9afe693723c87f86eaa7b8330246/libraries/kotlinx-metadata/jvm/ChangeLog.md#060

Comments

ap...@google.com <ap...@google.com> #2Jan 19, 2023 01:39PM

Could you please provide the dependencies you're using for your project?

Compose does not use protos for any production use case, so we will need more information to determine which dependency is pulling in the protobuf dependency.

ap...@google.com <ap...@google.com> #3Jan 23, 2023 04:33PM

libs.versions.toml does have protobuf version as "3.19.4"

And protobufs are used in production code for app inspection jars like the layout inspector jar that comes with compose:ui:ui

mk...@google.com <mk...@google.com> #4Jan 25, 2023 01:45PM

Marked as fixed.

Oh interesting, build.gradle doesn't declare this dependency though? Curious if androidx-main is the only place we'd to update.

ap...@google.com <ap...@google.com> #5Jan 25, 2023 01:59PM

Compose UI 1.3.2 updates this dependency: https://developer.android.com/jetpack/androidx/releases/compose-ui#1.3.2

ap...@google.com <ap...@google.com> #6Jan 25, 2023 01:59PM

Thanks

ap...@google.com <ap...@google.com> #7Jan 25, 2023 01:59PM

Project: r8
Branch: 8.0

commit 1db3d77589ae2bc16ba2501f9848d40afb780139
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 25 13:21:27 2023

Reland "[Metadata] Update kotlin-metadata-jvm to version 0.6.0"

This reverts commit 87b372dde22f9052f9fb86770921bdf6cb008ba6.

Change-Id: I7b361c05a686fbfffd399f5a7ee10f65c8513b2f
Bug:

b/265108171

M build.gradle
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassLevelInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassMetadataReader.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFileFacadeInfo.java
A src/main/java/com/android/tools/r8/kotlin/KotlinMetadataAnnotationWrapper.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataRewriter.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassFacadeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassPartInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/test/java/com/android/tools/r8/kotlin/coroutines/KotlinxCoroutinesTestRunner.java
M src/test/java/com/android/tools/r8/kotlin/metadata/KotlinMetadataTestBase.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteBoxedTypesTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlineClassTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlinePropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteKeepTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteLocalDelegatedPropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewritePassThroughTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteRawTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteUnitPrimitiveTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteValueClassTest.java

https://r8-review.googlesource.com/75405

ap...@google.com <ap...@google.com> #8Jan 26, 2023 11:36AM

Project: r8
Branch: main

commit 4ff176f892492b8bbb1a647f83cc0a9e679b40d9
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Thu Jan 26 09:58:05 2023

[Metadata] Move away from deprecated metadata visitors

Bug:

b/265108171

Change-Id: I3cd8f4b0a78ef6bfe9d9c38e2629b89315d0c9d1

D src/main/java/com/android/tools/r8/kotlin/KmVisitorProviders.java
M src/main/java/com/android/tools/r8/kotlin/KotlinAnnotationInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinConstructorInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinContractInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinDeclarationContainerInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinEffectExpressionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinEffectInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFlexibleTypeUpperBoundInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFunctionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinJvmMethodSignatureInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinLambdaInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinLocalDelegatedPropertyInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinPackageInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinPropertyInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeAliasInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeParameterInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeProjectionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinValueParameterInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinVersionRequirementInfo.java

https://r8-review.googlesource.com/75336