Update Kotlin metadata library to version 0.6.0 [265108171]

Fixed

Feature Request

Status Update

No update yet.

Description

sg...@google.com

created issue #1

Jan 11, 2023 08:41AM

https://github.com/JetBrains/kotlin/blob/d646906437aa9afe693723c87f86eaa7b8330246/libraries/kotlinx-metadata/jvm/ChangeLog.md#060

Comments

ap...@google.com <ap...@google.com> #2Jan 19, 2023 01:39PM

Looks like AndroidX tooling didn't catch this because it happened prior to migrating the development workflow to AndroidX. Should be avoidable in the future since we have API files checked in for 1.1.0, but for now this will need to be fixed and we'll want to do whatever we can to mitigate the breakage in the released artifact.

ap...@google.com <ap...@google.com> #3Jan 23, 2023 04:33PM

I guess you don't need extra reports but also fails for Measurer

androidx.constraintlayout.compose.Measurer: method 'void <init>()' not found
java.lang.NoSuchMethodError: androidx.constraintlayout.compose.Measurer: method 'void <init>()' not found
	at com.google.android.horologist.media.ui.screens.player.PlayerScreenKt.PlayerScreen(PlayerScreen.kt:273)

this is a Composable from a library

@Composable
public fun PlayerScreen(
    mediaDisplay: @Composable () -> Unit,
    controlButtons: @Composable () -> Unit,
    buttons: @Composable () -> Unit,
    modifier: Modifier = Modifier,
    background: @Composable BoxScope.() -> Unit = {},
) {
    Box(
        modifier = modifier
            .fillMaxSize(),
    ) {
        background()

        ConstraintLayout(
            modifier = Modifier.fillMaxSize(),
        ) {
            val (topSection, middleSection, bottomSection) = createRefs()

mk...@google.com <mk...@google.com> #4Jan 25, 2023 01:45PM

Marked as fixed.

hi all, is there any plan or workaround for this issue? would it be possible to bring back the old signatures that were removed to facilitate the update ? we are starting getting transitive bumps from third parties that are breaking other third parties sdks.

ap...@google.com <ap...@google.com> #5Jan 25, 2023 01:59PM

I have a change ready and tested locally where I simply bring back the removed signatures into the class. The change fixes the breaking change coming with constraintlayout-core 1.1.0.

Should I proceed opening a proposal PR ?

ap...@google.com <ap...@google.com> #6Jan 25, 2023 01:59PM

sorry for spamming.

https://android-review.googlesource.com/c/platform/frameworks/support/+/3442179 I have created a change here.

ap...@google.com <ap...@google.com> #7Jan 25, 2023 01:59PM

The issue is now fixed on the latest ConstraintLayout stable release.

https://developer.android.com/jetpack/androidx/releases/constraintlayout#constraintlayout-2.2.1

Thanks for your contribution!

ap...@google.com <ap...@google.com> #8Jan 26, 2023 11:36AM

Project: r8
Branch: main

commit 4ff176f892492b8bbb1a647f83cc0a9e679b40d9
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Thu Jan 26 09:58:05 2023

[Metadata] Move away from deprecated metadata visitors

Bug:

b/265108171

Change-Id: I3cd8f4b0a78ef6bfe9d9c38e2629b89315d0c9d1

D src/main/java/com/android/tools/r8/kotlin/KmVisitorProviders.java
M src/main/java/com/android/tools/r8/kotlin/KotlinAnnotationInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinConstructorInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinContractInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinDeclarationContainerInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinEffectExpressionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinEffectInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFlexibleTypeUpperBoundInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFunctionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinJvmMethodSignatureInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinLambdaInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinLocalDelegatedPropertyInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinPackageInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinPropertyInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeAliasInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeParameterInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeProjectionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinValueParameterInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinVersionRequirementInfo.java

https://r8-review.googlesource.com/75336