Regression after removal of field lookup cache [265148324]

Fixed

Bug

Status Update

No update yet.

Description

ze...@google.com

created issue #1

Jan 11, 2023 03:59PM

The resolution of b/151804585 did not introduce a new field backing, thus lookups within a class are linear search in the field arrays. This has noticeable performance impact witnessed in b/264430795

Using the dump information provided in b/264430795, the initial regression came with CLs:

353672ms 78a3b2fe030b465c46c1b2f858cada93659a0e40 Minor cleanup prior to definitionFor(DexField) removal
335307ms 80ef5bef88b866f9dea82efc73b024ee751b42e2 Remove all uses of definitionFor(DexMember)
337779ms e7186a7da0d3edc84b389169614c60be4e208b14 Remove all uses of definitionFor(DexReference)
267364ms 225ddc66dc42ce0fdef363d17b61c88807b661ed Add CLI tests for various flag additions and fixes.

With the bottom CL being fairly equal in runtime to the original report at version 2.0.99.

Total regression is about ~1.5min on a previously 4.5min build (increase of about 33% in compiletime).

We should introduce a (potentially) hash-map based field collection backing mirroring the backing for methods.

Comments

ze...@google.com <ze...@google.com> #2Jan 11, 2023 04:20PM

Any update on this? This is a major blocker as we cannot run any androidTest under library projects/modules

ap...@google.com <ap...@google.com> #3Jan 13, 2023 12:02PM

Hi there, thank you for your patience.
Could you please attach a sample project that shows this issue? Or please explain where and how the resource is defined and referenced.

ap...@google.com <ap...@google.com> #4Jan 16, 2023 11:14AM

Sample project is linked in #1, along with a repro step. Is anything still missing?

ap...@google.com <ap...@google.com> #5Jan 16, 2023 11:14AM

Ah I missed that, thanks for pointing it out. I'll check it out and keep you updated.

ze...@google.com <ze...@google.com> Jan 18, 2023 08:37AM

Marked as fixed.

Issue 265148324