Need a way to set MotionDurationScale in tests [265177763]

Fixed

Feature Request

Status Update

No update yet.

Description

kl...@google.com

created issue #1

Jan 11, 2023 07:57PM

Compose animations use the CoroutineContext element MotionDurationScale to propagate the system's animation scale (on android, ANIMATOR_DURATION_SCALE).

In production, this value is read from the system by code in WindowRecomposer and added to the coroutine context used for everything in the composition (LaunchedEffect and rememberCoroutineScope). However, in tests, there's no way to explicitly set this value.

Compose UI tests create their own Recomposer that does not read this value from the system, so the coroutine context element is always null.
Moreover, because it's a "secure" setting, it's not possible to set this system setting programmatically on API levels <29.
- On newer APIs we could theoretically use an Instrumentation API to give ourselves permission to set such values.
There's an AnimationDurationScaleRule in internal-testutils-runtime but it only sets the scale used by ValueAnimators, and knows nothing about the system setting or Compose.

Comments

kl...@google.com <kl...@google.com> #2Jan 11, 2023 07:58PM

This happens when there is multiple Text elements in the merged tree and we just take the first one and ignore the rest.

kl...@google.com <kl...@google.com> Jan 12, 2023 12:24AM

Accepted by kl...@google.com.

ap...@google.com <ap...@google.com> #3Jan 12, 2023 12:29AM

I'm working on it this week. Note that the culprit is actually the big substantive patch I landed on Jul 3, http://aosp/1354246

ap...@google.com <ap...@google.com> #4Jan 13, 2023 12:34AM

I started a WIP patch to allow non-unique keys: http://aosp/1375563 . It doesn't fix any bug so far because everything on the semantics client side (accessibility, tests) is just taking the first key/value pair, reproducing the old behavior. Semantics tests pass, next I'll check nothing else is broken and then make it work as expected with duplicate TestTags and Text semantics especially.

ap...@google.com <ap...@google.com> #5Jan 18, 2023 12:46AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1531c13353d4caa1aa6a8f41a58adf67d911531f
Author: Alexandre Elias <aelias@google.com>
Date: Fri Aug 07 20:03:55 2020

Implement per-property merge policy.

This changes the current merging behavior into the default
implementation of an open function called "merge()", and adds different
implementations for the following:
- Text and Label: concatenates strings with comma in between (same as
TalkBack's native merging behavior). This behavior will probably
evolve further in future patches to merge text layout for accessibility.
- TestTag and Hidden: does not merge at all.
- Popup and Dialog: throws an exception.

Note that the latter two behaviors require carefully distinguishing
between collapsing and merging so that, for example, collapsed TestTags
are not dropped as well.

Also switch ListItem to have mergeAllDescendants (should've had that
before anyway), which has more multiple-Text stress tests than
Button/Toggleable. As an example of how TalkBack behaves with a two-line
ListItem, see

https://screenshot.googleplex.com/06KZaX6VfsG

Fixes: 161979921
Test: depthFirstLabelConcat, clickableTest_clickOnChildText
Relnote: "Added mergePolicy lambda to SemanticsPropertyKey. This can be
used to define a custom policy for mergeAllDescendants semantics
merging. The default policy is to use the parent value if already
present, otherwise the child value."

Change-Id: Iaf6c4cc327017ee492f4d8334c8df5167d33df58

M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/compose/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsConfiguration.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsWrapper.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ClickableTest.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ButtonDemo.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/TabTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/ListItem.kt

https://android-review.googlesource.com/1394332

pr...@google.com <pr...@google.com> #6Jan 25, 2023 09:35PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.4.0-alpha05
androidx.compose.ui:ui:1.4.0-alpha05
androidx.compose.ui:ui-test-junit4:1.4.0-alpha05

ap...@google.com <ap...@google.com> #7Feb 27, 2024 08:24PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5bf84ff70c4952f1d516e846ddf6c21af21bebe2
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Feb 27 18:24:03 2024

Move custom effectContext tests to their own files

Moves the tests from ComposeUiTestTest to their own files in the right
modules. ComposeUiTestTest is merely a smoke test and shouldn't bear
more weight than that. The tests are moved to CustomEffectContextTest
and friends, split over android/desktop and ui-test/ui-test-junit4.

Fix: 327217847
Bug: 265177763
Test: no new tests, just moved things around
Change-Id: I3b5b1c1c051f15d85ae5a77cbe756d8c18455f75

A compose/ui/ui-test-junit4/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
A compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
M compose/ui/ui-test/src/desktopTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt

https://android-review.googlesource.com/2980235

na...@google.com <na...@google.com> #8Mar 6, 2024 07:49PM