Fixed
Status Update
No update yet.
Comments
kl...@google.com
Might be worth considering
kl...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 4f02a054cdd109bb10537e0705ad09badff7945a
Author: Zach Klippenstein <klippenstein@google.com>
Date: Tue Jan 10 11:25:14 2023
Make Marquee animate even when animations are disabled.
Animations can be disabled in the system a11y settings. However, marquee
is a load-bearing animation that typically occupies a very small space
in the screen, and should animate even when animations are disabled. See
discussion on bug for more information.
Fixes:
Bug:
Test: manually
Test: Not possible to test yet, see
in BasicMarqueeTest.
Relnote: "`Modifier.basicMarquee` now animates even when animations are
disabled in the system settings."
Change-Id: I23389686f06f2bf749a5f0326d0a33e6da23a1ec
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
https://android-review.googlesource.com/2382936
Branch: androidx-main
commit 4f02a054cdd109bb10537e0705ad09badff7945a
Author: Zach Klippenstein <klippenstein@google.com>
Date: Tue Jan 10 11:25:14 2023
Make Marquee animate even when animations are disabled.
Animations can be disabled in the system a11y settings. However, marquee
is a load-bearing animation that typically occupies a very small space
in the screen, and should animate even when animations are disabled. See
discussion on bug for more information.
Fixes:
Bug:
Test: manually
Test: Not possible to test yet, see
in BasicMarqueeTest.
Relnote: "`Modifier.basicMarquee` now animates even when animations are
disabled in the system settings."
Change-Id: I23389686f06f2bf749a5f0326d0a33e6da23a1ec
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e3e0b4cf5854f67c88e14e8e419db22ad5a22c5f
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu Jan 12 15:13:35 2023
Keep the cursor blinking even when the system disables animations.
The cursor blink animation should not be affected by the a11y setting to
disable animations, because without the cursor blinking apps will simply
appear to be frozen. This also matches platform behavior, where the
cursor blinks no matter what.
Bug:
Test: manually
Test: Ignored test skeleton in TextFieldCursorTest – not possible to
write automated tests yet due to
Relnote: "The cursor in text fields will now continue to blink even when
animations are disabled."
Change-Id: I95e700ee40223cbc3970160b5c267a427d614f39
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldCursorTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldCursor.kt
https://android-review.googlesource.com/2386903
Branch: androidx-main
commit e3e0b4cf5854f67c88e14e8e419db22ad5a22c5f
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu Jan 12 15:13:35 2023
Keep the cursor blinking even when the system disables animations.
The cursor blink animation should not be affected by the a11y setting to
disable animations, because without the cursor blinking apps will simply
appear to be frozen. This also matches platform behavior, where the
cursor blinks no matter what.
Bug:
Test: manually
Test: Ignored test skeleton in TextFieldCursorTest – not possible to
write automated tests yet due to
Relnote: "The cursor in text fields will now continue to blink even when
animations are disabled."
Change-Id: I95e700ee40223cbc3970160b5c267a427d614f39
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldCursorTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldCursor.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit fd5938364d07a81899bc1afa6d7477fd53315567
Author: Zach Klippenstein <klippenstein@google.com>
Date: Wed Jan 11 16:00:47 2023
Introduce ability to inject a CoroutineContext into Compose UI tests.
All entry points into the Compose testing APIs – createComposeRule and
friends, and runComposeUiTest, now take an
effectContext: CoroutineContext parameter that will be used as part of
the coroutine context for composition.
Includes tests for this wiring, as well as updates two actual feature
tests that use this mechanism to inject a MotionDurationScale value to
test animation logic.
Fixes:
Test: BasicMarqueeTest
Test: TextFieldCursorTest
Test: androidTest/ComposeUiTestTest
Test: desktopTest/ComposeUiTestTest
Relnote: "Introduced new experimental overloads for the
`runComposeUiTest` function and `create*ComposeRule` functions that
accept `CoroutineContext` parameters. The context will be used for
the test composition and any `LaunchedEffect` and
`rememberCoroutineScope()` calls in the composition."
Change-Id: I10614adabdb137ad44fb51f65403866b5b184ac1
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldCursorTest.kt
M compose/ui/ui-test-junit4/api/public_plus_experimental_current.txt
M compose/ui/ui-test-junit4/build.gradle
M compose/ui/ui-test-junit4/src/androidAndroidTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/ComposeUiTest.android.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/AndroidComposeTestRule.android.kt
M compose/ui/ui-test-junit4/src/commonMain/kotlin/androidx/compose/ui/test/ComposeUiTest.kt
M compose/ui/ui-test-junit4/src/desktopMain/kotlin/androidx/compose/ui/test/ComposeUiTest.desktop.kt
M compose/ui/ui-test-junit4/src/desktopMain/kotlin/androidx/compose/ui/test/junit4/DesktopComposeTestRule.desktop.kt
A compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
M compose/ui/ui-test-junit4/src/jvmMain/kotlin/androidx/compose/ui/test/junit4/ComposeTestRule.jvm.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/MotionDurationScale.kt
https://android-review.googlesource.com/2387897
Branch: androidx-main
commit fd5938364d07a81899bc1afa6d7477fd53315567
Author: Zach Klippenstein <klippenstein@google.com>
Date: Wed Jan 11 16:00:47 2023
Introduce ability to inject a CoroutineContext into Compose UI tests.
All entry points into the Compose testing APIs – createComposeRule and
friends, and runComposeUiTest, now take an
effectContext: CoroutineContext parameter that will be used as part of
the coroutine context for composition.
Includes tests for this wiring, as well as updates two actual feature
tests that use this mechanism to inject a MotionDurationScale value to
test animation logic.
Fixes:
Test: BasicMarqueeTest
Test: TextFieldCursorTest
Test: androidTest/ComposeUiTestTest
Test: desktopTest/ComposeUiTestTest
Relnote: "Introduced new experimental overloads for the
`runComposeUiTest` function and `create*ComposeRule` functions that
accept `CoroutineContext` parameters. The context will be used for
the test composition and any `LaunchedEffect` and
`rememberCoroutineScope()` calls in the composition."
Change-Id: I10614adabdb137ad44fb51f65403866b5b184ac1
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldCursorTest.kt
M compose/ui/ui-test-junit4/api/public_plus_experimental_current.txt
M compose/ui/ui-test-junit4/build.gradle
M compose/ui/ui-test-junit4/src/androidAndroidTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/ComposeUiTest.android.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/AndroidComposeTestRule.android.kt
M compose/ui/ui-test-junit4/src/commonMain/kotlin/androidx/compose/ui/test/ComposeUiTest.kt
M compose/ui/ui-test-junit4/src/desktopMain/kotlin/androidx/compose/ui/test/ComposeUiTest.desktop.kt
M compose/ui/ui-test-junit4/src/desktopMain/kotlin/androidx/compose/ui/test/junit4/DesktopComposeTestRule.desktop.kt
A compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
M compose/ui/ui-test-junit4/src/jvmMain/kotlin/androidx/compose/ui/test/junit4/ComposeTestRule.jvm.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/MotionDurationScale.kt
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.4.0-alpha05androidx.compose.ui:ui:1.4.0-alpha05androidx.compose.ui:ui-test-junit4:1.4.0-alpha05
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 5bf84ff70c4952f1d516e846ddf6c21af21bebe2
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Feb 27 18:24:03 2024
Move custom effectContext tests to their own files
Moves the tests from ComposeUiTestTest to their own files in the right
modules. ComposeUiTestTest is merely a smoke test and shouldn't bear
more weight than that. The tests are moved to CustomEffectContextTest
and friends, split over android/desktop and ui-test/ui-test-junit4.
Fix: 327217847
Bug: 265177763
Test: no new tests, just moved things around
Change-Id: I3b5b1c1c051f15d85ae5a77cbe756d8c18455f75
A compose/ui/ui-test-junit4/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
A compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
M compose/ui/ui-test/src/desktopTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
https://android-review.googlesource.com/2980235
Branch: androidx-main
commit 5bf84ff70c4952f1d516e846ddf6c21af21bebe2
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Feb 27 18:24:03 2024
Move custom effectContext tests to their own files
Moves the tests from ComposeUiTestTest to their own files in the right
modules. ComposeUiTestTest is merely a smoke test and shouldn't bear
more weight than that. The tests are moved to CustomEffectContextTest
and friends, split over android/desktop and ui-test/ui-test-junit4.
Fix: 327217847
Bug: 265177763
Test: no new tests, just moved things around
Change-Id: I3b5b1c1c051f15d85ae5a77cbe756d8c18455f75
A compose/ui/ui-test-junit4/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
A compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
M compose/ui/ui-test/src/desktopTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui-test:1.7.0-alpha04androidx.compose.ui:ui-test-android:1.7.0-alpha04androidx.compose.ui:ui-test-desktop:1.7.0-alpha04androidx.compose.ui:ui-test-junit4:1.7.0-alpha04androidx.compose.ui:ui-test-junit4-android:1.7.0-alpha04androidx.compose.ui:ui-test-junit4-desktop:1.7.0-alpha04
Description
Compose animations use the
CoroutineContextelementMotionDurationScaleto propagate the system's animation scale (on android,ANIMATOR_DURATION_SCALEIn production, this value is read from the system by code in
WindowRecomposerand added to the coroutine context used for everything in the composition (LaunchedEffectandrememberCoroutineScope). However, in tests, there's no way to explicitly set this value.Recomposerthat does not read this value from the system, so the coroutine context element is always null.InstrumentationAPIAnimationDurationScaleRuleininternal-testutils-runtimebut it only sets the scale used byValueAnimators, and knows nothing about the system setting or Compose.