Fixed
Status Update
No update yet.
Comments
kl...@google.com
Putting this into scaffold makes it work. See
kl...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 46eea23c96f45f0ee1e57d8aef2f1375507b0dec
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Apr 11 14:38:58 2023
[M3][ModalBottomSheet] Enable edge to edge functionality for ModalBottomSheet
Bug: 274872542
Bug: 272973615
Bug: 272334475
Bug: 268432129
Bug: 275849044
Bug: 275486106
Bug: 268433162
RelNote: Add window insets parameter to ModalBottomSheet.
RelNote: Scrim for ModalBottomSheet may now be drawn behind status bar with windowInsets set to zero
RelNote: Updated default ModalBottomSheet functionality to stay outside of system bars including navigation
RelNote: Status bar inset handling is provided by drag handle in edge-to-edge mode.
RelNote: BottomSheetDefaults includes window insets for BottomSheetWindow.
Test: Parameterizes existing tests to work with and without edgeToEdge enabled.
Test: Manual EdgeToEdge testing on various devices and android APIs
Change-Id: I312008e48573ebd21326f77216be0bcd0372aa78
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
https://android-review.googlesource.com/2531428
Branch: androidx-main
commit 46eea23c96f45f0ee1e57d8aef2f1375507b0dec
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Apr 11 14:38:58 2023
[M3][ModalBottomSheet] Enable edge to edge functionality for ModalBottomSheet
Bug: 274872542
Bug: 272973615
Bug: 272334475
Bug: 268432129
Bug: 275849044
Bug: 275486106
Bug: 268433162
RelNote: Add window insets parameter to ModalBottomSheet.
RelNote: Scrim for ModalBottomSheet may now be drawn behind status bar with windowInsets set to zero
RelNote: Updated default ModalBottomSheet functionality to stay outside of system bars including navigation
RelNote: Status bar inset handling is provided by drag handle in edge-to-edge mode.
RelNote: BottomSheetDefaults includes window insets for BottomSheetWindow.
Test: Parameterizes existing tests to work with and without edgeToEdge enabled.
Test: Manual EdgeToEdge testing on various devices and android APIs
Change-Id: I312008e48573ebd21326f77216be0bcd0372aa78
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
ap...@google.com
New windows drawn by AbstractComposeView such as popups, dialogs, and ModalBottomSheet do not inherit insets provided when fitSystemWindows=false. The following change once landed provides a windowInsets param which can be set to 0 to provide an edge-to-edge experience, or other windowInsetPaddings.
ap...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.2.0-alpha02androidx.compose.material3:material3-android:1.2.0-alpha02
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.1.1
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 5bf84ff70c4952f1d516e846ddf6c21af21bebe2
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Feb 27 18:24:03 2024
Move custom effectContext tests to their own files
Moves the tests from ComposeUiTestTest to their own files in the right
modules. ComposeUiTestTest is merely a smoke test and shouldn't bear
more weight than that. The tests are moved to CustomEffectContextTest
and friends, split over android/desktop and ui-test/ui-test-junit4.
Fix: 327217847
Bug: 265177763
Test: no new tests, just moved things around
Change-Id: I3b5b1c1c051f15d85ae5a77cbe756d8c18455f75
A compose/ui/ui-test-junit4/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
A compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
M compose/ui/ui-test/src/desktopTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
https://android-review.googlesource.com/2980235
Branch: androidx-main
commit 5bf84ff70c4952f1d516e846ddf6c21af21bebe2
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Feb 27 18:24:03 2024
Move custom effectContext tests to their own files
Moves the tests from ComposeUiTestTest to their own files in the right
modules. ComposeUiTestTest is merely a smoke test and shouldn't bear
more weight than that. The tests are moved to CustomEffectContextTest
and friends, split over android/desktop and ui-test/ui-test-junit4.
Fix: 327217847
Bug: 265177763
Test: no new tests, just moved things around
Change-Id: I3b5b1c1c051f15d85ae5a77cbe756d8c18455f75
A compose/ui/ui-test-junit4/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
A compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
M compose/ui/ui-test/src/desktopTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui-test:1.7.0-alpha04androidx.compose.ui:ui-test-android:1.7.0-alpha04androidx.compose.ui:ui-test-desktop:1.7.0-alpha04androidx.compose.ui:ui-test-junit4:1.7.0-alpha04androidx.compose.ui:ui-test-junit4-android:1.7.0-alpha04androidx.compose.ui:ui-test-junit4-desktop:1.7.0-alpha04
Description
Compose animations use the
CoroutineContextelementMotionDurationScaleto propagate the system's animation scale (on android,ANIMATOR_DURATION_SCALEIn production, this value is read from the system by code in
WindowRecomposerand added to the coroutine context used for everything in the composition (LaunchedEffectandrememberCoroutineScope). However, in tests, there's no way to explicitly set this value.Recomposerthat does not read this value from the system, so the coroutine context element is always null.InstrumentationAPIAnimationDurationScaleRuleininternal-testutils-runtimebut it only sets the scale used byValueAnimators, and knows nothing about the system setting or Compose.