Fixed
Status Update
No update yet.
Comments
kl...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
kl...@google.com
ap...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit fd5938364d07a81899bc1afa6d7477fd53315567
Author: Zach Klippenstein <klippenstein@google.com>
Date: Wed Jan 11 16:00:47 2023
Introduce ability to inject a CoroutineContext into Compose UI tests.
All entry points into the Compose testing APIs – createComposeRule and
friends, and runComposeUiTest, now take an
effectContext: CoroutineContext parameter that will be used as part of
the coroutine context for composition.
Includes tests for this wiring, as well as updates two actual feature
tests that use this mechanism to inject a MotionDurationScale value to
test animation logic.
Fixes:
Test: BasicMarqueeTest
Test: TextFieldCursorTest
Test: androidTest/ComposeUiTestTest
Test: desktopTest/ComposeUiTestTest
Relnote: "Introduced new experimental overloads for the
`runComposeUiTest` function and `create*ComposeRule` functions that
accept `CoroutineContext` parameters. The context will be used for
the test composition and any `LaunchedEffect` and
`rememberCoroutineScope()` calls in the composition."
Change-Id: I10614adabdb137ad44fb51f65403866b5b184ac1
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldCursorTest.kt
M compose/ui/ui-test-junit4/api/public_plus_experimental_current.txt
M compose/ui/ui-test-junit4/build.gradle
M compose/ui/ui-test-junit4/src/androidAndroidTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/ComposeUiTest.android.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/AndroidComposeTestRule.android.kt
M compose/ui/ui-test-junit4/src/commonMain/kotlin/androidx/compose/ui/test/ComposeUiTest.kt
M compose/ui/ui-test-junit4/src/desktopMain/kotlin/androidx/compose/ui/test/ComposeUiTest.desktop.kt
M compose/ui/ui-test-junit4/src/desktopMain/kotlin/androidx/compose/ui/test/junit4/DesktopComposeTestRule.desktop.kt
A compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
M compose/ui/ui-test-junit4/src/jvmMain/kotlin/androidx/compose/ui/test/junit4/ComposeTestRule.jvm.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/MotionDurationScale.kt
https://android-review.googlesource.com/2387897
Branch: androidx-main
commit fd5938364d07a81899bc1afa6d7477fd53315567
Author: Zach Klippenstein <klippenstein@google.com>
Date: Wed Jan 11 16:00:47 2023
Introduce ability to inject a CoroutineContext into Compose UI tests.
All entry points into the Compose testing APIs – createComposeRule and
friends, and runComposeUiTest, now take an
effectContext: CoroutineContext parameter that will be used as part of
the coroutine context for composition.
Includes tests for this wiring, as well as updates two actual feature
tests that use this mechanism to inject a MotionDurationScale value to
test animation logic.
Fixes:
Test: BasicMarqueeTest
Test: TextFieldCursorTest
Test: androidTest/ComposeUiTestTest
Test: desktopTest/ComposeUiTestTest
Relnote: "Introduced new experimental overloads for the
`runComposeUiTest` function and `create*ComposeRule` functions that
accept `CoroutineContext` parameters. The context will be used for
the test composition and any `LaunchedEffect` and
`rememberCoroutineScope()` calls in the composition."
Change-Id: I10614adabdb137ad44fb51f65403866b5b184ac1
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldCursorTest.kt
M compose/ui/ui-test-junit4/api/public_plus_experimental_current.txt
M compose/ui/ui-test-junit4/build.gradle
M compose/ui/ui-test-junit4/src/androidAndroidTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/ComposeUiTest.android.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/AndroidComposeTestRule.android.kt
M compose/ui/ui-test-junit4/src/commonMain/kotlin/androidx/compose/ui/test/ComposeUiTest.kt
M compose/ui/ui-test-junit4/src/desktopMain/kotlin/androidx/compose/ui/test/ComposeUiTest.desktop.kt
M compose/ui/ui-test-junit4/src/desktopMain/kotlin/androidx/compose/ui/test/junit4/DesktopComposeTestRule.desktop.kt
A compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
M compose/ui/ui-test-junit4/src/jvmMain/kotlin/androidx/compose/ui/test/junit4/ComposeTestRule.jvm.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/MotionDurationScale.kt
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.4.0-alpha05androidx.compose.ui:ui:1.4.0-alpha05androidx.compose.ui:ui-test-junit4:1.4.0-alpha05
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 5bf84ff70c4952f1d516e846ddf6c21af21bebe2
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Feb 27 18:24:03 2024
Move custom effectContext tests to their own files
Moves the tests from ComposeUiTestTest to their own files in the right
modules. ComposeUiTestTest is merely a smoke test and shouldn't bear
more weight than that. The tests are moved to CustomEffectContextTest
and friends, split over android/desktop and ui-test/ui-test-junit4.
Fix: 327217847
Bug: 265177763
Test: no new tests, just moved things around
Change-Id: I3b5b1c1c051f15d85ae5a77cbe756d8c18455f75
A compose/ui/ui-test-junit4/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
A compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
M compose/ui/ui-test/src/desktopTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
https://android-review.googlesource.com/2980235
Branch: androidx-main
commit 5bf84ff70c4952f1d516e846ddf6c21af21bebe2
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Feb 27 18:24:03 2024
Move custom effectContext tests to their own files
Moves the tests from ComposeUiTestTest to their own files in the right
modules. ComposeUiTestTest is merely a smoke test and shouldn't bear
more weight than that. The tests are moved to CustomEffectContextTest
and friends, split over android/desktop and ui-test/ui-test-junit4.
Fix: 327217847
Bug: 265177763
Test: no new tests, just moved things around
Change-Id: I3b5b1c1c051f15d85ae5a77cbe756d8c18455f75
A compose/ui/ui-test-junit4/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/ComposeUiTestTest.kt
A compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
M compose/ui/ui-test/src/desktopTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui-test:1.7.0-alpha04androidx.compose.ui:ui-test-android:1.7.0-alpha04androidx.compose.ui:ui-test-desktop:1.7.0-alpha04androidx.compose.ui:ui-test-junit4:1.7.0-alpha04androidx.compose.ui:ui-test-junit4-android:1.7.0-alpha04androidx.compose.ui:ui-test-junit4-desktop:1.7.0-alpha04
Description
Compose animations use the
CoroutineContextelementMotionDurationScaleto propagate the system's animation scale (on android,ANIMATOR_DURATION_SCALEIn production, this value is read from the system by code in
WindowRecomposerand added to the coroutine context used for everything in the composition (LaunchedEffectandrememberCoroutineScope). However, in tests, there's no way to explicitly set this value.Recomposerthat does not read this value from the system, so the coroutine context element is always null.InstrumentationAPIAnimationDurationScaleRuleininternal-testutils-runtimebut it only sets the scale used byValueAnimators, and knows nothing about the system setting or Compose.