Need a way to set MotionDurationScale in tests [265177763]

Fixed

Feature Request

Status Update

No update yet.

Description

kl...@google.com

created issue #1

Jan 11, 2023 07:57PM

Compose animations use the CoroutineContext element MotionDurationScale to propagate the system's animation scale (on android, ANIMATOR_DURATION_SCALE).

In production, this value is read from the system by code in WindowRecomposer and added to the coroutine context used for everything in the composition (LaunchedEffect and rememberCoroutineScope). However, in tests, there's no way to explicitly set this value.

Compose UI tests create their own Recomposer that does not read this value from the system, so the coroutine context element is always null.
Moreover, because it's a "secure" setting, it's not possible to set this system setting programmatically on API levels <29.
- On newer APIs we could theoretically use an Instrumentation API to give ourselves permission to set such values.
There's an AnimationDurationScaleRule in internal-testutils-runtime but it only sets the scale used by ValueAnimators, and knows nothing about the system setting or Compose.

Comments

kl...@google.com <kl...@google.com> #2Jan 11, 2023 07:58PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

kl...@google.com <kl...@google.com> Jan 12, 2023 12:24AM

Accepted by kl...@google.com.

ap...@google.com <ap...@google.com> #3Jan 12, 2023 12:29AM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

ap...@google.com <ap...@google.com> #4Jan 13, 2023 12:34AM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ap...@google.com <ap...@google.com> #5Jan 18, 2023 12:46AM

Marked as fixed.

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

pr...@google.com <pr...@google.com> #6Jan 25, 2023 09:35PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

ap...@google.com <ap...@google.com> #7Feb 27, 2024 08:24PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

na...@google.com <na...@google.com> #8Mar 6, 2024 07:49PM

Thank you, I'll try it and check.