IssueTracker

Steps to reproduce

1. Open the attached project (AGP 8.0.0-alpha11), run ./gradlew help, it will fail with:

Minimum supported Gradle version is 7.5. Current version is 7.2.

2. Run ./gradlew help again without updating Gradle, it will fail with:

A problem occurred configuring project ':app'.
> Failed to notify project evaluation listener.
   > ARTIFACT_TYPE_ATTRIBUTE

Root cause

At this change https://android.googlesource.com/platform/tools/base/+/27e840abc64595652fd05ac564660b983ef8a478 (merged Jun 7, 2022), we use a static variable to record whether the Gradle version check has been performed. This is to avoid running the check multiple times, once for each subproject.

However, a static variable is not suited for this use case for 2 reasons:

• Scope: A static variable is specific per classloader. Therefore, the check can still run multiple times if each subproject is loaded by a different classloader.
• Lifetime: A static variable persists across builds. That means we will perform the check on the first build only. If the user doesn't update Gradle after the first build / sync, they will likely run into some weird errors in the next builds (and don't know what to do with it!)

Potential fix

We can replace the static variable with a property in a cross-classloader BuildService. This will fix both the scope and lifetime issues above (the scope will be JVM-scoped, cross-classloader, and the lifetime will be per build).

We've been talking about this cross-classloader BuildService for a while, maybe this is a good opportunity to implement it.