Upgrading to AGP 7.4 results in a StackOverflowError [265385297]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jan 13, 2023 05:04PM

DESCRIBE THE ISSUE IN DETAIL:

This project has a Gradle module who's main responsibility is packaging non-trivial library code such that it is consumable by the app's build. This is the only place in our project where source sets are customized. Commenting out this code results in a working build, but the app fails at runtime due to the missing library code. This code worked in AGP 7.3.1 and earlier.

android {
    sourceSets {
        val excludes = listOf("**/R.java")

        named("debug") {
            java.srcDirs(objPath.resolve("Debug/android/src"))
            resources.srcDirs(objPath.resolve("Debug/android/bin/unpacked"))
            jniLibs.srcDirs(objPath.resolve("Debug/android/bin/unpacked/lib"))
        }

        named("release") {
            java.srcDirs(objPath.resolve("Release/android/src"))
            resources.srcDirs(objPath.resolve("Release/android/bin/unpacked"))
            jniLibs.srcDirs(objPath.resolve("Release/android/bin/unpacked/lib"))
        }
    }

Cause: java.lang.StackOverflowError
	at com.android.build.gradle.internal.api.DefaultAndroidSourceDirectorySet.srcDir(DefaultAndroidSourceDirectorySet.kt:232)
	at com.android.build.gradle.internal.api.DefaultAndroidSourceDirectorySet.srcDir(DefaultAndroidSourceDirectorySet.kt:70)
	at com.android.build.gradle.internal.api.DefaultAndroidSourceDirectorySet.srcDir(DefaultAndroidSourceDirectorySet.kt:70)
	at com.android.build.gradle.internal.api.DefaultAndroidSourceDirectorySet.srcDir(DefaultAndroidSourceDirectorySet.kt:70)

STEPS TO REPRODUCE:

Update AGP 7.3.1 -> 7.4
Build

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: Electric Eel Version of Gradle Plugin: 7.4.0 Version of Gradle: 7.5, 7.5.1, 7.6 Version of Java: 11, 17 OS: macOS 12

Comments

ac...@google.com <ac...@google.com> Jan 13, 2023 11:17PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Jan 18, 2023 04:44PM

Reassigned to cm...@google.com.

cm...@google.com <cm...@google.com> Jan 20, 2023 03:31PM

Reassigned to am...@google.com.

cm...@google.com <cm...@google.com> #2Jan 20, 2023 05:18PM

Will be this fix also part of 4.2 please?

[Deleted User] <[Deleted User]> #3Jan 20, 2023 11:13PM

for the "out" bundle issue, this seems indeed an issue. for the second one reported adding "debugUpdateAPKArtifact" to the path, this WAI as there can more more than one transformer and we need to automatically separate them so they do not use the same output folder. for #3, I will look at it but it might be difficult to change it at this time.

am...@google.com <am...@google.com> #4Jan 26, 2023 02:09PM

Marked as fixed.

I understand that if there is more transformer is necessary to make every folder different, but there is the main problem, that the final one (last transform) is inside of the intermediate folder. The last transformation should end in the standard location, right? Maybe also with the default name not?

Issue 265385297