ModalBottomSheetLayout crashes with NoSuchElementException: Key HalfExpanded is missing in the map. [265444789]

Fixed

Bug

Status Update

No update yet.

Description

ha...@gmail.com

created issue #1

Jan 14, 2023 02:17PM

Jetpack Compose version: 1.4.0-alpha04

Jetpack Compose component used: ModalBottomSheetLayout

Android Studio Build: Electric Eel 2022.1.1 #AI-221.6008.13.2211.9477386

Kotlin version: 1.7.21

Repo: https://github.com/hakonschia/bottomsheetcrash

The updated ModalBottomSheetLayout in 1.4.0-alpha04 seems to have some issues. I have observed two cases where it crashes with Key HalfExpanded is missing in the map. The linked repo contains both scenarios.

First scenario:

Open app on Pixel 2 emulator. I think the crash depends on the size of the bottom sheet and the size of the phone. A bottom sheet with height 250dp on this emulator crashes, but for example a height of 500dp does not.
Make sure scenario1 is toggled
Rotate phone to landscape
Open bottom sheet
Rotate phone to portrait

I'll add that the bottom sheet "floats" above the bottom of the screen, which seems like a new bug introduced in alpha04. In the example repo this only happens when the sheet is opened in landscape. If I open it in portrait and then rotate, it doesn't happen. It also doesn't crash in this case, so it seems this might be related. This is visible in the video attached.

Second scenario:

The updated ModalBottomSheetLayout is supposed to support empty sheet content, but when going from empty content to some content it crashes.

Steps to reproduce:

Make sure scenario2 is toggled in the example
Just open the bottom sheet

I'll add here that I have had to do this hack with empty content to avoid the bottom sheet sometimes being visible when it shouldn't, for example when resizing the window in Picture-in-Picture mode (which might be related to https://issuetracker.google.com/issues/260517771). I've added a button to enter PiP where this issue can be seen by removing the logic to not render the content when not visible.

Adding Spacer(Modifier.height(1.dp)) fixes this crash, which is what I had to do previously anyways since empty content wasn't supported, but I'd like to remove this hack.

Stack trace (if applicable):

java.util.NoSuchElementException: Key HalfExpanded is missing in the map.
    at kotlin.collections.MapsKt__MapWithDefaultKt.getOrImplicitDefaultNullable(MapWithDefault.kt:24)
    at kotlin.collections.MapsKt__MapsKt.getValue(Maps.kt:348)
    at androidx.compose.material.ModalBottomSheetKt$ModalBottomSheetAnchorChangeHandler$1.onAnchorsChanged(ModalBottomSheet.kt:671)
    at androidx.compose.material.ModalBottomSheetKt$ModalBottomSheetAnchorChangeHandler$1.onAnchorsChanged(ModalBottomSheet.kt:670)
    at androidx.compose.material.SwipeableV2Kt$swipeAnchors$2.invoke-ozmzZPI(SwipeableV2.kt:123)
    at androidx.compose.material.SwipeableV2Kt$swipeAnchors$2.invoke(SwipeableV2.kt:108)
    at androidx.compose.material.SwipeAnchorsModifier.onRemeasured-ozmzZPI(SwipeableV2.kt:632)
    at androidx.compose.ui.node.BackwardsCompatNode.onRemeasured-ozmzZPI(BackwardsCompatNode.kt:414)
    at androidx.compose.ui.node.NodeCoordinator.onMeasured(NodeCoordinator.kt:311)
    at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:159)
    at androidx.compose.foundation.layout.OffsetPxModifier.measure-3p2s80s(Offset.kt:200)
    at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:319)
    at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
    at androidx.compose.foundation.layout.FillModifier.measure-3p2s80s(Size.kt:658)
    at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:319)
    at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
    at androidx.compose.foundation.layout.SizeModifier.measure-3p2s80s(Size.kt:781)
    at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:319)
    at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
    at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1090)
    at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1086)
    at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2139)
    at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:234)
    at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:230)
    at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
    at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
    at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
    at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
    at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:107)
    at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1086)
    at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:36)
    at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:342)
    at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:321)
    at androidx.compose.foundation.layout.BoxKt$boxMeasurePolicy$1.measure-3p2s80s(Box.kt:137)
    at androidx.compose.foundation.layout.BoxWithConstraintsKt$BoxWithConstraints$1$1.invoke-0kLqBqw(BoxWithConstraints.kt:70)
    at androidx.compose.foundation.layout.BoxWithConstraintsKt$BoxWithConstraints$1$1.invoke(BoxWithConstraints.kt:67)
    at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1.measure-3p2s80s(SubcomposeLayout.kt:591)

device-2023-01-14-145707.webm

17 MB

Download

Comments

ha...@gmail.com <ha...@gmail.com> #2Jan 16, 2023 07:39AM

test

jo...@google.com <jo...@google.com> #3Jan 16, 2023 10:17AM

bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.

see

b/123001228#comment6

jo...@google.com <jo...@google.com> #4Jan 16, 2023 10:21AM

Reassigned to jo...@google.com.

(bulk comment) Hi,

Can you please check if this task can be finished before June, and if not remove `Jetpack Compose Major Release (May 2020)` hotlist?

(apologies if this is a double comment)

Thank you

jo...@google.com <jo...@google.com> #5Jan 16, 2023 11:20AM

(bulk comment)
Please ignore last comment related to the June release. It was caused by a mistake in the query I used. Thank you.

jo...@google.com <jo...@google.com> #6Jan 16, 2023 12:14PM

further postponing to category 3, since it doesn't look like we can accomplish this one. If time allows one of us will pick it up during category 2.

Message last modified on Jan 16, 2023 12:14PM

ha...@gmail.com <ha...@gmail.com> #7Jan 16, 2023 12:27PM

out of curiousity… if this isnt immediately planned, have you considered changing he default colors at all? a couple things i noticed:

(1) i could see the choice of purple + blue clashing with a number of existing apps, and maybe there are some better defaults that could be used to at least make the colors stand out less.

(2) the defaults don’t support dark mode very well. in our app, the dark purple handles on top of a primary dark mode background has only a 2.14:1 color contrast ratio (whereas in light mode the contrast is 8.98:1)

jo...@google.com <jo...@google.com> #8Jan 16, 2023 12:28PM

I agree with Comment #7, I think this is an important issue we should resolve (P2 at least).

Siyamed, if you / your team does not have time to look at this, feel free to assign to me - happy to take this over. As well as allowing changing the color, MaterialTheme should also be configured to set a color from the theme by default so that it is correct out of the box for typicaly use cases.

ha...@gmail.com <ha...@gmail.com> #9Jan 16, 2023 12:44PM

related: b/139320372

ap...@google.com <ap...@google.com> #10Jan 16, 2023 01:47PM

Thanks Louis.

Please keep in mind there are two main entry points: Text selection and TextField selection. as a note: In TextField it is possible that existing cursorColor defines those colors (or one of them)

jo...@google.com <jo...@google.com> Jan 16, 2023 02:29PM

Marked as fixed.

ha...@gmail.com <ha...@gmail.com> #11Jan 16, 2023 05:21PM

it would be best to control selection as a whole for both of them I believe, but let's discuss it. Looks like material.TextField uses errorColor and activeColor as the cursor color. let's make sure we take that into account while designing the theming (they seem to be related)

jo...@google.com <jo...@google.com> #12Jan 17, 2023 09:33AM

open questions, assumptions that need verification:

is cursorColor and selection color the same
cursorColor is errorColor and activeColor in material.TextField, is there any relation
Text and TextField should use a single selection color for consistency
selection color is always the same for selection handle and selection background
cursor color determines insertion (cursor) handle color as well (we do not have cursor handle yet)
what the default color should be for light and dark mode
shape of the cursor handle is not urgent, and possibly something we specifically don't want customization for the phone end user experience (similar to cursor animation)
can there be a default color in foundation? choosing the text color, bg color etc too tricky. Using the exact text color wouldn't work since it would make text invisible.

ha...@gmail.com <ha...@gmail.com> #13Jan 17, 2023 09:56AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 93195d42d1f079136053e33ccec6e7d5ac839dfe
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Tue Nov 17 15:20:25 2020

Adds AmbientTextSelectionColors to allow customizing the colors used for text selection

Also sets the correct Material defaults in MaterialTheme

Bug:

b/139320372

Bug:

b/139320907

Test: MaterialTextSelectionColorsScreenshotTest
Test: TextSelectionColorsScreenshotTest
Test: TextSelectionBackgroundColorTest
Relnote: "MaterialTheme now sets the correct colors for selection handles and selection background. Non-Material apps can manually use AmbientTextSelectionColors to customize the colors used for selection."
Change-Id: I1e6f4b495bdc713e162759a08ecf0a7311b26e33

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/TextFieldDelegateIntegrationTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.kt
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MaterialTextSelectionColorsScreenshotTest.kt
A compose/material/material/src/commonMain/kotlin/androidx/compose/material/MaterialTextSelectionColors.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/MaterialTheme.kt
A compose/material/material/src/test/kotlin/androidx/compose/material/TextSelectionBackgroundColorTest.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/selection/SelectionHandlesTest.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/selection/TextSelectionColorsScreenshotTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionHandles.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/TextSelectionColors.kt

https://android-review.googlesource.com/1502030

pr...@google.com <pr...@google.com> #14Jan 25, 2023 09:36PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.4.0-alpha05

pa...@gmail.com <pa...@gmail.com> #15Jan 31, 2023 07:43AM

i have similar issue but with "Expanded" (androidx.compose:compose-bom:2023.01.00 ) Can somebody tell me if this is the same issue ?

https://issuetracker.google.com/issues/267227888

Message last modified on Jan 31, 2023 07:43AM