IssueTracker

Jetpack Compose version: 1.4.0-alpha04

Jetpack Compose component used: ModalBottomSheetLayout

Android Studio Build: Electric Eel 2022.1.1 #AI-221.6008.13.2211.9477386

Kotlin version: 1.7.21

Repo: https://github.com/hakonschia/bottomsheetcrash

The updated ModalBottomSheetLayout in 1.4.0-alpha04 seems to have some issues. I have observed two cases where it crashes with Key HalfExpanded is missing in the map. The linked repo contains both scenarios.

First scenario:

1. Open app on Pixel 2 emulator. I think the crash depends on the size of the bottom sheet and the size of the phone. A bottom sheet with height 250dp on this emulator crashes, but for example a height of 500dp does not.
2. Make sure scenario1 is toggled
3. Rotate phone to landscape
4. Open bottom sheet
5. Rotate phone to portrait

I'll add that the bottom sheet "floats" above the bottom of the screen, which seems like a new bug introduced in alpha04. In the example repo this only happens when the sheet is opened in landscape. If I open it in portrait and then rotate, it doesn't happen. It also doesn't crash in this case, so it seems this might be related. This is visible in the video attached.

Second scenario:

The updated ModalBottomSheetLayout is supposed to support empty sheet content, but when going from empty content to some content it crashes.

Steps to reproduce:

1. Make sure scenario2 is toggled in the example
2. Just open the bottom sheet

I'll add here that I have had to do this hack with empty content to avoid the bottom sheet sometimes being visible when it shouldn't, for example when resizing the window in Picture-in-Picture mode (which might be related to https://issuetracker.google.com/issues/260517771). I've added a button to enter PiP where this issue can be seen by removing the logic to not render the content when not visible.

Adding Spacer(Modifier.height(1.dp)) fixes this crash, which is what I had to do previously anyways since empty content wasn't supported, but I'd like to remove this hack.

Stack trace (if applicable):

java.util.NoSuchElementException: Key HalfExpanded is missing in the map.
    at kotlin.collections.MapsKt__MapWithDefaultKt.getOrImplicitDefaultNullable(MapWithDefault.kt:24)
    at kotlin.collections.MapsKt__MapsKt.getValue(Maps.kt:348)
    at androidx.compose.material.ModalBottomSheetKt$ModalBottomSheetAnchorChangeHandler$1.onAnchorsChanged(ModalBottomSheet.kt:671)
    at androidx.compose.material.ModalBottomSheetKt$ModalBottomSheetAnchorChangeHandler$1.onAnchorsChanged(ModalBottomSheet.kt:670)
    at androidx.compose.material.SwipeableV2Kt$swipeAnchors$2.invoke-ozmzZPI(SwipeableV2.kt:123)
    at androidx.compose.material.SwipeableV2Kt$swipeAnchors$2.invoke(SwipeableV2.kt:108)
    at androidx.compose.material.SwipeAnchorsModifier.onRemeasured-ozmzZPI(SwipeableV2.kt:632)
    at androidx.compose.ui.node.BackwardsCompatNode.onRemeasured-ozmzZPI(BackwardsCompatNode.kt:414)
    at androidx.compose.ui.node.NodeCoordinator.onMeasured(NodeCoordinator.kt:311)
    at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:159)
    at androidx.compose.foundation.layout.OffsetPxModifier.measure-3p2s80s(Offset.kt:200)
    at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:319)
    at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
    at androidx.compose.foundation.layout.FillModifier.measure-3p2s80s(Size.kt:658)
    at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:319)
    at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
    at androidx.compose.foundation.layout.SizeModifier.measure-3p2s80s(Size.kt:781)
    at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:319)
    at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)
    at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1090)
    at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1086)
    at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2139)
    at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:234)
    at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:230)
    at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
    at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
    at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
    at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
    at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:107)
    at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1086)
    at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:36)
    at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:342)
    at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:321)
    at androidx.compose.foundation.layout.BoxKt$boxMeasurePolicy$1.measure-3p2s80s(Box.kt:137)
    at androidx.compose.foundation.layout.BoxWithConstraintsKt$BoxWithConstraints$1$1.invoke-0kLqBqw(BoxWithConstraints.kt:70)
    at androidx.compose.foundation.layout.BoxWithConstraintsKt$BoxWithConstraints$1$1.invoke(BoxWithConstraints.kt:67)
    at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1.measure-3p2s80s(SubcomposeLayout.kt:591)