Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e79512b5236c400c120fb03dea602fab9abfcb61
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon Jan 16 12:37:38 2023
Fix ModalBottomSheetLayout's HalfExpanded anchor offset
We used the `sheetSize` to calculate the HalfExpanded offset instead of `fullHeight`. The test passed because the sheet content filled the whole container, resulting in `sheetSize == fullHeight` and thus `sheetSize / 2 == fullHeight / 2`.
Test: Updated modalBottomSheet_testOffset_tallBottomSheet_whenHalfExpanded to not fill the whole container. Verified failing before fix, passing after.
Relnote: Fixed an issue where ModalBottomSheetLayout's HalfExpanded state was calculated incorrectly and the sheet would appear to be floating.
Bug: 265610459
Change-Id: I8c6155884780f8480fe714ee886d17e28bd21427
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
https://android-review.googlesource.com/2388068
Branch: androidx-main
commit e79512b5236c400c120fb03dea602fab9abfcb61
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon Jan 16 12:37:38 2023
Fix ModalBottomSheetLayout's HalfExpanded anchor offset
We used the `sheetSize` to calculate the HalfExpanded offset instead of `fullHeight`. The test passed because the sheet content filled the whole container, resulting in `sheetSize == fullHeight` and thus `sheetSize / 2 == fullHeight / 2`.
Test: Updated modalBottomSheet_testOffset_tallBottomSheet_whenHalfExpanded to not fill the whole container. Verified failing before fix, passing after.
Relnote: Fixed an issue where ModalBottomSheetLayout's HalfExpanded state was calculated incorrectly and the sheet would appear to be floating.
Bug: 265610459
Change-Id: I8c6155884780f8480fe714ee886d17e28bd21427
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
jo...@google.com
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.4.0-alpha05
Description
Jetpack Compose version: 1.4.0-alpha04
Jetpack Compose component used: ModalBottomSheetLayout
Android Studio Build: Electric Eel 2022.1.1 #AI-221.6008.13.2211.9477386
Kotlin version: 1.7.21
See attached video.
Repo:https://github.com/hakonschia/bottomsheetcrash
Steps: