Macrobenchmark shader cache clearing crashes if no shaders generated [266001599]

Duplicate

of 274314544

Bug

Status Update

No update yet.

Description

cc...@google.com

created issue #1

Jan 18, 2023 11:18PM

AppWidgetUpdateBenchmark crashing consistently, due to the following error:

java.lang.IllegalStateException: Expected no stdout/stderr from find /data/user_de/0/androidx.glance.appwidget.macrobenchmark.target/code_cache -type f | xargs rm, saw Output(stdout=, stderr=rm: Needs 1 argument (see "rm --help")
)
	at androidx.benchmark.Shell.executeScriptSilent(Shell.kt:232)
	at androidx.benchmark.Shell.executeScriptSilent$default(Shell.kt:230)
	at androidx.benchmark.macro.MacrobenchmarkScope.dropShaderCache(MacrobenchmarkScope.kt:249)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmarkWithStartupMode$1.invoke(Macrobenchmark.kt:385)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmarkWithStartupMode$1.invoke(Macrobenchmark.kt:367)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:210)
	at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:201)
	at androidx.benchmark.macro.perfetto.PerfettoTraceProcessor$Companion.runServer(PerfettoTraceProcessor.kt:70)
	at androidx.benchmark.macro.perfetto.PerfettoTraceProcessor$Companion.runServer$default(PerfettoTraceProcessor.kt:53)
	at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmark(Macrobenchmark.kt:201)
	at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmarkWithStartupMode(Macrobenchmark.kt:367)
	at androidx.benchmark.macro.junit4.MacrobenchmarkRule.measureRepeated(MacrobenchmarkRule.kt:107)
	at androidx.glance.appwidget.macrobenchmark.AppWidgetUpdateBenchmark.appWidgetUpdate(AppWidgetUpdateBenchmark.kt:64)

Comments

wv...@google.com <wv...@google.com> #2Jan 19, 2023 01:55AM

I was seeing this error locally as well. I'm not exactly sure what fixed it, but after aosp/2359702 it should stop failing.

ys...@google.com <ys...@google.com> #3Jan 31, 2023 05:08PM

I'm hitting this also on a wear app. Is there a macrobenchmark fix for it? ~~Or is it just changing to CompilationMode.DEFAULT?~~ Or changing to StartupMode.WARM?

Message last modified on Jan 31, 2023 05:19PM

ys...@google.com <ys...@google.com> #4Jan 31, 2023 05:15PM

~~Probably https://cs.android.com/androidx/platform/frameworks/support/+/4f3a2edf189583e6c932165cc6bee92c0395c1de~~

Message last modified on Jan 31, 2023 05:16PM

cc...@google.com <cc...@google.com> #5May 1, 2023 10:55PM

Status: Duplicate of

274314544

The fix for the other bug should fix this as well.

Issue 266001599

Description

Issue summary

Comments

wv...@google.com <wv...@google.com> #2Jan 19, 2023 01:55AM

ys...@google.com <ys...@google.com> #3Jan 31, 2023 05:08PM

ys...@google.com <ys...@google.com> #4Jan 31, 2023 05:15PM

cc...@google.com <cc...@google.com> #5May 1, 2023 10:55PM

Add comment

Issue metadata