namespace property probably belongs to HasAndroidResources [266135619]

Fixed

Feature Request

Status Update

No update yet.

Description

xa...@google.com

created issue #1

Jan 19, 2023 11:20PM

namespace is current defined by Variant and AndroidTest. The main reason it's not in component is because of UnitTest.

Both Variant and AndroidTest also implement HasAndroidResources, and namespace is actually used to generate the R class which is due to the presence of resources.

Based on this, it would make sense to move namespace into HasAndroidResources.

This would help plugins who need to handle this not have to handle both Variant and AndroidTest objects.

Comments

je...@google.com <je...@google.com> Jan 20, 2023 10:00PM

Reassigned to je...@google.com.

cm...@google.com <cm...@google.com> #2Jan 23, 2023 02:19PM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

xa...@google.com <xa...@google.com> #3Jan 23, 2023 05:47PM

Almost 2 months later and this is still broken

je...@google.com <je...@google.com> #4Jan 25, 2023 04:58AM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

je...@google.com <je...@google.com> Mar 2, 2023 12:13AM

Marked as fixed.

Issue 266135619