AndroidLintAnalysisTask (<project>:lintAnalyzeExternalRelease) has a cache miss because `proguard.txt` has changed [266403349]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Jan 23, 2023 08:56PM

DESCRIBE THE ISSUE IN DETAIL:

It appears that the MergeFilesTask has non-deterministic outputs, as it does not sort the files before merging their contents. This affects proguard file merging and baseline profile merging.

STEPS TO REPRODUCE:

I noticed this while investigating some remote build cache fidelity issues. I see lint analysis tasks on consecutive builds across different machines result in cache misses despite being identical, and build scan comparisons reveal it's because library merged proguard rule contents are the same. I'm trying to confirm that this is due to inconsistent file ordering when merging via monkeypatch in our internal plugin.

Studio Build: N/A
Version of Gradle Plugin: 7.4.0
Version of Gradle: 7.6
Version of Java: 19
OS: macOS Ventura 13.1

image (3).png

197 KB

View

Download

image (4).png

162 KB

View

Download

Comments

cm...@google.com <cm...@google.com> Jan 24, 2023 03:44PM

Assigned to an...@google.com.

ga...@google.com <ga...@google.com> Jan 24, 2023 04:12PM

Reassigned to hu...@google.com.

hu...@google.com <hu...@google.com> #2Jan 24, 2023 05:23PM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

zs...@salesforce.com <zs...@salesforce.com> #3Feb 16, 2023 03:38AM

Almost 2 months later and this is still broken

hu...@google.com <hu...@google.com> #4Feb 16, 2023 11:00AM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

ga...@google.com <ga...@google.com> #5Feb 16, 2023 11:14AM

jb...@google.com What is the update on this?

hu...@google.com <hu...@google.com> #6Feb 16, 2023 11:27AM

What is the status of this item?

za...@gmail.com <za...@gmail.com> #7Feb 16, 2023 03:34PM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

hu...@google.com <hu...@google.com> #8Mar 1, 2023 09:13PM

Any ETA on next release?

hu...@google.com <hu...@google.com> #9Mar 2, 2023 03:20PM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

hu...@google.com <hu...@google.com> #10Mar 27, 2023 01:16PM

Marked as fixed.

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```