IssueTracker

Artifact used (androidx.fragment:fragment-ktx:1.5.5):

Devices/Android versions reproduced on: Pixel 7 Pro / Android 13

After updating our fragment-ktx dependency we noticed that onCreateOptionsMenu is getting called again when we dismiss a DialogFragment as MenuHostHelper.removeMenuProvider is invalidating the menu.

Is this an intended behavior change?

In the example below the log onCreateOptionsMenu Called will be shown again once dismissing the dialog.

compileSdk 33
targetSdk 33

class MainActivity : AppCompatActivity() {

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_main)
        findViewById<MaterialButton>(R.id.open_dialog).setOnClickListener {
            TestDialogFragment().show(supportFragmentManager, "TestDialogFragment")
        }
    }
    
    override fun onCreateOptionsMenu(menu: Menu?): Boolean {
        menuInflater.inflate(R.menu.test, menu)
        Log.d("TestApp", "onCreateOptionsMenu Called")
        return super.onCreateOptionsMenu(menu)
    }
        
    class TestDialogFragment : DialogFragment() {
        override fun onCreateDialog(savedInstanceState: Bundle?): Dialog =
            AlertDialog.Builder(requireContext())
                .setMessage("Test")
                .setPositiveButton("OK") { _,_ -> }
                .create()
    }
}