Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 46de642c383f8d6037c12ac475a1aa254038078e
Author: Sergio Sancho <ssancho@google.com>
Date: Mon Jan 23 13:38:17 2023
Remove unnecesary check
Remove check from custom modifier used in ScalingLazyColumn that
prevented it from being used inside a horizontal scrolling container.
RelNote: "Allow ScalingLazyColumn to be nested within a horizontally scrolling page"
Test: ./gradlew :wear:compose:compose-foundation:connectedCheck --info --daemon
Bug: 266555016
Change-Id: Iec3f8cd60ec3af87abdb81d12ade6e0b6b005aca
M wear/compose/compose-foundation/src/androidAndroidTest/kotlin/androidx/wear/compose/foundation/lazy/ScalingLazyColumnTest.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/lazy/ScalingLazyColumn.kt
https://android-review.googlesource.com/2399277
Branch: androidx-main
commit 46de642c383f8d6037c12ac475a1aa254038078e
Author: Sergio Sancho <ssancho@google.com>
Date: Mon Jan 23 13:38:17 2023
Remove unnecesary check
Remove check from custom modifier used in ScalingLazyColumn that
prevented it from being used inside a horizontal scrolling container.
RelNote: "Allow ScalingLazyColumn to be nested within a horizontally scrolling page"
Test: ./gradlew :wear:compose:compose-foundation:connectedCheck --info --daemon
Bug: 266555016
Change-Id: Iec3f8cd60ec3af87abdb81d12ade6e0b6b005aca
M wear/compose/compose-foundation/src/androidAndroidTest/kotlin/androidx/wear/compose/foundation/lazy/ScalingLazyColumnTest.kt
M wear/compose/compose-foundation/src/commonMain/kotlin/androidx/wear/compose/foundation/lazy/ScalingLazyColumn.kt
st...@google.com <st...@google.com>
pr...@google.com <pr...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.compose:compose-foundation:1.2.0-alpha04
Description
Fix IllegalArgumentException when adding Modifier.horizontalScroll on the parent of a ScalingLazyColumn.
Code sample:https://github.com/yingding/hScrollSLC
Corresponding thread in Slack:https://kotlinlang.slack.com/archives/C02GBABJUAF/p1672841280732539
Compose for Wear OS version: 1.1.0 Compose version: 1.3.2 Devices/Android versions reproduced on: any
Note: nesting ScalingLazyColumn in the horizontally scrolling page is not a recommended UX pattern.