IssueTracker

Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.

We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

Building with minSDK 24 still broken.

Actually, it's a new problem: java.lang.NoClassDefFoundError: Failed resolution of: Lj$/util/DesugarTimeZone;

I didn't check the minSDK 23 error, but I guess it's the same error above (with Map), but this time it's DesugarTimeZone.

This is getting confusing 😅️

Ok thanks for your investigation.

From the dump I get an assertion failure on:

Unexpected open interface java.lang.Iterable (assignment: @Nullable java.lang.Object {})

This looks like an issue in the CfOpenClosedInterfacesAnalysisHelper. This is in Giraffe so recent commits.

@christofferqa do you have any clue? It seems the bug reproduces with CfOpenClosedInterfacesAnalysisHelper + emulated interface.

@clementbera, The above assertion is only enabled in tests, to validate that we generally don't have assignments that don't type check according to subtyping. When I compile the dump using the R8 version of the dump, I get:

Caused by: java.lang.AssertionError
	at com.android.tools.r8.ir.desugar.desugaredlibrary.retargeter.DesugaredLibraryRetargeterSyntheticHelper.verifyKind(DesugaredLibraryRetargeterSyntheticHelper.java:106)

Since you hit the other assertion error, I assume you compiled the dump using, for example, testForR8. The assertion failure is highlighting that somewhere in the app there is an assignment from java.lang.Object to java.lang.Iterable, which does not type check according to subtyping. This still runs fine, however.

To silence the assertion error in local testing, you can configure the test as follows:

.addOptionsModification(o -> o.getOpenClosedInterfacesOptions().suppressAllOpenInterfaces())

We had an issue with this I remember. It's related to the indexes in the machine specification. It should be fixed but maybe it's not yet in Giraffe Canary 1. Can you retry with canary 2?

Sure, I'll give it a shot with Canary 2.

There's also an update to core desugaring library com.android.tools:desugar_jdk_libs from 2.0.0 to 2.0.1.

I'll update that as well and try building on Canary 2.

Nope, same error: java.lang.NoClassDefFoundError: Failed resolution of: Lj$/util/Map;

Hello! Same here, java.lang.ClassNotFoundException: Didn't find class "j$.util.DesugarTimeZone" with Canary 2 and "com.android.tools:desugar_jdk_libs:2.0.1"

This is a duplicate of b/262692506.

This was solved in R8 8.1.7-dev. The dump sent is using R8 8.1.6-dev. Using Canary 1-2-3 does not really matter if the project is stuck to the same AGP version in one of the gradle file.

R8 is shipped as part of AGP. So one way to fix this is to update AGP to the latest alpha, assuming it has the a more recent version of R8. Alternatively R8 can be manually updated using something like:

pluginManagement {
    buildscript {
        repositories {
            mavenCentral()
            maven {
                url = uri("https://storage.googleapis.com/r8-releases/raw")
            }
        }

        dependencies {
            classpath("com.android.tools:r8:8.1.7-dev")

        }
    }
}

Now I'm assuming this fails in Giraffe only. If this fails in Flamingo or Eel (it seems it does not) then let me know.

Ahh alright, I'll see if AGP can he updated, and give it a shot again.

For now there are no new AGP nor AS versions. I recall that updating the Android Studio (Canary) version always mandates upgrading the AGP as well, so my last build was using Android Studio Canary 2 and AGP 8.1.0-alpha02.

I guess I'll have to wait until Canary 3 and AGP 8.1.0-alpha03 is released. For now this isn't a big deal (at least for me) as I can disable desugaring without issues.

(btw both el...@gmail.com (#20) and sk...@gmail.com are mine, but I use the wrong account sometimes)

Android Studio Canary 4 with AGP 8.1.0-alpha04 is out, I'll give it a shot, with Core Library Desugaring version 2.0.2.

Nope, still the same issue. I'll try manually updating R8 as you mentioned and check again.

Still not fixed even after explicitly setting the R8 version as you mentioned in #19.

Stack trace:

java.lang.NoClassDefFoundError: Failed resolution of: Lj$/util/Map;
	at java.lang.Class.newInstance(Native Method)
	at android.app.AppComponentFactory.instantiateProvider(AppComponentFactory.java:147)
	at androidx.core.app.CoreComponentFactory.instantiateProvider(SourceFile:1)
	at android.app.ActivityThread.installProvider(ActivityThread.java:6972)
	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6528)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6445)
	at android.app.ActivityThread.access$1300(ActivityThread.java:219)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1859)
	at android.os.Handler.dispatchMessage(Handler.java:107)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7356)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)
Caused by: java.lang.ClassNotFoundException: j$.util.Map
	at java.lang.Class.newInstance(Native Method) 
	at android.app.AppComponentFactory.instantiateProvider(AppComponentFactory.java:147) 
	at androidx.core.app.CoreComponentFactory.instantiateProvider(SourceFile:1) 
	at android.app.ActivityThread.installProvider(ActivityThread.java:6972) 
	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6528) 
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6445) 
	at android.app.ActivityThread.access$1300(ActivityThread.java:219) 
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1859) 
	at android.os.Handler.dispatchMessage(Handler.java:107) 
	at android.os.Looper.loop(Looper.java:214) 
	at android.app.ActivityThread.main(ActivityThread.java:7356) 
	at java.lang.reflect.Method.invoke(Native Method) 
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491) 
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930) 

I have a similar issue using Giraffe alpha 4, AGP 8.1.0-alpha04, Gradle 8.0-RC3 and com.android.tools:desugar_jdk_libs versions 2.0.2, 2.0.0 and 1.2.2. Previous working setup was Flamingo Canary 11, matching AGP and com.android.tools:desugar_jdk_libs:2.0.0. I spent 2h trying various things to no avail (always making clean builds). I tried with default R8 as well as the latest v8.1.18-dev. Debug APK without minification works fine.

Launching my release APK (here with just obfuscation disabled to see the class names), I get 2 crashes very early on app startup:

In the BackupAgent::onRestoreFinished().

Line AppUtils.java:313 is a static variable initializer (slightly edited):

static private final List<String> SOME_CONSTANT = List.of("elem1", "elem2");

java.lang.NoClassDefFoundError: Failed resolution of: Lj$/util/Objects;
                         E   45:14.544      at <redacted>.AppUtils$$ExternalSyntheticBackport7.m(R8$$SyntheticClass:0)
                         E   45:14.544      at <redacted>.AppUtils$$ExternalSyntheticBackport3.m(R8$$SyntheticClass:0)
                         E   45:14.544      at <redacted>.AppUtils.<clinit>(AppUtils.java:313)
                         E   45:14.544      at <redacted>.AppUtils.upgradeRemoteServerPrefs(Unknown Source:0)
                         E   45:14.544      at <redacted>.MyBackupAgent.onRestoreFinished(MyBackupAgent.java:208)
                         E   45:14.544      at android.app.backup.BackupAgent$BackupServiceBinder.doRestoreFinished(BackupAgent.java:1259)
                         E   45:14.544      at android.app.IBackupAgent$Stub.onTransact(IBackupAgent.java:404)
                         E   45:14.544      at android.os.Binder.execTransactInternal(Binder.java:1285)
                         E   45:14.544      at android.os.Binder.execTransact(Binder.java:1244)

On normal app startup, it crashes in a static initializer of Firebase. I decompiled the APK with apktool and that androidx/collection/ArrayMap class is present !

    E   45:26.124  java.lang.NoClassDefFoundError: Failed resolution of: Landroidx/collection/ArrayMap;
                         E   45:26.124      at com.google.firebase.FirebaseApp.<clinit>(FirebaseApp.java:101)
                         E   45:26.124      at com.google.firebase.FirebaseApp.initializeApp(FirebaseApp.java:236)
                         E   45:26.124      at com.google.firebase.provider.FirebaseInitProvider.onCreate(FirebaseInitProvider.java:66)
                         E   45:26.124      at android.content.ContentProvider.attachInfo(ContentProvider.java:2451)
                         E   45:26.124      at android.content.ContentProvider.attachInfo(ContentProvider.java:2421)
                         E   45:26.124      at com.google.firebase.provider.FirebaseInitProvider.attachInfo(FirebaseInitProvider.java:58)
                         E   45:26.124      at android.app.ActivityThread.installProvider(ActivityThread.java:7474)
                         E   45:26.124      at android.app.ActivityThread.installContentProviders(ActivityThread.java:6985)
                         E   45:26.124      at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6756)
                         E   45:26.124      at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
                         E   45:26.124      at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2129)
                         E   45:26.124      at android.os.Handler.dispatchMessage(Handler.java:106)
                         E   45:26.124      at android.os.Looper.loopOnce(Looper.java:201)
                         E   45:26.124      at android.os.Looper.loop(Looper.java:288)
                         E   45:26.124      at android.app.ActivityThread.main(ActivityThread.java:7884)
                         E   45:26.124      at java.lang.reflect.Method.invoke(Native Method)
                         E   45:26.124      at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                         E   45:26.124      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Regarding #24 I don't know it seems to work on my machine from the provided dump on 8.1.7-dev and higher which confuses me.

Regarding #25, in 8.1.8-dev the backport of List#of has changed.

Both backports rely on Objects#requireNonNull but possibly different backports led to different inlining strategies?

What is your minSDK? What's the Android version of your device?

I tried to investigate locally and I get direct references to j$/util/Set$-CC on the old one and j$/util/Objects on the new one.

minSDK is 21 and my testing device on which these crashes happen is a Pixel 4a running Android 13 (latest beta QRP).

Compling for minSDK 24, app still crashes but a bit later with a different problem:

java.lang.NoClassDefFoundError: Failed resolution of: Lj$/util/DesugarTimeZone;

Using com.android.tools:desugar_jdk_libs:2.0.2.

For the time being, I had to downgrade to AGP 7.4.1 as latest alpha AGP is completely broken for release builds (works fine for debug builds as long as minification is disabed). Using AGP 7.4.1 with com.android.tools:desugar_jdk_libs:2.0.2 and Gradle 8.0. AGP 7.4.1 also works fine with latest AS Giraffe so no need to downgrade AS.

Still happening with:

• Android Studio Giraffe | 2022.3.1 Canary 5
• classpath "com.android.tools.build:gradle:8.1.0-alpha05"
• coreLibraryDesugaring "com.android.tools:desugar_jdk_libs:2.0.2"

java.lang.NoClassDefFoundError: Failed resolution of: Lj$/util/DesugarTimeZone;
	at l52.<clinit>(SourceFile:14)
	at m52.<clinit>(SourceFile:24)
	at rg0.<clinit>(SourceFile:1)
	at sg0.<clinit>(SourceFile:13)
	at d24.b(SourceFile:12)
	at w70.e(SourceFile:890)
	at w82.e(SourceFile:156)
	at i91.get(SourceFile:25)
	at o72.get(SourceFile:14)
	at n80.f(SourceFile:52)
	at m91.d(SourceFile:106)
	at m91.e(SourceFile:145)
	at com.google.firebase.provider.FirebaseInitProvider.onCreate(SourceFile:38)
	at android.content.ContentProvider.attachInfo(ContentProvider.java:2451)
	at android.content.ContentProvider.attachInfo(ContentProvider.java:2421)
	at com.google.firebase.provider.FirebaseInitProvider.attachInfo(SourceFile:13)
	at android.app.ActivityThread.installProvider(ActivityThread.java:7462)
	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6973)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6744)
	at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2133)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7872)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Hi bingran@

It seems desugared library does not work at all in release mode in the latest Giraffe (AGP 8.1.0-alpha06) and all previous Giraffe. It works in Flamingo.

To reproduce:

• create an "Empty Views Activity" project,
• set desugared library (https://developer.android.com/studio/write/java8-support#library-desugaring),
• set minifyEnabled true in release and do not alter the code in any way (not using desugared library)

It works fine in debug.

It crashed for me at start-up in release mode with:

java.lang.NoClassDefFoundError: Failed resolution of: Lj$/util/DesugarCollections;
     at androidx.fragment.app.l0.<init>(SourceFile:44)
     at androidx.fragment.app.u.<init>(SourceFile:13)
     at androidx.fragment.app.v.<init>(SourceFile:9)

It seems that desugared library but all class names are minified. Do you have any clue? It seems release without shrinking the program but shrinking only desugared library works. Everything works fine in our local tests which let me believe (maybe wrongly) that agp is not passing the keep rules or flags correctly. Did you enable keep rules with trace reference or something like that?

It turns out the desugared apis are there but has been obfuscated when dexing with l8. If I disable obfuscation just like what we already do for non-minified release build, it works.

Clement, is that expected?

When dexing desugar library with l8, we pass the program dex files generated from r8 so in theory l8 should be able to obfuscate the desugar library based on the usage from program dex files? Or apart from the program dex files, we need to pass more to l8? e.g. mapping file?

I understand that desugared library has been obfuscated and that should not be the case. The keep rules (either output by R8 or through tracereference) should have prevented obfuscation. This used to work and this is still now fully tested in our test suite.

Your text confuses me. L8 should take as input the desugared library jar and not the dex files generated from r8.

Did you change the way the keep rules are generated for L8 for example by using trace reference instead of the direct r8 output? Are the keep rules identical? It seems to me the issue would be that the keep rules are incorrect.

For example, in the case above, I suspect that instead of generating:

-keep class j$.util.DesugarCollections {...}

We now have:

-keep class java.util.DesugarCollections {...}

How can I see the keep rules that agp generates for L8 a given build? I may be able to do it with dumps.

Ok I figured it out.

The issue is that agp generates keep rules throught tracereference which looks like:

-keep,allowobfuscation class j$.util.concurrent.ConcurrentHashMap 

We should essentially do the same but without the "allowobfuscation".

This could imply building the TraceReference command with something along the lines of:

TraceReferencesKeepRules.builder()
                    .setAllowObfuscation(false)

Could you fix this Bingran? I think this is P1 or P0.

It would be nice if AGP could have a regression test for that too btw.

With what #36 suggests, we are not doing obfuscation for desugar library apis in all the cases, right?

I have the same issue as in #24 (except the crash is java.lang.NoClassDefFoundError: Failed resolution of: Lj$/util/DesugarTimeZone;) using:

• AGP 8.1.0-alpha09
• Kotlin 1.8.10
• Gradle 8.0.2
• Desugar 2.0.2
• minSdk 24
• targetSdk 33
• JDK 17

The crash only started happening after updating from AGP 8.0.0-beta05 to AGP 8.1.0-alpha09.

I tried adding the proguard rules mentioned in #36 without allowobfuscation and the crash still occurs.

If I set isMinifyEnabled = false then the crash goes away.

Is there any way we can workaround this without downgrading to AGP 8.0.0?

Here's the full unobfuscated crash:

java.lang.NoClassDefFoundError: Failed resolution of: Lj$/util/DesugarTimeZone;
                 	at com.google.firebase.encoders.json.JsonDataEncoderBuilder$TimestampEncoder.<clinit>(SourceFile:14)
                 	at com.google.firebase.encoders.json.JsonDataEncoderBuilder.<clinit>(SourceFile:24)
                 	at com.google.firebase.crashlytics.internal.model.serialization.CrashlyticsReportJsonTransform.<clinit>(SourceFile:1)
                 	at com.google.firebase.crashlytics.internal.persistence.CrashlyticsReportPersistence.<clinit>(SourceFile:13)
                 	at com.google.firebase.crashlytics.internal.common.SessionReportingCoordinator.create(SourceFile:12)
                 	at androidx.camera.video.Recorder$$ExternalSyntheticLambda2.create(SourceFile:982)
                 	at com.google.firebase.tracing.ComponentMonitor$$ExternalSyntheticLambda0.create(SourceFile:18)
                 	at com.google.firebase.FirebaseApp$$ExternalSyntheticLambda0.get(SourceFile:25)
                 	at com.google.firebase.components.Lazy.get(SourceFile:14)
                 	at com.google.firebase.components.ComponentRuntime.doInitializeEagerComponents(SourceFile:52)
                 	at com.google.firebase.components.ComponentRuntime.initializeEagerComponents(SourceFile:35)
                 	at com.google.firebase.FirebaseApp.initializeAllApis(SourceFile:71)
                 	at com.google.firebase.FirebaseApp.initializeApp(SourceFile:36)
                 	at com.google.firebase.FirebaseApp.initializeApp(SourceFile:7)
                 	at com.google.firebase.provider.FirebaseInitProvider.onCreate(SourceFile:12)
                 	at android.content.ContentProvider.attachInfo(ContentProvider.java:2451)
                 	at android.content.ContentProvider.attachInfo(ContentProvider.java:2421)
                 	at com.google.firebase.provider.FirebaseInitProvider.attachInfo(SourceFile:13)
                 	at android.app.ActivityThread.installProvider(ActivityThread.java:7474)
                 	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6985)
                 	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6756)
                 	at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
                 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2129)
                 	at android.os.Handler.dispatchMessage(Handler.java:106)
                 	at android.os.Looper.loopOnce(Looper.java:201)
                 	at android.os.Looper.loop(Looper.java:288)
                 	at android.app.ActivityThread.main(ActivityThread.java:7884)
                 	at java.lang.reflect.Method.invoke(Native Method)
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                 Caused by: java.lang.ClassNotFoundException: j$.util.DesugarTimeZone
                 	at com.google.firebase.encoders.json.JsonDataEncoderBuilder$TimestampEncoder.<clinit>(SourceFile:14) 
                 	at com.google.firebase.encoders.json.JsonDataEncoderBuilder.<clinit>(SourceFile:24) 
                 	at com.google.firebase.crashlytics.internal.model.serialization.CrashlyticsReportJsonTransform.<clinit>(SourceFile:1) 
                 	at com.google.firebase.crashlytics.internal.persistence.CrashlyticsReportPersistence.<clinit>(SourceFile:13) 
                 	at com.google.firebase.crashlytics.internal.common.SessionReportingCoordinator.create(SourceFile:12) 
                 	at androidx.camera.video.Recorder$$ExternalSyntheticLambda2.create(SourceFile:982) 
                 	at com.google.firebase.tracing.ComponentMonitor$$ExternalSyntheticLambda0.create(SourceFile:18) 
                 	at com.google.firebase.FirebaseApp$$ExternalSyntheticLambda0.get(SourceFile:25) 
                 	at com.google.firebase.components.Lazy.get(SourceFile:14) 
                 	at com.google.firebase.components.ComponentRuntime.doInitializeEagerComponents(SourceFile:52) 
                 	at com.google.firebase.components.ComponentRuntime.initializeEagerComponents(SourceFile:35) 
                 	at com.google.firebase.FirebaseApp.initializeAllApis(SourceFile:71) 
                 	at com.google.firebase.FirebaseApp.initializeApp(SourceFile:36) 
                 	at com.google.firebase.FirebaseApp.initializeApp(SourceFile:7) 
                 	at com.google.firebase.provider.FirebaseInitProvider.onCreate(SourceFile:12) 
                 	at android.content.ContentProvider.attachInfo(ContentProvider.java:2451) 
                 	at android.content.ContentProvider.attachInfo(ContentProvider.java:2421) 
                 	at com.google.firebase.provider.FirebaseInitProvider.attachInfo(SourceFile:13) 
                 	at android.app.ActivityThread.installProvider(ActivityThread.java:7474) 
                 	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6985) 
                 	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6756) 
                 	at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0) 
                 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2129) 
                 	at android.os.Handler.dispatchMessage(Handler.java:106) 
                 	at android.os.Looper.loopOnce(Looper.java:201) 
                 	at android.os.Looper.loop(Looper.java:288) 
                 	at android.app.ActivityThread.main(ActivityThread.java:7884) 
                 	at java.lang.reflect.Method.invoke(Native Method) 
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) 
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936) 
`

Fixed with I6290c3f7f041b9b8330e69e4e5dbf5dbb187d550 which should be available in AGP 8.1 beta01. Thanks everyone for reporting this issue!

Is there a version of R8 that we can use before beta 1 is related?

Unfortunately I don't think changing the r8 version works. The only workaround(but not recommended) is to configure AGP task.

Is the fix available in AGP 8.1.0-alpha10?

re #46, not in 8.1.0-alpha10, it is available from AGP 8.1 beta01

It's listed in the 8.1.0-alpha11 changelog.

Can you point me to that change log?

https://developer.android.com/studio/releases/fixed-bugs/studio/2022.3.1

Actually our release schedule has changed and it should be available from 8.1.0-alpha11.