[Material 2][BottomSheet] Allow ModalBottomSheetLayout max width to be overriden [266697696]

Feature Request

Status Update

No update yet.

Description

ha...@gmail.com

created issue #1

Jan 26, 2023 05:47PM

Compose 1.4.0-alpha04 introduced a max width constraint on ModalBottomSheetLayout. However, the Material 3 guidelines say that this behaviour can be overriden if needed for large screens:

For larger screens, bottom sheets have a default max-width to prevent undesired layouts and awkward spacing. However, this can be overridden if needed.

I have designs that expect, and will take advantage of, the entire screen width in a bottom sheet, and would like to have this behaviour without creating my own implementation.

As noted in the issue related to adding the max width constraint, the Design & Quality section on developer.android.com seems to specify that the width should always be constrained (with links to Material 2).

I'm not sure what the intended behaviour here is as there seems to be a difference between Material 2 and 3. Since ModalBottomSheetLayout is in compose.material and not compose.material3 I assume it isn't based on Material 3. If that is the case, is there a plan to add a corresponding component in compose.material3 with a modal bottom sheet that can override the max width constraint?

Comments

jo...@google.com <jo...@google.com> Feb 6, 2023 03:28PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> #2Feb 7, 2023 01:11PM

This should fixed by https://android-review.googlesource.com/c/platform/frameworks/support/+/1226859.

This should land in WorkManager 2.3.2.

ga...@gmail.com <ga...@gmail.com> #3May 30, 2023 04:01AM

Artifact used androidx.work:work-runtime:2.3.1
Version used:2.3.1

Theme used:
Devices/Android versions reproduced on:
Pixel devices,One Plus devices / 10.0
Samsung, Realme, Oppo/ 9.0
Motorola / 8.0

- Relevant code to trigger the issue.
WorkManager workManagerInstance = WorkManager.getInstance(context);

Data input = new Data.Builder().putString("xxx", xxx).build();

Constraints constraints = new Constraints.Builder()
.setRequiredNetworkType(NetworkType.CONNECTED).build();

mGetShowRequest = new OneTimeWorkRequest.Builder(ShowParserWork.class)
.setConstraints(constraints).setInputData(input)
.addTag(TAG_WORKER_NAME)
.setBackoffCriteria(BackoffPolicy.EXPONENTIAL, 30, TimeUnit.SECONDS).build();

workManagerInstance.enqueueUniqueWork(TAG_WORKER_NAME,
ExistingWorkPolicy.KEEP,mGetShowRequest);

Stacktrace:-

Fatal Exception: java.lang.IllegalStateException: JobScheduler 100 job limit exceeded. We count 101 WorkManager jobs in JobScheduler; we have 20 tracked jobs in our DB; our Configuration limit is 20.
at androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal + 199(SystemJobScheduler.java:199)
at androidx.work.impl.background.systemjob.SystemJobScheduler.schedule + 127(SystemJobScheduler.java:127)
at androidx.work.impl.Schedulers.schedule + 92(Schedulers.java:92)
at androidx.work.impl.WorkerWrapper.onWorkFinished + 369(WorkerWrapper.java:369)
at androidx.work.impl.WorkerWrapper$2.run + 318(WorkerWrapper.java:318)
at androidx.work.impl.utils.SerialExecutor$Task.run + 91(SerialExecutor.java:91)
at java.util.concurrent.ThreadPoolExecutor.runWorker + 1167(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run + 641(ThreadPoolExecutor.java:641)
at java.lang.Thread.run + 919(Thread.java:919)

Caused by java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs
at android.os.Parcel.createException + 2079(Parcel.java:2079)
at android.os.Parcel.readException + 2039(Parcel.java:2039)
at android.os.Parcel.readException + 1987(Parcel.java:1987)
at android.app.job.IJobScheduler$Stub$Proxy.schedule + 308(IJobScheduler.java:308)
at android.app.JobSchedulerImpl.schedule + 43(JobSchedulerImpl.java:43)
at androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal + 181(SystemJobScheduler.java:181)
at androidx.work.impl.background.systemjob.SystemJobScheduler.schedule + 127(SystemJobScheduler.java:127)
at androidx.work.impl.Schedulers.schedule + 92(Schedulers.java:92)
at androidx.work.impl.WorkerWrapper.onWorkFinished + 369(WorkerWrapper.java:369)
at androidx.work.impl.WorkerWrapper$2.run + 318(WorkerWrapper.java:318)
at androidx.work.impl.utils.SerialExecutor$Task.run + 91(SerialExecutor.java:91)
at java.util.concurrent.ThreadPoolExecutor.runWorker + 1167(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run + 641(ThreadPoolExecutor.java:641)

Caused by android.os.RemoteException: Remote stack trace:
at com.android.server.job.JobSchedulerService.scheduleAsPackage(JobSchedulerService.java:1038)
at com.android.server.job.JobSchedulerService$JobSchedulerStub.schedule(JobSchedulerService.java:2740)
at android.app.job.IJobScheduler$Stub.onTransact(IJobScheduler.java:153)
at android.os.Binder.execTransactInternal(Binder.java:1021)
at android.os.Binder.execTransact(Binder.java:994)

This issue has resurfaced only on our production builds, with multiple instances of crashes. Can you let us know a fix for this issue? Thanks

se...@google.com <se...@google.com> Jun 27, 2023 04:25PM

Accepted by se...@google.com.

se...@google.com <se...@google.com> #4Jun 28, 2023 05:34PM

We fixed a bug recently, where there is a mismatch between WorkManagers tracking of jobs in JobScheduler and the actual state of the jobs. This happens in very rare cases, and I think that's what is going on in your case.

https://issuetracker.google.com/issues/149092520 was a recently reported bug. I fixed it before the bug was reported on the public tracker, because one of Google's apps ran into the same edge case.

This change (https://android-review.googlesource.com/c/platform/frameworks/support/+/1226859) has the fix. We should release this as part of WorkManager 2.3.2 very soon.

If you cannot wait, you can use a snapshot build that should be identical to the eventual release.

Here is the gradle snippet you will need:

repositories {
    google()
    maven { url 'https://ci.android.com/builds/submitted/6195753/androidx_snapshot/latest/repository/' }
}

dependencies {
  implementation "androidx.work:work-runtime:2.4.0-SNAPSHOT"
}

One other thing you might need to do is to get rid of stale jobs. It is as simple as calling JobScheduler.cancelAllJobs() before WorkManager is initialized. You can do it inside Application.onCreate() in your Application subclass.

ha...@gmail.com <ha...@gmail.com> #5Jun 30, 2023 06:56AM

WorkManager.cancelAllWork() inside Application.onCreate() solves the issue for us

se...@google.com <se...@google.com> #6Jun 30, 2023 01:19PM

Added the above-mentioned dependencies, it is not syncing causing the following error:-

Failed to resolve: androidx.work:work-runtime:2.4.0-SNAPSHOT
<a href="open.dependency.in.project.structure">Show in Project Structure dialog</a>
Affected Modules: <a href="openFile:D:/ Android App/app/build.gradle">app</a>

In my Application class, we have added WorkManager.getInstance(this).cancelAllWork();.Also, should I use the same work manager instance from my application class for all my work requests?

ha...@gmail.com <ha...@gmail.com> #7Jul 1, 2023 08:38AM

Hi Rahul

Coming from stackoverflow here.
The build you mentioned doesn't seem to exist, and when I use the latest build (

https://ci.android.com/builds/submitted/6210481/androidx_snapshot/latest/repository/)
I get some very weird missing library errors.

se...@google.com <se...@google.com> Jul 18, 2023 06:37PM

Assigned to se...@google.com.

se...@google.com <se...@google.com> Sep 12, 2023 07:30PM

Reassigned to ma...@google.com.

ke...@google.com <ke...@google.com> Sep 19, 2023 05:40PM

Marked as fixed.

ap...@google.com <ap...@google.com> #8Sep 19, 2023 05:43PM

My apologies for the delay. Try using this. This is from our dev branch.

repositories {
    google()
    maven { url 'https://ci.android.com/builds/submitted/6215972/androidx_snapshot/latest/repository/' }
}

dependencies {
  implementation "androidx.work:work-runtime:2.4.0-SNAPSHOT"
}

jo...@google.com <jo...@google.com> #9Sep 20, 2023 08:54AM

Something is likely wrong with android studio on my side because I get an error that 2.4.0-SNAPSHOT could not be resolved. Is there anything special to do to get this working in android studio?

ke...@google.com <ke...@google.com> #10Sep 20, 2023 03:56PM

Status: New (reopened)

My apologies, it looks like the artifacts were not generated for that build. I have verified that this one works:

https://ci.android.com/builds/submitted/6217200/androidx_snapshot/latest/repository/

repositories { google() maven { url 'https://ci.android.com/builds/submitted/6217200/androidx_snapshot/latest/repository/' } }

dependencies { implementation "androidx.work:work-runtime:2.4.0-SNAPSHOT" }