IssueTracker

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

Thanks for the report!

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

I agree that ModalBottomSheetLayout(modifier.widthIn(max=800.dp), providesMaxWidth=false) isn't a great experience, and could probably lead to bugs if you forget to specify both.

Another option could be to model the width with a sealed interface. This at least keeps it confined to one parameter, and I think it provides a simple enough API

sealed interface ModalBottomSheetWidth {
    object Default : ModalBottomSheetWidth
    object Fill : ModalBottomSheetWidth
    data class Custom(val width: Dp) : ModalBottomSheetWidth // Not sure if this has a use-case or not
}

@Composable
fun ModalBottomSheetLayout(
    sheetWidth: ModalBottomSheetWidth = ModalBottomSheetWidth.Default
    ...
) {
    val widthModifier = when (sheetWidth) {
        ModalBottomSheetWidth.Default -> Modifier.widthIn(max = 640.dp)
        ModalBottomSheetWidth.Fill -> Modifier.fillMaxWidth()
        is ModalBottomSheetWidth.Custom -> Modifier.width(sheetWidth.width)
    }
}

Kevin, your commit is for M3, right? This issue is for M2

Oops, yes sorry this was implemented in M3 but not in M2. Will repoen this ticket and mark the other ticket for M3 as fixed. Thank you for catching this Jossi!