[Material 2][BottomSheet] Allow ModalBottomSheetLayout max width to be overriden [266697696]

Feature Request

Status Update

No update yet.

Description

ha...@gmail.com

created issue #1

Jan 26, 2023 05:47PM

Compose 1.4.0-alpha04 introduced a max width constraint on ModalBottomSheetLayout. However, the Material 3 guidelines say that this behaviour can be overriden if needed for large screens:

For larger screens, bottom sheets have a default max-width to prevent undesired layouts and awkward spacing. However, this can be overridden if needed.

I have designs that expect, and will take advantage of, the entire screen width in a bottom sheet, and would like to have this behaviour without creating my own implementation.

As noted in the issue related to adding the max width constraint, the Design & Quality section on developer.android.com seems to specify that the width should always be constrained (with links to Material 2).

I'm not sure what the intended behaviour here is as there seems to be a difference between Material 2 and 3. Since ModalBottomSheetLayout is in compose.material and not compose.material3 I assume it isn't based on Material 3. If that is the case, is there a plan to add a corresponding component in compose.material3 with a modal bottom sheet that can override the max width constraint?

Comments

jo...@google.com <jo...@google.com> Feb 6, 2023 03:28PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> #2Feb 7, 2023 01:11PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ga...@gmail.com <ga...@gmail.com> #3May 30, 2023 04:01AM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

se...@google.com <se...@google.com> Jun 27, 2023 04:25PM

Accepted by se...@google.com.

se...@google.com <se...@google.com> #4Jun 28, 2023 05:34PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ha...@gmail.com <ha...@gmail.com> #5Jun 30, 2023 06:56AM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

se...@google.com <se...@google.com> #6Jun 30, 2023 01:19PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

ha...@gmail.com <ha...@gmail.com> #7Jul 1, 2023 08:38AM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

se...@google.com <se...@google.com> Jul 18, 2023 06:37PM

Assigned to se...@google.com.

se...@google.com <se...@google.com> Sep 12, 2023 07:30PM

Reassigned to ma...@google.com.

ke...@google.com <ke...@google.com> Sep 19, 2023 05:40PM

Marked as fixed.

ap...@google.com <ap...@google.com> #8Sep 19, 2023 05:43PM

Thank you, I'll try it and check.

jo...@google.com <jo...@google.com> #9Sep 20, 2023 08:54AM

Hello. I have similar experience.

I'm using mlkit-language 16.1.1
I didnot meet this error until using AGP 4.2
I can get this error since using AGP 7.0
This error raised on Release build only(minimized by R8)
This error raised without obfuscation.

ke...@google.com <ke...@google.com> #10Sep 20, 2023 03:56PM

Status: New (reopened)

Also I found there is a post which presents same issue on stackoverflow.

https://stackoverflow.com/questions/68832304/mlkit-translate-sdk-crashes-in-release-build