DexingFileDependenciesTask.outputKeepRules is a directory but is marked as an OutputFile [266780231]

Fixed

Bug

Status Update

No update yet.

Description

de...@squareup.com

created issue #1

Jan 26, 2023 05:20PM

DESCRIBE THE ISSUE IN DETAIL:

In AGP 7.4+, the outputKeepRules property in DexingFileDependenciesTask was changed from a RegularFileProperty to a DirectoryProperty (in this commit), however it is still marked as an OutputFile.

This causes a configuration error as gradle expects this property to be a file, but finds a directory instead. It should be marked with `OutputDirectory.

Configuration error:

org.gradle.internal.execution.WorkValidationException: A problem was found with the configuration of task ':app:desugarProductionReleaseFileDependencies' (type 'DexFileDependenciesTask').
  - In plugin 'com.android.internal.version-check' type 'com.android.build.gradle.internal.tasks.DexFileDependenciesTask' property 'outputKeepRules' is not writable because '[...]/app/build/intermediates/desugar_lib_external_file_lib_keep_rules/productionRelease' is not a file.
    
    Reason: Cannot write a file to a location pointing at a directory.
    
    Possible solutions:
      1. Configure 'outputKeepRules' to point to a file, not a directory.
      2. Annotate 'outputKeepRules' with @OutputDirectory instead of @OutputFiles.

This property appears to have been removed in AGP 8.1, but this issue still affects both AGP 7.4 and 8.0.

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: --
Version of Gradle Plugin: 7.4, 8.0-beta02
Version of Gradle: 7.6
Version of Java: --
OS: --

Comments

hu...@google.com <hu...@google.com> Jan 26, 2023 06:46PM

Assigned to an...@google.com.

bi...@google.com <bi...@google.com> Jan 26, 2023 06:53PM

Accepted by bi...@google.com.

bi...@google.com <bi...@google.com> #2Jan 26, 2023 07:58PM

Project: r8
Branch: main

commit 39f08f72219210c78d964f356552efd6c8a3275a
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Thu Jan 19 14:12:31 2023

[Metadata] Update kotlin-metadata-jvm to version 0.6.0

Bug:

b/265108171

Change-Id: I2441b7c328acda8efa13c4e0a7c334cf275f0b44

M build.gradle
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassLevelInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassMetadataReader.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFileFacadeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataRewriter.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassFacadeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassPartInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/test/java/com/android/tools/r8/kotlin/coroutines/KotlinxCoroutinesTestRunner.java
M src/test/java/com/android/tools/r8/kotlin/metadata/KotlinMetadataTestBase.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteBoxedTypesTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlineClassTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlinePropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteKeepTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteLocalDelegatedPropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewritePassThroughTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteRawTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteUnitPrimitiveTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteValueClassTest.java

https://r8-review.googlesource.com/75218

de...@squareup.com <de...@squareup.com> #3Jan 26, 2023 08:14PM

Project: r8
Branch: main

commit dde8cf4cd2e452225400d77819767cd48406cd41
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Jan 23 17:32:03 2023

[Metadata] Update service import in sanity check test

Bug:

b/265108171

Change-Id: I25d5a272b8a3cab18e638e85553bbf5b98997b60

M src/test/java/com/android/tools/r8/SanityCheck.java

https://r8-review.googlesource.com/75322

bi...@google.com <bi...@google.com> #4Feb 2, 2023 01:10AM

The public work of this has now been completed. I created b/266682027 for tracking the internal work on upgrading the library.

bi...@google.com <bi...@google.com> #5Feb 2, 2023 07:13PM

Marked as fixed.

Project: r8
Branch: 8.0

commit 177f2a32494e4e9baedd895eb920bc41825ef77b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 25 13:22:14 2023

Version 8.0.27

Bug:

b/265108171

Bug:

b/266177488

Bug:

b/266396725

Change-Id: Iebc28bdd06d6330116a8b12336f25be201603745

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/75409

eb...@netflix.com <eb...@netflix.com> #6Feb 16, 2023 09:40PM

Project: r8
Branch: 8.0

commit 1c9ab7b7cff3bdc3de67ce8b6cd032907f72c8ef
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 25 13:21:40 2023

[Metadata] Update service import in sanity check test

Bug:

b/265108171

Change-Id: I25d5a272b8a3cab18e638e85553bbf5b98997b60

M src/test/java/com/android/tools/r8/SanityCheck.java

https://r8-review.googlesource.com/75406

Issue 266780231

Description

Issue summary

Comments

hu...@google.com <hu...@google.com> Jan 26, 2023 06:46PM

bi...@google.com <bi...@google.com> Jan 26, 2023 06:53PM

bi...@google.com <bi...@google.com> #2Jan 26, 2023 07:58PM

de...@squareup.com <de...@squareup.com> #3Jan 26, 2023 08:14PM

bi...@google.com <bi...@google.com> #4Feb 2, 2023 01:10AM

bi...@google.com <bi...@google.com> #5Feb 2, 2023 07:13PM

eb...@netflix.com <eb...@netflix.com> #6Feb 16, 2023 09:40PM

Add comment

Issue metadata