DexingFileDependenciesTask.outputKeepRules is a directory but is marked as an OutputFile [266780231]

Fixed

Bug

Status Update

No update yet.

Description

de...@squareup.com

created issue #1

Jan 26, 2023 05:20PM

DESCRIBE THE ISSUE IN DETAIL:

In AGP 7.4+, the outputKeepRules property in DexingFileDependenciesTask was changed from a RegularFileProperty to a DirectoryProperty (in this commit), however it is still marked as an OutputFile.

This causes a configuration error as gradle expects this property to be a file, but finds a directory instead. It should be marked with `OutputDirectory.

Configuration error:

org.gradle.internal.execution.WorkValidationException: A problem was found with the configuration of task ':app:desugarProductionReleaseFileDependencies' (type 'DexFileDependenciesTask').
  - In plugin 'com.android.internal.version-check' type 'com.android.build.gradle.internal.tasks.DexFileDependenciesTask' property 'outputKeepRules' is not writable because '[...]/app/build/intermediates/desugar_lib_external_file_lib_keep_rules/productionRelease' is not a file.
    
    Reason: Cannot write a file to a location pointing at a directory.
    
    Possible solutions:
      1. Configure 'outputKeepRules' to point to a file, not a directory.
      2. Annotate 'outputKeepRules' with @OutputDirectory instead of @OutputFiles.

This property appears to have been removed in AGP 8.1, but this issue still affects both AGP 7.4 and 8.0.

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: --
Version of Gradle Plugin: 7.4, 8.0-beta02
Version of Gradle: 7.6
Version of Java: --
OS: --

Comments

hu...@google.com <hu...@google.com> Jan 26, 2023 06:46PM

Assigned to an...@google.com.

bi...@google.com <bi...@google.com> Jan 26, 2023 06:53PM

Accepted by bi...@google.com.

bi...@google.com <bi...@google.com> #2Jan 26, 2023 07:58PM

Here is the stacktrace:

java.lang.VerifyError: Verifier rejected class WN: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent) failed to verify: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent): [0x4]  can't resolve returned type 'Reference: android.app.Notification$Style' or 'Unresolved Reference: android.app.Notification$CallStyle' (declaration of 'WN' appears in base.apk!classes4.dex)
	at Tj.<init>(SourceFile:17)
	at kT1.<init>(SourceFile:23)
	at aL1.<init>(SourceFile:293)
	at bh4.get(SourceFile:1606)
	at cL1.a(SourceFile:29)
	at cL1.e(SourceFile:17)
	at s1i.getValue(Unknown Source:17)
	at dL1.a(SourceFile:11)
	at RQ1.b(Unknown Source:2)
	at EQ1.execute(SourceFile:15)
	at lU1.handleMessage(SourceFile:18)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at N52.dispatchMessage(SourceFile:7)
	at android.os.Looper.loop(Looper.java:237)
	at android.os.HandlerThread.run(HandlerThread.java:67)

Unfortunately, I can't share the dex2oat logs for this as I'm running into this problem on Android 11 emulator and I don't have a rooted Android 11 device on-hand.

de...@squareup.com <de...@squareup.com> #3Jan 26, 2023 08:14PM

Thanks for the report. Can you share the APK failing and give suggestions to force the error such that I can see the entire logcat on device. The outline is looking correct so I believe the error is someplace else and logcat will show that.

bi...@google.com <bi...@google.com> #4Feb 2, 2023 01:10AM

I shared the APK and instructions to reproduce over email. Let me know if you have any trouble reproing the crash.

bi...@google.com <bi...@google.com> #5Feb 2, 2023 07:13PM

Marked as fixed.

Thank you for the dump and information. Turns out that behavior of the verifier changed on Android 11 and 12 but was reverted again. I am working on a fix that should be easy to merge to the 4.0 branch.

Note that the verification error is actually also easy to create by manual outlining, but our pattern just emphasize it.

eb...@netflix.com <eb...@netflix.com> #6Feb 16, 2023 09:40PM

Project: r8
Branch: main

commit b7b22190797c9b74218fb1d2fdfb497a9be9fb3b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 13:03:38 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

Change-Id: I2479d669217d90f057fa248fcea0f0f27faf91a6

M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
M src/main/java/com/android/tools/r8/ir/code/Return.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java
M src/main/java/com/android/tools/r8/ir/desugar/apimodel/ApiInvokeOutlinerDesugaring.java
A src/main/java/com/android/tools/r8/ir/optimize/RemoveVerificationErrorForUnknownReturnedValues.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineHorizontalMergingTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineInstanceInitializerTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77221