DexingFileDependenciesTask.outputKeepRules is a directory but is marked as an OutputFile [266780231]

Fixed

Bug

Status Update

No update yet.

Description

de...@squareup.com

created issue #1

Jan 26, 2023 05:20PM

DESCRIBE THE ISSUE IN DETAIL:

In AGP 7.4+, the outputKeepRules property in DexingFileDependenciesTask was changed from a RegularFileProperty to a DirectoryProperty (in this commit), however it is still marked as an OutputFile.

This causes a configuration error as gradle expects this property to be a file, but finds a directory instead. It should be marked with `OutputDirectory.

Configuration error:

org.gradle.internal.execution.WorkValidationException: A problem was found with the configuration of task ':app:desugarProductionReleaseFileDependencies' (type 'DexFileDependenciesTask').
  - In plugin 'com.android.internal.version-check' type 'com.android.build.gradle.internal.tasks.DexFileDependenciesTask' property 'outputKeepRules' is not writable because '[...]/app/build/intermediates/desugar_lib_external_file_lib_keep_rules/productionRelease' is not a file.
    
    Reason: Cannot write a file to a location pointing at a directory.
    
    Possible solutions:
      1. Configure 'outputKeepRules' to point to a file, not a directory.
      2. Annotate 'outputKeepRules' with @OutputDirectory instead of @OutputFiles.

This property appears to have been removed in AGP 8.1, but this issue still affects both AGP 7.4 and 8.0.

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: --
Version of Gradle Plugin: 7.4, 8.0-beta02
Version of Gradle: 7.6
Version of Java: --
OS: --

Comments

hu...@google.com <hu...@google.com> Jan 26, 2023 06:46PM

Assigned to an...@google.com.

bi...@google.com <bi...@google.com> Jan 26, 2023 06:53PM

Accepted by bi...@google.com.

bi...@google.com <bi...@google.com> #2Jan 26, 2023 07:58PM

As I understand it, we need to migrate namespace definitions both from AndroidManifest.xml and from implicit definitions from applicationId / testApplicationId? Is that right? So an 8.0 project would have a

namespace <n>
testNamespace <tn>

where <n> is taken from AndroidManifest.xml package definitions if present, and applicationId if not, and <tn> is testApplicationId if present and <n>.test if not?

de...@squareup.com <de...@squareup.com> #3Jan 26, 2023 08:14PM

Sorry for the confusion. AGP would change how it computes the namespace for the androidTest variant. All the Upgrade assistant would need to do is update the source code for the import of the R class.

bi...@google.com <bi...@google.com> #4Feb 2, 2023 01:10AM

OK! And, I think, this should happen at the same time as the namespace declaration is migrated from AndroidManifest.xml?

bi...@google.com <bi...@google.com> #5Feb 2, 2023 07:13PM

Marked as fixed.

It's unrelated, but it is possible that we move 8.0 to also only declare the namespace into the DSL. I would make it a separate refactoring because they are not tied at all.

eb...@netflix.com <eb...@netflix.com> #6Feb 16, 2023 09:40PM

I would consider first adding the right new value to models (as a new property) and then, to avoid Studio interpreting manifests and build configurations, just update to whatever the synced value of this new property is.