DexingFileDependenciesTask.outputKeepRules is a directory but is marked as an OutputFile [266780231]

Fixed

Bug

Status Update

No update yet.

Description

de...@squareup.com

created issue #1

Jan 26, 2023 05:20PM

DESCRIBE THE ISSUE IN DETAIL:

In AGP 7.4+, the outputKeepRules property in DexingFileDependenciesTask was changed from a RegularFileProperty to a DirectoryProperty (in this commit), however it is still marked as an OutputFile.

This causes a configuration error as gradle expects this property to be a file, but finds a directory instead. It should be marked with `OutputDirectory.

Configuration error:

org.gradle.internal.execution.WorkValidationException: A problem was found with the configuration of task ':app:desugarProductionReleaseFileDependencies' (type 'DexFileDependenciesTask').
  - In plugin 'com.android.internal.version-check' type 'com.android.build.gradle.internal.tasks.DexFileDependenciesTask' property 'outputKeepRules' is not writable because '[...]/app/build/intermediates/desugar_lib_external_file_lib_keep_rules/productionRelease' is not a file.
    
    Reason: Cannot write a file to a location pointing at a directory.
    
    Possible solutions:
      1. Configure 'outputKeepRules' to point to a file, not a directory.
      2. Annotate 'outputKeepRules' with @OutputDirectory instead of @OutputFiles.

This property appears to have been removed in AGP 8.1, but this issue still affects both AGP 7.4 and 8.0.

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: --
Version of Gradle Plugin: 7.4, 8.0-beta02
Version of Gradle: 7.6
Version of Java: --
OS: --

Comments

hu...@google.com <hu...@google.com> Jan 26, 2023 06:46PM

Assigned to an...@google.com.

bi...@google.com <bi...@google.com> Jan 26, 2023 06:53PM

Accepted by bi...@google.com.

bi...@google.com <bi...@google.com> #2Jan 26, 2023 07:58PM

Thank you for the report and the supplied dump with the reproduction. I can confirm that the NPE is also present on HEAD, and I will look into it.

Quite a few of the class files in the dump has malformed inner-class attribute, where R8 reports e.g.:

Info in /tmp/tmpo67ucguh/program.jar:ofifmwrrhhmodsc/ψξψξψξξ.class:
Malformed inner-class attribute:
	outerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ
	innerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ$ψξξψξξξ
	innerName: ψξψξψξξ$ψξξψξξξ

These are ignored, so they should not be the reason for the NPE, but something to also look into.

de...@squareup.com <de...@squareup.com> #3Jan 26, 2023 08:14PM

Project: r8
Branch: main

commit e59500ca4445f5fb5d2ccc1114acbf66df11d196
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:55 2023

Insert patched frame instructions in the right place

Fixes:

b/274337639

Change-Id: Iae204ed529f9af5bf5fa3eaacba45128dfa6fd9e

M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77390

bi...@google.com <bi...@google.com> #4Feb 2, 2023 01:10AM

Project: r8
Branch: main

commit 780c2e83c8c033e7594d61894fa1b3dbcad6630b
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:13 2023

Add reproduction of

b/274337639

Bug:

b/274337639

Change-Id: I7573883d6a649eed47b10d7bf0cdea2e11710268

M build.gradle
M src/main/java/com/android/tools/r8/cf/code/frame/UninitializedNew.java
A src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77389

bi...@google.com <bi...@google.com> #5Feb 2, 2023 07:13PM

Marked as fixed.

I will backport this to the 8.0 and 4.0 branches.

eb...@netflix.com <eb...@netflix.com> #6Feb 16, 2023 09:40PM

Thank you very much for taking a look at this!

Is this fix related to the nullpointer or the malformed inner-class attributes ?

Do you have a separated ticket for it? Could you share it?

Issue 266780231

Description

Issue summary

Comments

hu...@google.com <hu...@google.com> Jan 26, 2023 06:46PM

bi...@google.com <bi...@google.com> Jan 26, 2023 06:53PM

bi...@google.com <bi...@google.com> #2Jan 26, 2023 07:58PM

de...@squareup.com <de...@squareup.com> #3Jan 26, 2023 08:14PM

bi...@google.com <bi...@google.com> #4Feb 2, 2023 01:10AM

bi...@google.com <bi...@google.com> #5Feb 2, 2023 07:13PM

eb...@netflix.com <eb...@netflix.com> #6Feb 16, 2023 09:40PM

Add comment

Issue metadata