ModalBottomSheetLayout crashes when rotating from halfExpanded in landscape to portrait without halfExpanded [266780234]

Fixed

Bug

Status Update

No update yet.

Description

ha...@gmail.com

created issue #1

Jan 26, 2023 06:18PM

Jetpack Compose version: 1.4.0-alpha05

Jetpack Compose component used: compose.material/ModalbottomSheetLayout

Android Studio Build: Electric Eel 2022.1.1 Build #AI-221.6008.13.2211.9477386

Kotlin version: 1.8.0

Seems that the fix in https://issuetracker.google.com/issues/265444789 didn't work fully. When the sheet content is in halfExpanded and is recreated to a screen where it cannot be halfExpanded (height is < 50 % of the screen height) it crashes.

Steps to Reproduce or Code Sample to Reproduce:

Open bottom sheet in landscape, move to halfExpanded
Rotate to portrait
App crashes

val state = rememberModalBottomSheetState(initialValue = ModalBottomSheetValue.Hidden)
ModalBottomSheetLayout(
    sheetState = state,
    modifier = Modifier.fillMaxSize(),
    sheetContent = {
        Box(
            modifier = Modifier
                // Has halfExpanded in landscape, doesn't in portarit
                .fillMaxHeight(if (LocalConfiguration.current.orientation == Configuration.ORIENTATION_LANDSCAPE) 0.75f else 0.25f)
        )
    }
) {
    val scope = rememberCoroutineScope()
    Button(onClick = {
        scope.launch {
            state.show()
        }
    }) {
        Text(text = "Show")
    }
}

Stack trace (if applicable):

java.lang.IllegalStateException: The offset was read before being initialized. Did you access the offset in a phase before layout, like effects or composition?
        at androidx.compose.material.SwipeableV2State.requireOffset(SwipeableV2.kt:208)
        at androidx.compose.material.ModalBottomSheetKt$ModalBottomSheetLayout$1$3.invoke-Bjo55l4(ModalBottomSheet.kt:485)
        at androidx.compose.material.ModalBottomSheetKt$ModalBottomSheetLayout$1$3.invoke(ModalBottomSheet.kt:481)
        at androidx.compose.foundation.layout.OffsetPxModifier$measure$1.invoke(Offset.kt:202)
        at androidx.compose.foundation.layout.OffsetPxModifier$measure$1.invoke(Offset.kt:201)
        at androidx.compose.ui.layout.MeasureScope$layout$1.placeChildren(MeasureScope.kt:70)
        at androidx.compose.ui.node.LayoutModifierNodeCoordinator.placeAt-f8xVGno(LayoutModifierNodeCoordinator.kt:202)
        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:35)
        at androidx.compose.ui.layout.Placeable$PlacementScope.placeRelative(Placeable.kt:434)
        at androidx.compose.ui.layout.Placeable$PlacementScope.placeRelative$default(Placeable.kt:199)
        at androidx.compose.foundation.layout.FillModifier$measure$1.invoke(Size.kt:663)
        at androidx.compose.foundation.layout.FillModifier$measure$1.invoke(Size.kt:662)
        at androidx.compose.ui.layout.MeasureScope$layout$1.placeChildren(MeasureScope.kt:70)
        at androidx.compose.ui.node.LayoutModifierNodeCoordinator.placeAt-f8xVGno(LayoutModifierNodeCoordinator.kt:202)
        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:35)
        at androidx.compose.ui.layout.Placeable$PlacementScope.placeRelative(Placeable.kt:434)
        at androidx.compose.ui.layout.Placeable$PlacementScope.placeRelative$default(Placeable.kt:199)
        at androidx.compose.foundation.layout.SizeModifier$measure$1.invoke(Size.kt:783)
        at androidx.compose.foundation.layout.SizeModifier$measure$1.invoke(Size.kt:782)
        at androidx.compose.ui.layout.MeasureScope$layout$1.placeChildren(MeasureScope.kt:70)
        at androidx.compose.ui.node.LayoutModifierNodeCoordinator.placeAt-f8xVGno(LayoutModifierNodeCoordinator.kt:202)
        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:35)
        at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50(Placeable.kt:445)
        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$placeOuterCoordinator$1.invoke(LayoutNodeLayoutDelegate.kt:451)
        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$placeOuterCoordinator$1.invoke(LayoutNodeLayoutDelegate.kt:445)
        at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2139)
        at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:234)
        at androidx.compose.runtime.snapshots.SnapshotStateObserver$observeReads$1$1.invoke(SnapshotStateObserver.kt:230)
        at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
        at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
        at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
        at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
        at androidx.compose.ui.node.OwnerSnapshotObserver.observeLayoutModifierSnapshotReads$ui_release(OwnerSnapshotObserver.kt:92)
        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeOuterCoordinator-f8xVGno(LayoutNodeLayoutDelegate.kt:445)
        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeAt-f8xVGno(LayoutNodeLayoutDelegate.kt:428)
        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:35)
        at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50(Placeable.kt:445)
        at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50$default(Placeable.kt:223)

Comments

jo...@google.com <jo...@google.com> Feb 6, 2023 02:41PM

Reassigned to jo...@google.com.

jo...@google.com <jo...@google.com> #2Feb 6, 2023 04:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ro...@veeva.com <ro...@veeva.com> #3Feb 10, 2023 10:29AM

This is still happening with the latest compose 1.4.0-alpha06. Any ETA for a proper fix?

jo...@google.com <jo...@google.com> #4Feb 15, 2023 06:54PM

Hi, 1.4.0-alpha06 did not include a fix for this. We are working on the fix and are aiming to include it in one of the next releases.

le...@gmail.com <le...@gmail.com> #5Mar 2, 2023 08:45AM

1.4.0-beta01 and 1.4.0-beta02 are out and the crash is still there. What is delaying the fix for so long?

mi...@lppsa.com <mi...@lppsa.com> #6Mar 3, 2023 08:01AM

Hello, i have also problem with my app in production. Can you give this ticket a higher priority?

kn...@gmail.com <kn...@gmail.com> #7Mar 3, 2023 08:18AM

google please help

ap...@google.com <ap...@google.com> #8Mar 7, 2023 10:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8cfec3ca487c6f0102eeceab5e57939b36162908
Author: Jossi Wolf <jossiwolf@google.com>
Date: Wed Feb 15 22:25:44 2023

Snap opportunistically in Modal Bottom Sheet

We now use the trySnapTo API to attempt to snap immediately, instead
of launching a coroutine that would most likely only run in the next
frame.
Since we rely on the anchor change handler to initialize the
Swipeable state by snapping if no anchor is found for the initial
value, we need to update the offset immediately, not only a frame
later.

Relnote: "Fixed an issue where ModalBottomSheetLayout would crash
in an edge case on orientation change. Layout animations (e.g.
`Modifier.animateContentSize`) in/on the sheet content now work
smoothly."
Test: modalBottomSheet_anchorChangeHandler_missingAnchor
_immediatelySnapsForInitialization
Bug: 266780234

Change-Id: I2f981d892f163254f0282d6874fb860aae5d0992

M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt

https://android-review.googlesource.com/2440691

ro...@veeva.com <ro...@veeva.com> #9Mar 10, 2023 01:10PM

Is the fix from #8 supposed to be included in 1.4.0-rc01? Because I can still reproduce it with this version.

ch...@gmail.com <ch...@gmail.com> #10Mar 12, 2023 12:35AM

In androidx.compose.material3:material3:1.1.0-alpha08, switching screen orientation has been fixed. However, the same problem still occurs when switching to dark mode.

jo...@google.com <jo...@google.com> #11Mar 13, 2023 11:33AM

#9, the fix will be included in the next release.

#10, this issue is about M2's ModalBottomSheetLayout. If you are encountering this issue with another component, can you file a new issue?

jo...@google.com <jo...@google.com> Mar 13, 2023 01:02PM

Marked as fixed.

sk...@gmail.com <sk...@gmail.com> #12Mar 16, 2023 12:49PM

#9, the fix will be included in the next release.

Do you mean the next 1.4 release? Thanks.

ka...@markaz.app <ka...@markaz.app> #13Mar 21, 2023 10:28AM

We are still facing this issue, have this been fixed? If yes, in which version?
we are using 1.4.0-alpha-05.

Message last modified on Mar 21, 2023 10:29AM

pr...@google.com <pr...@google.com> #14Mar 22, 2023 08:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.5.0-alpha01

jo...@google.com <jo...@google.com> #15Mar 22, 2023 08:38PM

This issue has been fixed in 1.5.0-alpha01.

js...@google.com <js...@google.com> #16Apr 12, 2023 11:00AM

Getting reports from users that this may not be fully fixed: https://kotlinlang.slack.com/archives/C04TPPEQKEJ/p1681295724987999

jo...@google.com <jo...@google.com> #17Apr 17, 2023 08:04AM

The issue mentioned on KotlingLang was about BottomSheetScaffold and has been fixed, with the fix included in the next alpha release. b/277774594 to track the release of that fix :)

ka...@gmail.com <ka...@gmail.com> #18Apr 19, 2023 06:29AM

Are there plans to backport this fix into next release of Compose 1.4? (1.4.2)

he...@shortcut.io <he...@shortcut.io> #19Apr 24, 2023 06:49AM

It would be very great if this fix could get in Compose 1.4, as it causes a lot of crashes

jo...@google.com <jo...@google.com> #20Apr 24, 2023 07:40AM

Hello, we will not cherry-pick this fix as it depends on other changes. We understand this is frustrating but would encourage you to update to alpha or wait for the next beta.

ph...@gmail.com <ph...@gmail.com> #21Aug 26, 2024 05:17AM

this error still happening
hi google please help me
androidx-compose-material3 = { group = "androidx.compose.material3", name = "material3", version.ref = "1.0.1" }

Message last modified on Aug 26, 2024 05:20AM

Screenshot 2024-08-26 at 11.46.04 AM.png

335 KB

View

Download