[M2] ModalBottomSheetLayout can be flinged up from the bottom of the screen [266780235]

Fixed

Bug

Status Update

No update yet.

Description

ha...@gmail.com

created issue #1

Jan 26, 2023 06:27PM

Jetpack Compose version: 1.4.0-alpha05
Jetpack Compose component used: compose.material/ModalbottomSheetLayoute
Android Studio Build: Electric Eel 2022.1.1 Build #AI-221.6008.13.2211.9477386
Kotlin version: 1.8.0

Steps to Reproduce or Code Sample to Reproduce:
1. Open a ModalBottomSheetLayout
2. Perform an upwards fling/swipe gesture. The "harder" the fling the more the bottom sheet goes up from the bottom of the screen. See the attached video

Screen_Recording_20230126_192048_My Application.mp4

928 KB

Download

Comments

jo...@google.com <jo...@google.com> #2Feb 6, 2023 03:26PM

Accepted by jo...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024

[M2 text field] Apply background to decoration box

...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.

Fixes:

b/307694651

Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/3046833

ch...@gmail.com <ch...@gmail.com> #3Jun 4, 2023 06:12PM

Any news on this?

ap...@google.com <ap...@google.com> #4Feb 5, 2024 04:52PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e299b64fa3574b44e745173f406bc3b49e1d47f7
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon Nov 27 19:34:32 2023

[M2] Stabilize ModalBottomSheetLayout

Relnote: Material (2) modal bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 266780235, 261409034
Test: Added modalBottomSheet_show_animatesToHalfExpandedFirstAndToExpandedAfter
Change-Id: Ic53f4fe7c7183569cb7322c8f56f571be5316be0

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetStateTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt

https://android-review.googlesource.com/2852687

pr...@google.com <pr...@google.com> #5Feb 21, 2024 07:32PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.7.0-alpha03
androidx.compose.material:material-android:1.7.0-alpha03
androidx.compose.material:material-desktop:1.7.0-alpha03

ha...@nrk.no <ha...@nrk.no> #6Apr 5, 2024 05:39AM

Is this also fixed for material3 ModalBottomSheet? It's an issue there as well on BOM 2024.04.00

jo...@google.com <jo...@google.com> #7Apr 5, 2024 11:28AM

The M2 issue is tracked in this issue, the M3 issue is tracked in b/285847707. It was fixed a while ago but is in 1.3.0-alpha/beta which is not in the BOM yet afaik.

ha...@nrk.no <ha...@nrk.no> #8Apr 5, 2024 11:47AM

Alright, thanks!