HorizontalPager and PagerState don't expose pageCount [266965072]

Fixed

Bug

Status Update

No update yet.

Description

yu...@schimke.ee

created issue #1

Jan 29, 2023 04:13PM

Jetpack Compose version: 1.4.0-alpha05
Jetpack Compose component used: compose foundation

It's not possible to migrate off Accompanist Horizontal Pager to Compose Foundation, because the page count is not exposed as state.

https://github.com/google/horologist/blob/0ba46cee202c84154b4e20db4850d29757c7e776/compose-layout/src/main/java/com/google/android/horologist/compose/pager/PagerScreen.kt#L99

This is needed to implement androidx.wear.compose.material.PageIndicatorState from Wear Compose

Comments

ma...@google.com <ma...@google.com> Jan 30, 2023 09:41AM

Reassigned to le...@google.com.

le...@google.com <le...@google.com> #2Jan 30, 2023 11:15AM

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

yu...@schimke.ee <yu...@schimke.ee> #3Jan 30, 2023 12:14PM

Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.

le...@google.com <le...@google.com> #4Jan 30, 2023 02:08PM

I'll schedule it for the next release. Note that alpha04 is a complete turn-down of the library where all APIs are marked as Deprecated, so you'll also want to start removing your usages of the library.

yu...@schimke.ee <yu...@schimke.ee> #5Jan 30, 2023 06:49PM

Project: platform/frameworks/support
Branch: androidx-main

commit 19ed7e69823a09f3c63f8c8cdf339af8ca1645ab
Author: Alan Viverette <alanv@google.com>
Date: Mon Mar 14 15:18:16 2022

Bump textclassifier for final release and turn-down

Bug: 210509084
Change-Id: Ib8b2386903bb49baa3211f7de7fe1587fdda1483
Test: ./gradlew checkApi

M libraryversions.toml

https://android-review.googlesource.com/2024823

ap...@google.com <ap...@google.com> #6Apr 13, 2023 01:23PM

Marked as fixed.

Bugjuggler: wait until 2022-03-23

ap...@google.com <ap...@google.com> #7Apr 17, 2023 02:00PM

Hi. I've received your bug and will wait until 2022-03-23 00:00 -0400 EDT and then assign the bug to alanv@google.com.

ys...@google.com <ys...@google.com> #8Apr 25, 2023 06:08PM

Is there a replacement or should we just abandon TextClassifier for android older than API Level 26 ?

na...@google.com <na...@google.com> #9May 3, 2023 06:24PM

Abandon. The owning team had no plans to release a replacement library.

na...@google.com <na...@google.com> #10May 10, 2023 07:09PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.5.0-alpha04

[Deleted User] <[Deleted User]> #11Jun 2, 2023 08:03PM

Started using this recently. But running into issues when using key on the HorizontalPager. If an update occurs on the data set the count seems to be getting mismatched? Get an "IndexOutOfBoundsException" when trying to access data set with index for the keys.

le...@google.com <le...@google.com> #12Jun 5, 2023 09:12AM

Hi, could you open another ticket with a reproducible sample? Thank you :D

[Deleted User] <[Deleted User]> #13Jun 5, 2023 09:27PM

Thanks for the reply, will do!