Support transparent indicatorColor in NavigationBarItem [267289987]

Fixed

Feature Request

Status Update

No update yet.

Description

km...@keepersecurity.com

created issue #1

Jan 31, 2023 06:31PM

Jetpack Compose version: 1.2.0

Jetpack Compose component(s) used: NavigationBarItem

Android Studio Build: 2022.1.1 Canary 9

Kotlin version: 1.7.0

Steps to Reproduce or Code Sample to Reproduce:

1. Use NavigationBar with NavigationBarItem
2. Use overridden colors with NavigationBarItem with a transparent/translucent indicatorColor
3. The NavigationBarItem composable overrides the alpha channel of the color such that only solid indicator colors can be used.

It would be really helpful if we could use a transparent/translucent indicatorColor. We'd like to hide the pill color entirely to match approved design. The pill was heavily opposed and so we can't have it visible. But we can't hide the pill without completely copying the NavigationBarItem composable and A LOT of supported code, just to remove the `.copy(alpha = animationProgress) part of the indicator composable.

Can this Composable be modified to either (1) support transparent/translucent indicatorColor values and/or (2) completely hide the indicator composable (pill shape on the selected item).

Stack trace (if applicable):

```
<add stack trace here>
```

Comments

km...@keepersecurity.com <km...@keepersecurity.com> #2Feb 1, 2023 07:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3151736

Message last modified on Feb 3, 2023 08:14PM

si...@google.com <si...@google.com> Feb 8, 2023 09:54PM

Assigned to si...@google.com.

si...@google.com <si...@google.com> Feb 10, 2023 01:20AM

Reassigned to je...@google.com.

ma...@google.com <ma...@google.com> Aug 24, 2023 09:25PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #3Sep 29, 2023 05:36AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 39cd1e9f7579513bde139c17f9c51f9012d56152
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 now with workaround for

https://youtrack.jetbrains.com/issue/KT-62653

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Ic795af8486db48b31633799e06665717d08398db

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3156121

pr...@google.com <pr...@google.com> #4Oct 18, 2023 08:41PM

Project: platform/frameworks/support
Branch: androidx-main

commit c3a06e79cf427aef1cf0ede1bacb463eb89472be
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 /

r.android.com/3156121 but now with
moving to project(":annotation:annotation") in commonMain as due to

https://youtrack.jetbrains.com/issue/KT-62653 we cannot depend on
project in one source set and prebuilt in the other.

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: I7f2a1bddbe79ab5e920cdb01ca6a428950a8c2c3

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M busytown/androidx_multiplatform_mac_host_tests_arm64.sh
M camera/integration-tests/avsynctestapp/build.gradle
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt
M test/uiautomator/integration-tests/testapp/build.gradle
M wear/compose/integration-tests/navigation/build.gradle

https://android-review.googlesource.com/3156423

Issue 267289987