java.lang.VerifyError: Verifier rejected class androidx.compose.ui.graphics.colorspace.o: void androidx.compose.ui.graphics.colorspace.o.<init>(java.lang.Object) failed to verify: void androidx.compose.ui.graphics.colorspace.o.<init>(java.lang.Object): [0x0] cannot access instance field java.lang.Object androidx.compose.ui.graphics.colorspace.n.a from object of type Precise Reference: androidx.compose.ui.graphics.colorspace.o [267463817]

Verified

Bug

Status Update

No update yet.

Description

bl...@lyft.com

created issue #1

Feb 1, 2023 08:52PM

We are seeing this crash in our signed release builds. Dev builds where -dontoptimize is enabled work fine.

We are using Kotlin 1.7.10, and are able to repro this and similar "Verifier rejected class ... .<init>(...)" crashes in different classes across our repo using R8 4.0.48 as well as HEAD (6dc561aa43a09737a114a0b233d9476b4ec902e5).

Examples:

java.lang.VerifyError: Verifier rejected class androidx.compose.ui.graphics.colorspace.o: void androidx.compose.ui.graphics.colorspace.o.<init>(java.lang.Object) failed to verify: void androidx.compose.ui.graphics.colorspace.o.<init>(java.lang.Object): [0x0] cannot access instance field java.lang.Object androidx.compose.ui.graphics.colorspace.n.a from object of type Precise Reference: androidx.compose.ui.graphics.colorspace.o
	at com.lyft.android.experiments.b1.<init>(SourceFile:15)
	at com.lyft.android.c$a.get(SourceFile:3814)
	at gy1.a.get(SourceFile:14)

java.lang.VerifyError: Verifier rejected class com.lyft.android.camera.photo.g: void com.lyft.android.camera.photo.g.<init>(int, java.lang.Object) failed to verify: void com.lyft.android.camera.photo.g.<init>(int, java.lang.Object): [0x0] cannot access instance field int com.lyft.android.camera.photo.i.a from object of type Precise Reference: com.lyft.android.camera.photo.g
	at a71.c.<init>(SourceFile:50)
	at a71.n$a.b(SourceFile:65)
	at com.lyft.android.c$a.get(SourceFile:4310)

Comments

ch...@google.com <ch...@google.com> #2Feb 2, 2023 07:16AM

Reassigned to ch...@google.com.

The snapshot shows that it's coming from calling getFiles on the FileCollection returned by the scoped artifacts (here).

I think the issue may be due to how we build these file collection and how we filter things from it to list of Directory or REgularFile.

ch...@google.com <ch...@google.com> #3Feb 6, 2023 12:02PM

Actually these transforms are only ~40% of the time spend in there, but it's still a hot spot that we should resolve by not using a FileCollection

bl...@lyft.com <bl...@lyft.com> #4Feb 7, 2023 05:19AM

xav@ could you assign this bug to someone to make sure it gets fixed?

ch...@google.com <ch...@google.com> #5Feb 7, 2023 02:52PM

Jerome will do that for you :)

bl...@lyft.com <bl...@lyft.com> #6Feb 7, 2023 07:27PM

Bingran, can you have a look at this asap. thx !

ap...@google.com <ap...@google.com> #7Feb 8, 2023 09:51AM

To make sure I analyze the "buildOnServer-7.5-rc-2-2022-07-01-shutdown.snapshot" correctly, I attached a screenshot of how I find the concerning point. From the picture, the MergeGeneratedProguardFilesCreationAction takes 1924ms. Is that the right way to check your snapshot file? If so, what is the expected time for that creation action in a config cached build?

ap...@google.com <ap...@google.com> #8Feb 9, 2023 10:27AM

I think you missed adding an attachment.

ap...@google.com <ap...@google.com> #9Feb 9, 2023 10:27AM

oops, here it is =)

ap...@google.com <ap...@google.com> #10Feb 9, 2023 10:30AM

From discussions with xav@ that time should almost be non-existent during the run when the configuration cache kicks in.

ap...@google.com <ap...@google.com> #11Feb 9, 2023 10:30AM

I checked out androidx-main, is that the right one? There is no gradlew file under that directory.

bingran@bingran-linux-west:~/androidx-main/tools$ ls
external  fetch_artifact  metalava  repohooks

And have you ever tried building androidx with the dev version of AGP(the one built from studio-main)?

ch...@google.com <ch...@google.com> #12Feb 9, 2023 10:34AM

Verified by ch...@google.com.

I checked out androidx-main, is that the right one? There is no gradlew file under that directory.

Yes, aosp androidx-main is the repo. You'll want to use frameworks/support/gradlew thats the main repo all the work is done.

And have you ever tried building androidx with the dev version of AGP(the one built from studio-main)?

Yes we have a script for that https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:busytown/impl/build-studio-and-androidx.sh

namely you can set a number of variables to use the latest AGP (https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:busytown/impl/build-studio-and-androidx.sh;l=92):

GRADLE_PLUGIN_VERSION
LINT_VERSION
GRADLE_PLUGIN_REPO

and then run frameworks/support/gradlew

IssueTracker