java.lang.VerifyError: Verifier rejected class androidx.compose.ui.graphics.colorspace.o: void androidx.compose.ui.graphics.colorspace.o.<init>(java.lang.Object) failed to verify: void androidx.compose.ui.graphics.colorspace.o.<init>(java.lang.Object): [0x0] cannot access instance field java.lang.Object androidx.compose.ui.graphics.colorspace.n.a from object of type Precise Reference: androidx.compose.ui.graphics.colorspace.o [267463817]

Verified

Bug

Status Update

No update yet.

Description

bl...@lyft.com

created issue #1

Feb 1, 2023 08:52PM

We are seeing this crash in our signed release builds. Dev builds where -dontoptimize is enabled work fine.

We are using Kotlin 1.7.10, and are able to repro this and similar "Verifier rejected class ... .<init>(...)" crashes in different classes across our repo using R8 4.0.48 as well as HEAD (6dc561aa43a09737a114a0b233d9476b4ec902e5).

Examples:

java.lang.VerifyError: Verifier rejected class androidx.compose.ui.graphics.colorspace.o: void androidx.compose.ui.graphics.colorspace.o.<init>(java.lang.Object) failed to verify: void androidx.compose.ui.graphics.colorspace.o.<init>(java.lang.Object): [0x0] cannot access instance field java.lang.Object androidx.compose.ui.graphics.colorspace.n.a from object of type Precise Reference: androidx.compose.ui.graphics.colorspace.o
	at com.lyft.android.experiments.b1.<init>(SourceFile:15)
	at com.lyft.android.c$a.get(SourceFile:3814)
	at gy1.a.get(SourceFile:14)

java.lang.VerifyError: Verifier rejected class com.lyft.android.camera.photo.g: void com.lyft.android.camera.photo.g.<init>(int, java.lang.Object) failed to verify: void com.lyft.android.camera.photo.g.<init>(int, java.lang.Object): [0x0] cannot access instance field int com.lyft.android.camera.photo.i.a from object of type Precise Reference: com.lyft.android.camera.photo.g
	at a71.c.<init>(SourceFile:50)
	at a71.n$a.b(SourceFile:65)
	at com.lyft.android.c$a.get(SourceFile:4310)

Comments

ch...@google.com <ch...@google.com> #2Feb 2, 2023 07:16AM

Reassigned to ch...@google.com.

Thanks for reporting this. Would it be possible for you to share a zip dump of the inputs to R8, which includes the class files, keep rules, etc. of the app? This should allow us to reproduce and diagnose the issue. You can share this privately with christofferqa@google.com or sgjesse@google.com.

You can generate a dump by building with:

./gradlew assembleRelease -Dcom.android.tools.r8.dumpinputtodirectory=/path/to/dumps/ --no-daemon

ch...@google.com <ch...@google.com> #3Feb 6, 2023 12:02PM

Thanks for sharing the dump. I was able to reproduce the issue and will start diagnosing what is causing this.

bl...@lyft.com <bl...@lyft.com> #4Feb 7, 2023 05:19AM

Awesome! Let me know if there are any patches that I can import and test against our repo.

ch...@google.com <ch...@google.com> #5Feb 7, 2023 02:52PM

This should be fixed with https://r8-review.googlesource.com/c/r8/+/75680. With this change, dex2oat no longer seems to complain about verification errors, but it would be great if you could confirm that the app works. I'll look into backporting this to relevant release branches when this has landed.

bl...@lyft.com <bl...@lyft.com> #6Feb 7, 2023 07:27PM

I pulled this patch in and can confirm that our apk now works. Thanks for the quick turn around!

ap...@google.com <ap...@google.com> #7Feb 8, 2023 09:51AM

Project: r8
Branch: main

commit 9c9bdc44e808cf2443b5ae49ea6a8941414e747c
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Feb 08 08:10:51 2023

Avoid double-lens application to field instructions in backend

Bug:

b/267463817

Change-Id: I0b5235619c0dc3773b82d6032a5755006c01d4cb

M src/main/java/com/android/tools/r8/dex/DexOutputBuffer.java
M src/main/java/com/android/tools/r8/dex/FileWriter.java
M src/main/java/com/android/tools/r8/dex/code/DexCheckCast.java
M src/main/java/com/android/tools/r8/dex/code/DexConstClass.java
M src/main/java/com/android/tools/r8/dex/code/DexConstMethodHandle.java
M src/main/java/com/android/tools/r8/dex/code/DexConstMethodType.java
M src/main/java/com/android/tools/r8/dex/code/DexConstString.java
M src/main/java/com/android/tools/r8/dex/code/DexFillArrayDataPayload.java
M src/main/java/com/android/tools/r8/dex/code/DexFilledNewArray.java
M src/main/java/com/android/tools/r8/dex/code/DexFilledNewArrayRange.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat10t.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat10x.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat11n.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat11x.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat12x.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat20t.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat21h.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat21s.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat21t.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat22b.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat22s.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat22t.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat22x.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat23x.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat30t.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat31c.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat31i.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat31t.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat32x.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat45cc.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat4rcc.java
M src/main/java/com/android/tools/r8/dex/code/DexFormat51l.java
M src/main/java/com/android/tools/r8/dex/code/DexIgetOrIput.java
M src/main/java/com/android/tools/r8/dex/code/DexInitClass.java
M src/main/java/com/android/tools/r8/dex/code/DexInstanceOf.java
M src/main/java/com/android/tools/r8/dex/code/DexInstruction.java
M src/main/java/com/android/tools/r8/dex/code/DexInvokeCustom.java
M src/main/java/com/android/tools/r8/dex/code/DexInvokeCustomRange.java
M src/main/java/com/android/tools/r8/dex/code/DexInvokeMethod.java
M src/main/java/com/android/tools/r8/dex/code/DexInvokeMethodRange.java
M src/main/java/com/android/tools/r8/dex/code/DexItemBasedConstString.java
M src/main/java/com/android/tools/r8/dex/code/DexNewArray.java
M src/main/java/com/android/tools/r8/dex/code/DexNewInstance.java
M src/main/java/com/android/tools/r8/dex/code/DexNewUnboxedEnumInstance.java
M src/main/java/com/android/tools/r8/dex/code/DexPackedSwitchPayload.java
M src/main/java/com/android/tools/r8/dex/code/DexRecordFieldValues.java
M src/main/java/com/android/tools/r8/dex/code/DexSgetOrSput.java
M src/main/java/com/android/tools/r8/dex/code/DexSparseSwitchPayload.java
M src/main/java/com/android/tools/r8/graph/DefaultInstanceInitializerCode.java
M src/main/java/com/android/tools/r8/graph/DexCode.java
M src/main/java/com/android/tools/r8/graph/DexWritableCode.java
M src/main/java/com/android/tools/r8/graph/NestedGraphLens.java
M src/main/java/com/android/tools/r8/graph/ThrowExceptionCode.java
M src/main/java/com/android/tools/r8/graph/ThrowNullCode.java
M src/main/java/com/android/tools/r8/horizontalclassmerging/code/SyntheticInitializerConverter.java

https://r8-review.googlesource.com/75680

ap...@google.com <ap...@google.com> #8Feb 9, 2023 10:27AM

Project: r8
Branch: 4.0

commit 2fc27f8cef33c22525c585e5c65bf3d67a18755a
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:19:09 2023

Version 4.0.53

Bug:

b/267990059

Bug:

b/267463817

Change-Id: I62f98b9723358310ade7f2bd5f8e589fa91c8ab6

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/75769

ap...@google.com <ap...@google.com> #9Feb 9, 2023 10:27AM

Project: r8
Branch: 4.0

commit 88dc0fb1128b5734c97809ebb9d7b1c954b9966e
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:17:56 2023

Avoid double-lens application to field instructions in backend

Bug:

b/267463817

https://r8-review.googlesource.com/75706

ap...@google.com <ap...@google.com> #10Feb 9, 2023 10:30AM

Project: r8
Branch: 8.0

commit 376af144cf327f0f2b0a2de0a38939a59216a08d
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:25:18 2023

Version 8.0.29

Bug:

b/267990059

Bug:

b/267463817

Change-Id: I994d406bae7514482ffdf2ef10f092b5a96cc328

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/75776

ap...@google.com <ap...@google.com> #11Feb 9, 2023 10:30AM

Project: r8
Branch: 8.0

commit ecb0cace90beb30e2ca7f4e4c3a324584a4c102e
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Feb 09 11:24:15 2023

Avoid double-lens application to field instructions in backend

Bug:

b/267463817

https://r8-review.googlesource.com/75775

ch...@google.com <ch...@google.com> #12Feb 9, 2023 10:34AM

Verified by ch...@google.com.

This should now be fixed in R8 versions 4.0.53 and 8.0.29 - and next week in 8.1.19-dev.

IssueTracker