Pager: Allow option to smooth animate to items [267744105]

Fixed

Feature Request

Status Update

No update yet.

Description

ri...@google.com

created issue #1

Feb 3, 2023 12:45PM

Jetpack Compose version: 1.4.0-alpha05

Jetpack Compose component(s) used: PagerState

The function animateScrollToPage appears buggy at first in how it scrolls to a page, it first snaps to a nearby item and then smoothly scrolls. I understand this is by design, but I think this should be reconsidered.

Only after thinking I found a bug, did I see this disclaimer on the documentation:

“If the page is too far away from currentPage we will not compose all pages in the way. We will pre-jump to a nearer page, compose and animate the rest of the pages until page.”

This looks like a bug when this is visibly animating to a page. Can this be reconsidered to animate through all the pages instead?

Comments

ma...@google.com <ma...@google.com> Feb 3, 2023 01:57PM

Reassigned to le...@google.com.

mg...@google.com <mg...@google.com> Apr 27, 2023 08:34PM

Reassigned to mg...@google.com.

an...@google.com <an...@google.com> #2May 24, 2023 04:55PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

ap...@google.com <ap...@google.com> #3Aug 17, 2023 04:41PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

ap...@google.com <ap...@google.com> #4Sep 12, 2023 02:30PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit b422ec96758469115c133a779a3ab3293fd8a9e4
Author: Levi Albuquerque <levima@google.com>
Date: Wed Aug 23 18:13:38 2023

Update PagerState to allow customization of animated scroll.

Introduced snapToPage and updateTargetPage in a ScrollScope, these are the last pieces necessary to allowing customization of animated scroll through PagerState.scroll.

Relnote: Introduced updateCurrentPage and updateTargetPage in ScrollScope, these are the last pieces necessary to allowing customization of animated scroll through PagerState.scroll.

Fixes: 267744105
Fixes: 243786897
Test: N/A
Change-Id: I9cad5789ef0d48da46b0e38fbc04bd9ac740861e

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/PagerSamples.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/pager/PagerStateNonGestureScrollingTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/pager/PagerStateTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerLazyAnimateScrollScope.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerState.kt

https://android-review.googlesource.com/2723578

ap...@google.com <ap...@google.com> #5Sep 12, 2023 02:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6cc86976b13b30e411464fd6dafe03182fce88b3
Author: Levi Albuquerque <levima@google.com>
Date: Wed Aug 23 16:50:20 2023

Refactor LazyLayoutAnimateScrollScope.

Refactor LazyLayoutAnimateScrollScope, an API to allow running scroll customizations in Scrollable layouts.

Relnote: N/A
Bug: 267744105
Fixes: 243786897
Test: N/A

Change-Id: I06653cf8482b1ee56a99cec22b98ba5a53ef9e11

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyListAnimateScrollScope.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGridAnimateScrollScope.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/layout/LazyAnimateScroll.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/staggeredgrid/LazyStaggeredGridAnimateScrollScope.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerState.kt

https://android-review.googlesource.com/2693627

na...@google.com <na...@google.com> #6Sep 20, 2023 07:16PM