Allow adding spacing between rows in a FlowRow and columns in a FlowColumn [268365538]

Fixed

Feature Request

Status Update

No update yet.

Description

va...@google.com

created issue #1

Feb 8, 2023 07:30PM

Currently, there isn't an option to specify spacing between the multiple resulting rows of a FlowRow or multiple resulting columns of a FlowColumn.

One partial workaround would be to add that padding to each element, but that padding will apply to all rows/columns, even the last one (which may not be desirable).

Comments

ti...@google.com <ti...@google.com> Feb 10, 2023 03:31AM

Assigned to uo...@google.com.

uo...@google.com <uo...@google.com> #2Feb 10, 2023 11:40AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

uo...@google.com <uo...@google.com> Mar 8, 2023 08:12PM

Accepted by uo...@google.com.

ra...@gmail.com <ra...@gmail.com> #3Mar 26, 2023 08:10AM

this has been a very bad decision, in a chip container the last row should not have that bottom padding. now i can't align the layout correctly. Please, add functionality to give spacing only between rows and columns.It also looks strange to have to use spaceby for a horizontal axis and use padding bottom for the vertical axis from a child encoder. It's not consistent and it's confusing, besides not getting the expected result which is giving space only between rows and columns.

Message last modified on Mar 26, 2023 08:17AM

kh...@gmail.com <kh...@gmail.com> #4Mar 27, 2023 12:52AM

I agree with the previous message, and wanted to add that in LazyVerticalGrid/LazyHorizontalGrid it is possible to have horizontalArrangement and verticalArrangement, so it feels weird to no have both of them here too. Again, not consistent.

uo...@google.com <uo...@google.com> Mar 27, 2023 08:06PM

Status: In Progress (Accepted) (reopened)

ap...@google.com <ap...@google.com> #5Mar 27, 2023 08:07PM

Project: platform/frameworks/support
Branch: androidx-main

commit b347a7f5ed2ab16832d56c5c715e0c78cc3f7ef2
Author: Faithful Uchenna Okoye <uokoye@google.com>
Date: Wed Mar 08 20:09:36 2023

Add support for Cross Axis Arrangement and Spacing to Flow Row and FlowColumn

Adds support for verticalArrangement in FlowRow and horizontalArrangement in
FlowColumn, which provides spacing and arrangement options for the cross axis.

Test: Tested manually and automated
Bug: 268365538
Relnote: "Adds support for cross axis spacing/arrangement using the
verticalArrangement in FlowRow and horizontalArrangement in FlowColumn.
We also remove the top-level verticalAlignment and horizontalAlignment in FlowRow/FlowColumn.
Developers can use Modifier.align instead. This reduces confusion between the naming conventions of
verticalAlignment and verticalArrangement."

Change-Id: I87b60b6bb09586d9126b9494e998be0710df3b62

M compose/foundation/foundation-layout/api/public_plus_experimental_current.txt
M compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/FlowColumnSample.kt
M compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/FlowRowSample.kt
M compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/FlowRowColumnTest.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/FlowLayout.kt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/ChipSamples.kt

https://android-review.googlesource.com/2478295

uo...@google.com <uo...@google.com> #6Mar 27, 2023 08:14PM

Marked as fixed.

Thanks for the feedback. As the API is experimental, we are still ironing out the final API details. Your feedback is very welcome.

We have added horizontalArrangement and verticalArrangement to FlowRow/FlowColumn, and should become available in the next alpha release.

na...@google.com <na...@google.com> #7Apr 5, 2023 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation-layout:1.5.0-alpha02
androidx.compose.material:material:1.5.0-alpha02