Status Update
Comments
ti...@google.com <ti...@google.com>
uo...@google.com <uo...@google.com> #2
Thanks for creating this, Alex. During the design document discussion, we decided to punt crossAxisArrangement as we felt there is not enough need for this. It provides support for spaceAround, spaceBy and many other arrangement features. It is an easy addition if needed, as the logic is already in place.
However, it would be ideal to make the decision early to add this feature as it will require an API change in the future.
As a workaround, the user can create a bottom padding on each item, which will automatically create this separation. Like you mentioned, this would also mean the last row will also have this padding.
I will bring this up to @Matvei and others on the team to discuss if crossAxisArrangement should be reprioritized.
uo...@google.com <uo...@google.com>
ra...@gmail.com <ra...@gmail.com> #3
this has been a very bad decision, in a chip container the last row should not have that bottom padding. now i can't align the layout correctly. Please, add functionality to give spacing only between rows and columns.It also looks strange to have to use spaceby for a horizontal axis and use padding bottom for the vertical axis from a child encoder. It's not consistent and it's confusing, besides not getting the expected result which is giving space only between rows and columns.
kh...@gmail.com <kh...@gmail.com> #4
I agree with the previous message, and wanted to add that in LazyVerticalGrid/LazyHorizontalGrid it is possible to have horizontalArrangement and verticalArrangement, so it feels weird to no have both of them here too. Again, not consistent.
uo...@google.com <uo...@google.com>
ap...@google.com <ap...@google.com> #5
Branch: androidx-main
commit b347a7f5ed2ab16832d56c5c715e0c78cc3f7ef2
Author: Faithful Uchenna Okoye <uokoye@google.com>
Date: Wed Mar 08 20:09:36 2023
Add support for Cross Axis Arrangement and Spacing to Flow Row and FlowColumn
Adds support for verticalArrangement in FlowRow and horizontalArrangement in
FlowColumn, which provides spacing and arrangement options for the cross axis.
Test: Tested manually and automated
Bug: 268365538
Relnote: "Adds support for cross axis spacing/arrangement using the
verticalArrangement in FlowRow and horizontalArrangement in FlowColumn.
We also remove the top-level verticalAlignment and horizontalAlignment in FlowRow/FlowColumn.
Developers can use Modifier.align instead. This reduces confusion between the naming conventions of
verticalAlignment and verticalArrangement."
Change-Id: I87b60b6bb09586d9126b9494e998be0710df3b62
M compose/foundation/foundation-layout/api/public_plus_experimental_current.txt
M compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/FlowColumnSample.kt
M compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/FlowRowSample.kt
M compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/FlowRowColumnTest.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/FlowLayout.kt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/ChipSamples.kt
uo...@google.com <uo...@google.com> #6
Thanks for the feedback. As the API is experimental, we are still ironing out the final API details. Your feedback is very welcome.
We have added horizontalArrangement and verticalArrangement to FlowRow/FlowColumn, and should become available in the next alpha release.
na...@google.com <na...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation-layout:1.5.0-alpha02
androidx.compose.material:material:1.5.0-alpha02
Description
Currently, there isn't an option to specify spacing between the multiple resulting rows of a
FlowRow
or multiple resulting columns of aFlowColumn
.One partial workaround would be to add that padding to each element, but that padding will apply to all rows/columns, even the last one (which may not be desirable).