M3 ModalBottomSheet covers keyboard [268380384]

Fixed

Bug

Status Update

No update yet.

Description

sk...@gmail.com

created issue #1

Feb 8, 2023 10:39PM

Jetpack Compose version: M3 1.1-alpha6
Jetpack Compose component used: ModalBottomSheet
Android Studio Build: IC-231.6471.13
Kotlin version: 1.8.10

Steps to Reproduce or Code Sample to Reproduce:

var b by remember { mutableStateOf(false) }
OutlinedButton(
	onClick = { b = true },
) {
	Text("Demo")
}
if (b) {
	val state = rememberSheetState()
	ModalBottomSheet(
		onDismissRequest = { b = false },
		sheetState = state,
	) {
		var t by remember { mutableStateOf("") }
		OutlinedTextField(t, { t = it })
	}
}

Focus the text field.

The keyboards gets opened behind.

photo_2023-02-08 23.38.18.jpeg

46 KB

View

Download

Comments

ma...@google.com <ma...@google.com> Feb 8, 2023 10:50PM

Reassigned to se...@google.com.

ma...@gmail.com <ma...@gmail.com> #2Feb 9, 2023 09:03AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

jo...@google.com <jo...@google.com> #3Feb 9, 2023 09:14AM

Hi #1, can you please provide a full repro with the entire setup? A zip or git repo would be best!

se...@google.com <se...@google.com> Feb 10, 2023 02:59PM

Reassigned to ma...@google.com.

ma...@gmail.com <ma...@gmail.com> #4Feb 23, 2023 07:28PM

I see this is not fixed in alpha07, let me know if you need a repo for this.

se...@google.com <se...@google.com> Feb 24, 2023 01:00PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> #5Feb 24, 2023 07:08PM

This seems to be a bug with the underlying popup functionality. Filed a bug to raise this which can be tracked here: https://issuetracker.google.com/270713270

se...@google.com <se...@google.com> Mar 13, 2023 12:37PM

Accepted by se...@google.com.

de...@gmail.com <de...@gmail.com> #6Apr 6, 2023 07:35PM

Any ETA? And what is ticket https://issuetracker.google.com/issues/276339374 and why is it blocking this?

se...@google.com <se...@google.com> #7Apr 10, 2023 04:03PM

I have updated the ticket linked to be public. It is a tracker for migrating the internal popup functionality to a custom window view for easier access to window flags.

se...@google.com <se...@google.com> #8Apr 12, 2023 12:47PM

Interestingly, upon investigation this is only an issue on APIs above 29. Regardless of using popup or a generic android view. It seems to be documented here: https://issuetracker.google.com/262140644

continuing to investigate but the solution unfortunately does not seem so straight forward.

sk...@gmail.com <sk...@gmail.com> #9Apr 12, 2023 03:59PM

I thought that https://android-review.googlesource.com/c/platform/frameworks/support/+/2515955 will fix this, won't it? DialogWindowProvider could be set on that view, couldn't it? Or how is it related to b/262140644?

se...@google.com <se...@google.com> #10Apr 12, 2023 07:07PM

I think it's possibly related in that the same use case: Using compose text fields on new windows appears to have the same effect whether it be a PopupWindow, an AbstractComposeView or in their case DialogFragment. So it makes me suspicious that this may be an issue with TextField instead of the windowing logic. The change you linked moves the BottomSheet to a custom view instead of the UI popup but does not alone fix this bug.

se...@google.com <se...@google.com> #11Apr 19, 2023 04:55PM

This issue which extends to any custom windows seems to have been resolved with: https://issuetracker.google.com/262140644

Waiting on that change to land to proceed on this issue.

ja...@gmail.com <ja...@gmail.com> #12Apr 19, 2023 07:22PM

https://issuetracker.google.com/262140644 seems to make the keyboard show now, but the behavior with imePadding does not seem to work. So the keyboard now covers up the modal bottom sheet, and imePadding has no effect.

de...@gmail.com <de...@gmail.com> #13Apr 20, 2023 02:58PM

For me the modal bottom sheet works now. The only bug is, that the cursor drag indicator is shown above the cursor instead of below.

ap...@google.com <ap...@google.com> #14Apr 20, 2023 03:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7545cec3617ab5d1ea83d66822bc094e7f03c562
Author: José Figueroa Santos <serniebanders@google.com>
Date: Wed Apr 19 16:04:18 2023

[Material3][gradle] Update compose dependencies to 1.4.2

Upgrade needed to intake the following bug fix:

b/262140644

, which resolves issue of new windows not calling IME keyboard.

Bug: 268380384
Bug: 272483584
RelNote: ModalBottomSheet now can display IME keyboard
Test: Manual
Change-Id: Idc5082008acb547cac2100a69cab4be7db85f50f

M compose/material3/material3/build.gradle
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt

https://android-review.googlesource.com/2548352

se...@google.com <se...@google.com> Apr 20, 2023 03:01PM

Marked as fixed.

am...@gmail.com <am...@gmail.com> #15May 7, 2023 06:23AM

hi, the issue was fixed on version v1.4.2 BUT appears again on version: 1.5.0-alpha03

ju...@google.com <ju...@google.com> #16May 24, 2023 07:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3-android:1.2.0-alpha02

ru...@gmail.com <ru...@gmail.com> #17Feb 1, 2024 10:28AM

Comment has been deleted.

Message last modified on Feb 1, 2024 10:30AM

da...@gmail.com <da...@gmail.com> #18Jul 19, 2024 01:46PM

I am still experiencing issues with the imePadding not working and the keybaord still covers the BottomSheet content. Has there been any fix found for this?