Fixed
Status Update
No update yet.
Comments
pi...@outlook.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt - M
compose/foundation/foundation/api/restricted_current.txt - M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt - M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt - M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt - M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
jo...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06androidx.compose.foundation:foundation-android:1.8.0-alpha06androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
se...@google.com
se...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 5621ff29f7c4d03bda2315bfa3d0a6314df85728
Author: Jossi Wolf <jossiwolf@google.com>
Date: Fri Feb 10 11:12:00 2023
Fix ModalBottomSheet's HalfExpanded anchor offset
We used the `sheetSize` to calculate the HalfExpanded offset instead of the screen height.
Test: Updated modalBottomSheet_defaultStateForLargeContentIsHalfExpanded
Relnote: Fixed an issue where `ModalBottomSheet`'s `HalfExpanded` state was calculated incorrectly and the sheet would appear to be floating.
Bug: 268411386
Change-Id: I45e84ba00263f4bea61a3abac54bf05a6494bce8
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
https://android-review.googlesource.com/2430112
Branch: androidx-main
commit 5621ff29f7c4d03bda2315bfa3d0a6314df85728
Author: Jossi Wolf <jossiwolf@google.com>
Date: Fri Feb 10 11:12:00 2023
Fix ModalBottomSheet's HalfExpanded anchor offset
We used the `sheetSize` to calculate the HalfExpanded offset instead of the screen height.
Test: Updated modalBottomSheet_defaultStateForLargeContentIsHalfExpanded
Relnote: Fixed an issue where `ModalBottomSheet`'s `HalfExpanded` state was calculated incorrectly and the sheet would appear to be floating.
Bug: 268411386
Change-Id: I45e84ba00263f4bea61a3abac54bf05a6494bce8
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.1.0-alpha08
Description
Jetpack Compose component used: Modal Bottom Sheet/Material 3
Android Studio Build: Giraffe 2022.3.1 Canary 3 / #AI-223.7571.182.2231.9532861
Kotlin version: 1.8.10
Steps to Reproduce or Code Sample to Reproduce:
1. Create a Jetpack compose app
2. Add material 3 dependency
3. Create a modal bottom sheet with 5 items
4. See output
As attached in the screenshots, the new modal bottom sheet bugs when using 5 items. All of those buttons are a ListItem.