Fixed
Status Update
No update yet.
Comments
ma...@google.com
sg...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e40004b9e772b5e4e66a8dcdc3d2e2a1628108ad
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Mar 21 14:39:09 2023
[M3][BottomSheetScaffold] Adds Hidden state boolean flag to sheet state.
This enables standardBottomSheet to implement a fully Hidden state should the user choose to.
Additionally adds documentation to SheetState.requireOffset(), and updates BottomSheetDefaults.MinimizedShape -> BottomSheetDefaults.HiddenShape
Bug: 274463511
Bug: 273870234
Test: Tests updated Hidden functionality for BottomSheetScaffold
Test: Preserves existing unit tests where Hidden state does not exist
RelNote: SheetState now has optional skipHiddenState parameter
RelNote: rememberStandardBottomSheetState now has optional skipHiddenState parameter
RelNote: BottomSheetScaffold now has a defined Hidden anchor, though it is disabled by default
RelNote: SheetState.requireOffset documentation has been updated
RelNote: BottomSheetDefaults.MinimizedShape has been renamed as BottomSheetDefaults.HiddenShape
Change-Id: I839f464c556eafb1b6fd823134da46943475919d
M compose/material3/material3/api/public_plus_experimental_1.1.0-beta01.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/BottomSheetScaffoldTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/BottomSheetScaffold.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Strings.kt
M compose/material3/material3/src/desktopMain/kotlin/androidx/compose/material3/Strings.desktop.kt
https://android-review.googlesource.com/2500395
Branch: androidx-main
commit e40004b9e772b5e4e66a8dcdc3d2e2a1628108ad
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Mar 21 14:39:09 2023
[M3][BottomSheetScaffold] Adds Hidden state boolean flag to sheet state.
This enables standardBottomSheet to implement a fully Hidden state should the user choose to.
Additionally adds documentation to SheetState.requireOffset(), and updates BottomSheetDefaults.MinimizedShape -> BottomSheetDefaults.HiddenShape
Bug: 274463511
Bug: 273870234
Test: Tests updated Hidden functionality for BottomSheetScaffold
Test: Preserves existing unit tests where Hidden state does not exist
RelNote: SheetState now has optional skipHiddenState parameter
RelNote: rememberStandardBottomSheetState now has optional skipHiddenState parameter
RelNote: BottomSheetScaffold now has a defined Hidden anchor, though it is disabled by default
RelNote: SheetState.requireOffset documentation has been updated
RelNote: BottomSheetDefaults.MinimizedShape has been renamed as BottomSheetDefaults.HiddenShape
Change-Id: I839f464c556eafb1b6fd823134da46943475919d
M compose/material3/material3/api/public_plus_experimental_1.1.0-beta01.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/BottomSheetScaffoldTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/BottomSheetScaffold.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Strings.kt
M compose/material3/material3/src/desktopMain/kotlin/androidx/compose/material3/Strings.desktop.kt
na...@google.com
Resolved as of next release. Please note the default behavior for BottomSheetScaffold will still be to not allow Hidden value, but this can be overriden with a new flag for the State object. This is because StandardBottomSheet by design should generally coexist with the UI, in a Partially or fully expanded state.
Description
The selectedDateMillis setter is internal. So it isn't possible to overrite the selected date.
More info (my message on
Why is it only possible to set a timestamp initially and not overwrite it afterwards? If I use a date picker dialoge and have a cancel button there, then I do not use the selected date, but as soon as the user opens the picker again, the discarded date is still selected. Or should I always recreate the entire pickerstate, but that can't be it...?