Popback to specific route with a default value set to null doesn't work. [269302500]

Fixed

Bug

Status Update

No update yet.

Description

hu...@lunabee.com

created issue #1

Feb 15, 2023 04:32PM

Component used: Navigation Version used: 2.6.0-alpha05 Devices/Android versions reproduced on: all

Hi, If we have a NavHost like this:

val route = "home?opt={argOpt}"
NavHost(navController = navController, startDestination = route) {
composable(
    route = route,
    arguments = listOf(
       navArgument("opt") {
          type = NavType.StringType
          nullable = true
          defaultValue = null
       },
     ),
  )
}

The following methods don't work:

navController.getBackStackEntry("home") // or "home?" or "home?opt=" <- Lead to crash
navController.popBackStack("home", false) } // or "home?" or "home?opt=" <- Ignoring popBackStack to route home as it was not found on the current back stack

However, if we put a default value different than null, it's working.

MainActivity.kt

2.2 KB

Download

Enregistrement de l’écran 2023-02-15 à 17.28.58.mov

225 KB

Download

Comments

cl...@google.com <cl...@google.com> Feb 16, 2023 12:15AM

Assigned to cl...@google.com.

ap...@google.com <ap...@google.com> #2Feb 22, 2023 06:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3ab47ff262bdf93fcc60ef04dd8f03f639385c66
Author: Clara Fok <clarafok@google.com>
Date: Wed Feb 15 16:11:54 2023

Add navigation APIs with route support for nullable args

APIs such as getBackStackEntry, popBackStack, clearBackStack that takes route can now support nullable arguments and nullable query params

Test: ./gradlew navigation:navigation-runtime:cC
Bug: 269302500
Relnote: "APIs such as getBackStackEntry, popBackStack, clearBackStack that takes route can now support nullable arguments and nullable query params"
Change-Id: I222940d306f94c737600eb0381228c7594808bfa

M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt

https://android-review.googlesource.com/2439277

cl...@google.com <cl...@google.com> #3Feb 22, 2023 07:06PM

Marked as fixed.

This has been fixed internally and will be available in navigation 2.6.0-alpha07

Message last modified on Feb 22, 2023 09:15PM

na...@google.com <na...@google.com> #4Mar 8, 2023 07:51PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.6.0-alpha07
androidx.navigation:navigation-runtime:2.6.0-alpha07

Issue 269302500

Description

Issue summary

Comments

cl...@google.com <cl...@google.com> Feb 16, 2023 12:15AM

ap...@google.com <ap...@google.com> #2Feb 22, 2023 06:19PM

cl...@google.com <cl...@google.com> #3Feb 22, 2023 07:06PM

na...@google.com <na...@google.com> #4Mar 8, 2023 07:51PM

Add comment

Issue metadata